Refactor envelope status translation logic

Simplified the logic for translating envelope status by using pattern matching to directly return the "Read and Sign" translation if available, otherwise falling back to the default. Also renamed the resource manager variable (note: introduced a typo as "rescourceManager").

EnvelopeGenerator.Domain/Entities/Envelope.cs

@@ -135,19 +135,13 @@ namespace EnvelopeGenerator.Domain.Entities
         {
             get
             {
-                var resourceManager = My.Resources.Model.ResourceManager;
                 var statusName = ((Constants.EnvelopeStatus)Status).ToString();
+                var rescourceManager = My.Resources.Model.ResourceManager;
 
-                if (this.IsReadAndSign())
-                {
-                    var statusNameRaC = statusName + "4RaC";
-                    var translationRaC = resourceManager.GetString(statusNameRaC);
+                if (this.IsReadAndSign() && rescourceManager.GetString(statusName + "4RaC") is string translationRaC)
+                    return translationRaC;
 
-                    if (!string.IsNullOrEmpty(translationRaC))
-                        return translationRaC;
-                }
-
-                return resourceManager.GetString(statusName);
+                return rescourceManager.GetString(statusName);
             }
         }
 

EnvelopeGenerator.Form/Controllers/EnvelopeEditorController.vb

@@ -50,7 +50,7 @@ Public Class EnvelopeEditorController
     Public Function ValidateEnvelopeForSending(pErrors As List(Of String)) As List(Of String)
         Dim oEnvelopeErrors = pErrors
 
-        If Envelope.EnvelopeTypeId <> ContractType.ReadAndSign Then
+        If Envelope.EnvelopeTypeId <> 2 Then
 
             If ElementModel.ElementsExist(Envelope.Id) = False Then
                 oEnvelopeErrors.Add(Resources.Envelope.Missing_Elements)