Add culture-specific formatting for SQL parameters

Updated ParamsExtensions to include System.Globalization for
culture-invariant formatting of double values. This change
ensures proper SQL parameterization by avoiding issues with
decimal separators across different cultures.

EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverCommandHandler.cs

@@ -60,8 +60,8 @@ public class CreateEnvelopeReceiverCommandHandler : IRequestHandler<CreateEnvelo
         }
 
         var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope);
-        res.UnsentRecipients = unsentRecipients;
-        res.SentRecipients = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients);
+        res.UnsentReceivers = unsentRecipients;
+        res.SentReceiver = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients);
         return res;
     }
 }

EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverDtos.cs

@@ -36,14 +36,12 @@ public record ReceiverGetOrCreateCommand([Required] IEnumerable<Signature> Signa
 /// <summary>
 /// DTO zum Erstellen eines Dokuments.
 /// </summary>
-/// <param name="DataAsByte">
-/// Die Dokumentdaten im Byte-Array-Format. Wird verwendet, wenn das Dokument als Roh-Binärdaten bereitgestellt wird.
-/// </param>
-public record DocumentCreateCommand(byte[]? DataAsByte = null)
+public record DocumentCreateCommand()
 {
     /// <summary>
     /// Die Dokumentdaten im Base64-String-Format. Wird verwendet, wenn das Dokument als Base64-codierter String bereitgestellt wird.
     /// </summary>
-    public string? DataAsBase64 { get; set; }
+    [Required]
+    public required string DataAsBase64 { get; init; }
 };
 #endregion

EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverResponse.cs

@@ -30,10 +30,10 @@ public record CreateEnvelopeReceiverResponse : CreateEnvelopeResponse
     /// <summary>
     /// 
     /// </summary>
-    public IEnumerable<ReceiverReadDto> SentRecipients { get; set; } = new List<ReceiverReadDto>();
+    public IEnumerable<ReceiverReadDto> SentReceiver { get; set; } = new List<ReceiverReadDto>();
 
     /// <summary>
     /// 
     /// </summary>
-    public IEnumerable<ReceiverGetOrCreateCommand> UnsentRecipients { get; set; } = new List<ReceiverGetOrCreateCommand>();
+    public IEnumerable<ReceiverGetOrCreateCommand> UnsentReceivers { get; set; } = new List<ReceiverGetOrCreateCommand>();
 }

EnvelopeGenerator.Application/SQL/DocumentCreateReadSQL.cs

@@ -10,19 +10,17 @@ namespace EnvelopeGenerator.Application.SQL;
 public class DocumentCreateReadSQL : ISQL<EnvelopeDocument>
 {
     /// <summary>
-    /// 
+    /// Base64, OUT_UID
     /// </summary>
     public string Raw => @"
-        USE [DD_ECM]
-
         DECLARE @BYTE_DATA1 as VARBINARY(MAX)
-        SET @BYTE_DATA1 = CONVERT(VARBINARY(MAX),'@Base64')
+        SET @BYTE_DATA1 = CONVERT(VARBINARY(MAX),{0})
         DECLARE	@OUT_DOCID int
 
         EXEC	[dbo].[PRSIG_API_ADD_DOC]
-		        @ENV_UID = @OUT_UID,
-		        @BYTE_DATA = @BYTE_DATA1,
-		        @OUT_DOCID = @OUT_DOCID OUTPUT
+		        {1},
+		        @BYTE_DATA1,
+		        @OUT_DOCID OUTPUT
 
         SELECT TOP(1) *
           FROM [dbo].[TBSIG_ENVELOPE_DOCUMENT]

EnvelopeGenerator.Application/SQL/EnvelopeCreateReadSQL.cs

@@ -1,6 +1,7 @@
 using Dapper;
 using EnvelopeGenerator.Application.Contracts.SQLExecutor;
 using EnvelopeGenerator.Domain.Entities;
+using System.Data;
 
 namespace EnvelopeGenerator.Application.SQL;
 
@@ -10,18 +11,17 @@ namespace EnvelopeGenerator.Application.SQL;
 public class EnvelopeCreateReadSQL : ISQL<Envelope>
 {
     /// <summary>
-    /// 
+    /// USER_ID, TITLE, TFAEnabled, MESSAGE
     /// </summary>
     public string Raw => @"
-        USE [DD_ECM];
         DECLARE @OUT_UID varchar(36);
 
         EXEC [dbo].[PRSIG_API_CREATE_ENVELOPE]
-            @USER_ID = @UserId,
-            @TITLE = @Title,
-            @TFAEnabled = @TfaEnabled,
-            @MESSAGE = @Message,
-            @OUT_UID = @OUT_UID OUTPUT;
+            {0},
+            {1},
+            {2},
+            {3},
+            @OUT_UID OUTPUT;
 
         SELECT TOP(1) *
         FROM [dbo].[TBSIG_ENVELOPE]
@@ -36,13 +36,14 @@ public class EnvelopeCreateReadSQL : ISQL<Envelope>
     /// <param name="message"></param>
     /// <param name="tfaEnabled"></param>
     /// <returns></returns>
-    public static DynamicParameters CreateParmas(int userId, string title = "", string message = "", bool tfaEnabled = false)
+    public static DynamicParameters CreateParams(int userId, string title = "", string message = "", bool tfaEnabled = false)
     {
         var parameters = new DynamicParameters();
         parameters.Add("@UserId", userId);
         parameters.Add("@Title", title);
         parameters.Add("@TfaEnabled", tfaEnabled ? 1 : 0);
         parameters.Add("@Message", message);
+        parameters.Add("@OutUid", dbType: DbType.String, size: 36, direction: ParameterDirection.Output);
         return parameters;
     }
 }

EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs

@@ -10,21 +10,20 @@ namespace EnvelopeGenerator.Application.SQL;
 public class EnvelopeReceiverAddReadSQL : ISQL<Envelope>
 {
     /// <summary>
-    /// 
+    /// ENV_UID, EMAIL_ADRESS, SALUTATION, PHONE, 
     /// </summary>
     public string Raw => @"
-		USE [DD_ECM]
 		DECLARE	@OUT_RECEIVER_ID int
 
 		EXEC	[dbo].[PRSIG_API_CREATE_RECEIVER]
-				@ENV_UID = @ENV_UID,
-				@EMAIL_ADRESS = @EMAIL_ADRESS,
-				@SALUTATION = @SALUTATION,
-				@PHONE = @PHONE,
-				@OUT_RECEIVER_ID = @OUT_RECEIVER_ID OUTPUT
+				{0},
+				{1},
+				{2},
+				{3},
+				@OUT_RECEIVER_ID OUTPUT
 
-		SELECT TOP(1) *
-		FROM TBSIG_ENVELOPE_RECEIVER
+        SELECT TOP(1) [ENVELOPE_ID] As EnvelopeId, [RECEIVER_ID] As ReceiverId
+        FROM [dbo].[TBSIG_ENVELOPE_RECEIVER]
 		WHERE [GUID] = @OUT_RECEIVER_ID;
 	";
 

EnvelopeGenerator.Application/SQL/ParamsExtensions.cs

@@ -0,0 +1,30 @@
+using System.Globalization;
+
+namespace EnvelopeGenerator.Application.SQL;
+
+/// <summary>
+/// Extension method for converting objects to SQL parameter strings.
+/// </summary>
+public static class ParamsExtensions
+{
+    /// <summary>
+    /// Converts a .NET object to its corresponding SQL-safe parameter string.
+    /// </summary>
+    /// <param name="obj">The object to convert.</param>
+    /// <returns>A string representing the SQL parameter.</returns>
+    public static string ToSqlParam(this object? obj)
+    {
+        if (obj is null)
+            return "NULL";
+        else if (obj is string strVal)
+            return $"'{strVal}'";
+        else if (obj is bool boolVal)
+            return boolVal ? "1" : "0";
+        else if (obj is double doubleVal)
+            return $"'{doubleVal.ToString(CultureInfo.InvariantCulture)}'";
+        else if (obj is int intVal)
+            return intVal.ToString();
+        else
+            throw new NotSupportedException($"Type '{obj.GetType().FullName}' is not supported for SQL parameter conversion.");
+    }
+}

EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs

@@ -6,6 +6,7 @@ using EnvelopeGenerator.Application.DTOs.Receiver;
 using EnvelopeGenerator.Application.EnvelopeReceivers.Commands.Create;
 using EnvelopeGenerator.Application.EnvelopeReceivers.Queries.Read;
 using EnvelopeGenerator.Application.Envelopes.Queries.ReceiverName;
+using EnvelopeGenerator.Application.SQL;
 using EnvelopeGenerator.Domain.Entities;
 using EnvelopeGenerator.GeneratorAPI.Models;
 using MediatR;
@@ -202,35 +203,25 @@ public class EnvelopeReceiverController : ControllerBase
             #endregion
 
             #region Add receivers
-            List<EnvelopeReceiver> sentRecipients = new();
-            List<ReceiverGetOrCreateCommand> unsentRecipients = new();
+            List<EnvelopeReceiver> sentReceivers = new();
+            List<ReceiverGetOrCreateCommand> unsentReceivers = new();
 
             foreach (var receiver in request.Receivers)
             {
                 var envelopeReceiver = await _erExecutor.AddEnvelopeReceiverAsync(envelope.Uuid, receiver.EmailAddress, receiver.Salution, receiver.PhoneNumber, cancel);
 
                 if (envelopeReceiver is null)
-                    unsentRecipients.Add(receiver);
+                    unsentReceivers.Add(receiver);
                 else
-                    sentRecipients.Add(envelopeReceiver);
+                    sentReceivers.Add(envelopeReceiver);
             }
 
             var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope);
-            res.UnsentRecipients = unsentRecipients;
-            res.SentRecipients = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients);
+            res.UnsentReceivers = unsentReceivers;
+            res.SentReceiver = _mapper.Map<List<ReceiverReadDto>>(sentReceivers.Select(er => er.Receiver));
             #endregion
 
             #region Add document
-            if(request.Document.DataAsBase64 is null)
-                if (request.Document.DataAsByte is null)
-                    return BadRequest("No document data is found");
-                else
-                    request.Document.DataAsBase64 = Convert.ToBase64String(request.Document.DataAsByte);
-            else if (request.Document.DataAsByte is not null)
-                return BadRequest("Document data cannot be assigned as both byte data and base64 string.");
-            else if (!IsBase64String(request.Document.DataAsBase64))
-                return BadRequest("Document data is not a base64 string");
-
             var document = await _documentExecutor.CreateDocumentAsync(request.Document.DataAsBase64, envelope.Uuid, cancel);
 
             if(document is null)
@@ -238,36 +229,31 @@ public class EnvelopeReceiverController : ControllerBase
             #endregion
 
             #region Add document element
+            // @DOC_ID, @RECEIVER_ID, @POSITION_X, @POSITION_Y, @PAGE
             string sql = @"
-                USE [DD_ECM]
-
                 DECLARE @OUT_SUCCESS bit;
 
                 EXEC [dbo].[PRSIG_API_ADD_DOC_RECEIVER_ELEM]
-                    @DOC_ID = @DOC_ID,
-                    @RECEIVER_ID = @RECEIVER_ID,
-                    @POSITION_X = @POSITION_X,
-                    @POSITION_Y = @POSITION_Y,
-                    @PAGE = @PAGE,
-                    @OUT_SUCCESS = @OUT_SUCCESS OUTPUT;
+                    {0},
+                    {1},
+                    {2},
+                    {3},
+                    {4},
+                    @OUT_SUCCESS OUTPUT;
 
                 SELECT @OUT_SUCCESS as [@OUT_SUCCESS];";
 
-            foreach(var rcv in res.SentRecipients)
+            foreach(var rcv in res.SentReceiver)
                 foreach(var sign in request.Receivers.Where(r => r.EmailAddress == rcv.EmailAddress).FirstOrDefault()?.Signatures ?? Array.Empty<Signature>())
                 {
                     using (SqlConnection conn = new(_cnnStr))
                     {
                         conn.Open();
 
-                        using SqlCommand cmd = new SqlCommand(sql, conn);
-                        cmd.CommandType = CommandType.Text;
+                        var formattedSQL = string.Format(sql, document.Id.ToSqlParam(), rcv.Id.ToSqlParam(), sign.X.ToSqlParam(), sign.Y.ToSqlParam(), sign.Page.ToSqlParam());
 
-                        cmd.Parameters.AddWithValue("@DOC_ID", document.Id);
-                        cmd.Parameters.AddWithValue("@RECEIVER_ID", rcv.Id);
-                        cmd.Parameters.AddWithValue("@POSITION_X", sign.X.ToString());
-                        cmd.Parameters.AddWithValue("@POSITION_Y", sign.Y.ToString());
-                        cmd.Parameters.AddWithValue("@PAGE", sign.Page.ToString());
+                        using SqlCommand cmd = new SqlCommand(formattedSQL, conn);
+                        cmd.CommandType = CommandType.Text;
 
                         using SqlDataReader reader = cmd.ExecuteReader();
                         if (reader.Read())
@@ -279,33 +265,28 @@ public class EnvelopeReceiverController : ControllerBase
             #endregion
 
             #region Create history
-            string connectionString = "Server=YOUR_SERVER;Database=YOUR_DATABASE;Trusted_Connection=True;";
-
+            // ENV_UID, STATUS_ID, USER_ID,
             string sql_hist = @"
                 USE [DD_ECM]
 
                 DECLARE @OUT_SUCCESS bit;
 
                 EXEC [dbo].[PRSIG_API_ADD_HISTORY_STATE]
-                    @ENV_UID = @ENV_UID,
-                    @STATUS_ID = @STATUS_ID,
-                    @USER_ID = @USER_ID,
-                    @OUT_SUCCESS = @OUT_SUCCESS OUTPUT;
+                    {0},
+                    {1},
+                    {2},
+                    @OUT_SUCCESS OUTPUT;
 
                 SELECT @OUT_SUCCESS as [@OUT_SUCCESS];";
 
-            using (SqlConnection conn = new(connectionString))
+            using (SqlConnection conn = new(_cnnStr))
             {
                 conn.Open();
-
-                using (SqlCommand cmd = new SqlCommand(sql_hist, conn))
+                var formattedSQL_hist = string.Format(sql_hist, envelope.Uuid.ToSqlParam(), 1003.ToSqlParam(), userId.ToSqlParam());
+                using (SqlCommand cmd = new SqlCommand(formattedSQL_hist, conn))
                 {
                     cmd.CommandType = CommandType.Text;
 
-                    cmd.Parameters.AddWithValue("@ENV_UID", envelope.Uuid);
-                    cmd.Parameters.AddWithValue("@STATUS_ID", 1003);
-                    cmd.Parameters.AddWithValue("@USER_ID", userId);
-
                     using (SqlDataReader reader = cmd.ExecuteReader())
                     {
                         if (reader.Read())

EnvelopeGenerator.Infrastructure/Executor/DocumentExecutor.cs

@@ -18,9 +18,9 @@ public class DocumentExecutor : SQLExecutor, IDocumentExecutor
     {
         using var connection = new SqlConnection(Params.ConnectionString);
         var sql = Provider.GetRequiredService<DocumentCreateReadSQL>();
+        var formattedSql = string.Format(sql.Raw, base64.ToSqlParam(), envelope_uuid.ToSqlParam());
         await connection.OpenAsync(cancellation);
-        var parameters = DocumentCreateReadSQL.CreateParmas(base64, envelope_uuid);
-        var documents = await connection.QueryAsync<EnvelopeDocument>(sql.Raw, parameters);
+        var documents = await connection.QueryAsync<EnvelopeDocument>(formattedSql);
         return documents.FirstOrDefault()
             ?? throw new InvalidOperationException($"Document creation failed. Parameters:" +
             $"base64={base64}, envelope_uuid='{envelope_uuid}'.");

EnvelopeGenerator.Infrastructure/Executor/EnvelopeExecutor.cs

@@ -23,9 +23,9 @@ public class EnvelopeExecutor : SQLExecutor, IEnvelopeExecutor
     {
         using var connection = new SqlConnection(Params.ConnectionString);
         var sql = Provider.GetRequiredService<EnvelopeCreateReadSQL>();
+        var formattedSql = string.Format(sql.Raw, userId.ToSqlParam(), title.ToSqlParam(), tfaEnabled.ToSqlParam(), message.ToSqlParam());
         await connection.OpenAsync(cancellation);
-        var parameters = EnvelopeCreateReadSQL.CreateParmas(userId, title, message, tfaEnabled);
-        var envelopes = await connection.QueryAsync<Envelope>(sql.Raw, parameters);
+        var envelopes = await connection.QueryAsync<Envelope>(formattedSql);
         var envelope = envelopes.FirstOrDefault()
             ?? throw new InvalidOperationException($"Envelope creation failed. Parameters:" +
             $"userId={userId}, title='{title}', message='{message}', tfaEnabled={tfaEnabled}."); ;

EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs

@@ -5,7 +5,6 @@ using EnvelopeGenerator.Application.SQL;
 using EnvelopeGenerator.Domain.Entities;
 using Microsoft.Data.SqlClient;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
 namespace EnvelopeGenerator.Infrastructure.Executor;
@@ -23,8 +22,9 @@ public class EnvelopeReceiverExecutor: SQLExecutor, IEnvelopeReceiverExecutor
     {
         using var connection = new SqlConnection(Params.ConnectionString);
         var sql = Provider.GetRequiredService<EnvelopeReceiverAddReadSQL>();
+        var formattedSql = string.Format(sql.Raw, envelope_uuid.ToSqlParam(), emailAddress.ToSqlParam(), salutation.ToSqlParam(), phone.ToSqlParam());
         await connection.OpenAsync(cancellation);
-        var envelopeReceivers = await connection.QueryAsync<EnvelopeReceiver>(sql.Raw, EnvelopeReceiverAddReadSQL.CreateParameters(envelope_uuid, emailAddress, salutation, phone));
+        var envelopeReceivers = await connection.QueryAsync(formattedSql);
         var er = envelopeReceivers.FirstOrDefault();
 
         if (er is null)