AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor(controller): Optimierung der Handhabung von Referenztypen im HistoryController

Browse Source 
- `GetAllAsync`-Methode angepasst, um `withSender` oder `withReceiver` automatisch basierend auf dem `ReferenceType` zu setzen.
- Unnötigen `status`-Query-Parameter entfernt, um die API zu vereinfachen.
This commit is contained in:
Developer 02
2024-09-07 01:32:09 +02:00
parent ab41e25071
commit cd88f5c833
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
EnvelopeGenerator.GeneratorAPI/Controllers/HistoryController.cs
View File

@@ -40,7 +40,7 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers
[HttpGet] [HttpGet]
[Authorize] [Authorize]
public async Task<IActionResult> GetAllAsync([FromQuery] int? envelopeId = null, [FromQuery] string? userReference = null, [FromQuery] int? referenceType = null, [FromQuery] int? status = null, [FromQuery] bool withSender = false, [FromQuery] bool withReceiver = false) public async Task<IActionResult> GetAllAsync([FromQuery] int? envelopeId = null, [FromQuery] string? userReference = null, [FromQuery] int? referenceType = null, [FromQuery] bool withSender = false, [FromQuery] bool withReceiver = false)
{ {
ReferenceType? refTypEnum = null; ReferenceType? refTypEnum = null;
@@ -52,11 +52,20 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers
else else
throw new ArgumentException($"The provided referenceType '{referenceType}' is not valid. It must correspond to a valid value in the {nameof(ReferenceType)} enum."); throw new ArgumentException($"The provided referenceType '{referenceType}' is not valid. It must correspond to a valid value in the {nameof(ReferenceType)} enum.");
switch(referenceType)
{
case (int)ReferenceType.Receiver:
withReceiver = true;
break;
case (int)ReferenceType.Sender:
withSender = true;
break;
}
var histories = await _service.ReadAsync( var histories = await _service.ReadAsync(
envelopeId: envelopeId, envelopeId: envelopeId,
userReference: userReference, userReference: userReference,
referenceType: refTypEnum, referenceType: refTypEnum,
status: status,
withSender: withSender, withSender: withSender,
withReceiver: withReceiver); withReceiver: withReceiver);