From cd88f5c8336632d8e09e8a93a43a835926f70925 Mon Sep 17 00:00:00 2001 From: Developer 02 Date: Sat, 7 Sep 2024 01:32:09 +0200 Subject: [PATCH] refactor(controller): Optimierung der Handhabung von Referenztypen im HistoryController MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - `GetAllAsync`-Methode angepasst, um `withSender` oder `withReceiver` automatisch basierend auf dem `ReferenceType` zu setzen. - Unnötigen `status`-Query-Parameter entfernt, um die API zu vereinfachen. --- .../Controllers/HistoryController.cs | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/EnvelopeGenerator.GeneratorAPI/Controllers/HistoryController.cs b/EnvelopeGenerator.GeneratorAPI/Controllers/HistoryController.cs index 17431ca8..b6670838 100644 --- a/EnvelopeGenerator.GeneratorAPI/Controllers/HistoryController.cs +++ b/EnvelopeGenerator.GeneratorAPI/Controllers/HistoryController.cs @@ -40,7 +40,7 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers [HttpGet] [Authorize] - public async Task GetAllAsync([FromQuery] int? envelopeId = null, [FromQuery] string? userReference = null, [FromQuery] int? referenceType = null, [FromQuery] int? status = null, [FromQuery] bool withSender = false, [FromQuery] bool withReceiver = false) + public async Task GetAllAsync([FromQuery] int? envelopeId = null, [FromQuery] string? userReference = null, [FromQuery] int? referenceType = null, [FromQuery] bool withSender = false, [FromQuery] bool withReceiver = false) { ReferenceType? refTypEnum = null; @@ -52,11 +52,20 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers else throw new ArgumentException($"The provided referenceType '{referenceType}' is not valid. It must correspond to a valid value in the {nameof(ReferenceType)} enum."); + switch(referenceType) + { + case (int)ReferenceType.Receiver: + withReceiver = true; + break; + case (int)ReferenceType.Sender: + withSender = true; + break; + } + var histories = await _service.ReadAsync( envelopeId: envelopeId, userReference: userReference, referenceType: refTypEnum, - status: status, withSender: withSender, withReceiver: withReceiver);