AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename recipient properties for consistency

Browse Source 
Updated `CreateEnvelopeReceiverResponse` and `EnvelopeReceiverController` to rename `SentRecipients` to `SentReceiver` and `UnsentRecipients` to `UnsentReceivers`. Adjusted corresponding lists and mappings to ensure uniformity in naming conventions across the codebase.
This commit is contained in:
Developer 02
2025-05-07 14:26:50 +02:00
parent 1875acb7b5
commit c8f21be905
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverCommandHandler.cs
View File

@@ -60,8 +60,8 @@ public class CreateEnvelopeReceiverCommandHandler : IRequestHandler<CreateEnvelo
} }
var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope); var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope);
res.UnsentRecipients = unsentRecipients; res.UnsentReceivers = unsentRecipients;
res.SentRecipients = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients); res.SentReceiver = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients);
return res; return res;
} }
} }

4
EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverResponse.cs
View File

@@ -30,10 +30,10 @@ public record CreateEnvelopeReceiverResponse : CreateEnvelopeResponse
/// <summary> /// <summary>
/// ///
/// </summary> /// </summary>
public IEnumerable<ReceiverReadDto> SentRecipients { get; set; } = new List<ReceiverReadDto>(); public IEnumerable<ReceiverReadDto> SentReceiver { get; set; } = new List<ReceiverReadDto>();
/// <summary> /// <summary>
/// ///
/// </summary> /// </summary>
public IEnumerable<ReceiverGetOrCreateCommand> UnsentRecipients { get; set; } = new List<ReceiverGetOrCreateCommand>(); public IEnumerable<ReceiverGetOrCreateCommand> UnsentReceivers { get; set; } = new List<ReceiverGetOrCreateCommand>();
} }

14
EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs
View File

@@ -202,22 +202,22 @@ public class EnvelopeReceiverController : ControllerBase
#endregion #endregion
#region Add receivers #region Add receivers
List<EnvelopeReceiver> sentRecipients = new(); List<EnvelopeReceiver> sentReceivers = new();
List<ReceiverGetOrCreateCommand> unsentRecipients = new(); List<ReceiverGetOrCreateCommand> unsentReceivers = new();
foreach (var receiver in request.Receivers) foreach (var receiver in request.Receivers)
{ {
var envelopeReceiver = await _erExecutor.AddEnvelopeReceiverAsync(envelope.Uuid, receiver.EmailAddress, receiver.Salution, receiver.PhoneNumber, cancel); var envelopeReceiver = await _erExecutor.AddEnvelopeReceiverAsync(envelope.Uuid, receiver.EmailAddress, receiver.Salution, receiver.PhoneNumber, cancel);
if (envelopeReceiver is null) if (envelopeReceiver is null)
unsentRecipients.Add(receiver); unsentReceivers.Add(receiver);
else else
sentRecipients.Add(envelopeReceiver); sentReceivers.Add(envelopeReceiver);
} }
var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope); var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope);
res.UnsentRecipients = unsentRecipients; res.UnsentReceivers = unsentReceivers;
res.SentRecipients = _mapper.Map<List<ReceiverReadDto>>(sentRecipients); res.SentReceiver = _mapper.Map<List<ReceiverReadDto>>(sentReceivers.Select(er => er.Receiver));
#endregion #endregion
#region Add document #region Add document
@@ -243,7 +243,7 @@ public class EnvelopeReceiverController : ControllerBase
SELECT @OUT_SUCCESS as [@OUT_SUCCESS];"; SELECT @OUT_SUCCESS as [@OUT_SUCCESS];";
foreach(var rcv in res.SentRecipients) foreach(var rcv in res.SentReceiver)
foreach(var sign in request.Receivers.Where(r => r.EmailAddress == rcv.EmailAddress).FirstOrDefault()?.Signatures ?? Array.Empty<Signature>()) foreach(var sign in request.Receivers.Where(r => r.EmailAddress == rcv.EmailAddress).FirstOrDefault()?.Signatures ?? Array.Empty<Signature>())
{ {
using (SqlConnection conn = new(_cnnStr)) using (SqlConnection conn = new(_cnnStr))