From c8f21be9051cbeb1ff7ddd5acf6c8debc54fb51e Mon Sep 17 00:00:00 2001
From: Developer 02 <developer02@didaloghe.onmicrosoft.com>
Date: Wed, 7 May 2025 14:26:50 +0200
Subject: [PATCH] Rename recipient properties for consistency

Updated `CreateEnvelopeReceiverResponse` and `EnvelopeReceiverController` to rename `SentRecipients` to `SentReceiver` and `UnsentRecipients` to `UnsentReceivers`. Adjusted corresponding lists and mappings to ensure uniformity in naming conventions across the codebase.
---
 .../Create/CreateEnvelopeReceiverCommandHandler.cs |  4 ++--
 .../Create/CreateEnvelopeReceiverResponse.cs       |  4 ++--
 .../Controllers/EnvelopeReceiverController.cs      | 14 +++++++-------
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverCommandHandler.cs b/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverCommandHandler.cs
index 9ba2098e..3ab6fda1 100644
--- a/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverCommandHandler.cs
+++ b/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverCommandHandler.cs
@@ -60,8 +60,8 @@ public class CreateEnvelopeReceiverCommandHandler : IRequestHandler<CreateEnvelo
         }
 
         var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope);
-        res.UnsentRecipients = unsentRecipients;
-        res.SentRecipients = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients);
+        res.UnsentReceivers = unsentRecipients;
+        res.SentReceiver = _mapper.Map<IEnumerable<ReceiverReadDto>>(sentRecipients);
         return res;
     }
 }
diff --git a/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverResponse.cs b/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverResponse.cs
index b20b72ca..251e6ceb 100644
--- a/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverResponse.cs
+++ b/EnvelopeGenerator.Application/EnvelopeReceivers/Commands/Create/CreateEnvelopeReceiverResponse.cs
@@ -30,10 +30,10 @@ public record CreateEnvelopeReceiverResponse : CreateEnvelopeResponse
     /// <summary>
     /// 
     /// </summary>
-    public IEnumerable<ReceiverReadDto> SentRecipients { get; set; } = new List<ReceiverReadDto>();
+    public IEnumerable<ReceiverReadDto> SentReceiver { get; set; } = new List<ReceiverReadDto>();
 
     /// <summary>
     /// 
     /// </summary>
-    public IEnumerable<ReceiverGetOrCreateCommand> UnsentRecipients { get; set; } = new List<ReceiverGetOrCreateCommand>();
+    public IEnumerable<ReceiverGetOrCreateCommand> UnsentReceivers { get; set; } = new List<ReceiverGetOrCreateCommand>();
 }
diff --git a/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs b/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs
index dfeb2628..86411eea 100644
--- a/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs
+++ b/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs
@@ -202,22 +202,22 @@ public class EnvelopeReceiverController : ControllerBase
             #endregion
 
             #region Add receivers
-            List<EnvelopeReceiver> sentRecipients = new();
-            List<ReceiverGetOrCreateCommand> unsentRecipients = new();
+            List<EnvelopeReceiver> sentReceivers = new();
+            List<ReceiverGetOrCreateCommand> unsentReceivers = new();
 
             foreach (var receiver in request.Receivers)
             {
                 var envelopeReceiver = await _erExecutor.AddEnvelopeReceiverAsync(envelope.Uuid, receiver.EmailAddress, receiver.Salution, receiver.PhoneNumber, cancel);
 
                 if (envelopeReceiver is null)
-                    unsentRecipients.Add(receiver);
+                    unsentReceivers.Add(receiver);
                 else
-                    sentRecipients.Add(envelopeReceiver);
+                    sentReceivers.Add(envelopeReceiver);
             }
 
             var res = _mapper.Map<CreateEnvelopeReceiverResponse>(envelope);
-            res.UnsentRecipients = unsentRecipients;
-            res.SentRecipients = _mapper.Map<List<ReceiverReadDto>>(sentRecipients);
+            res.UnsentReceivers = unsentReceivers;
+            res.SentReceiver = _mapper.Map<List<ReceiverReadDto>>(sentReceivers.Select(er => er.Receiver));
             #endregion
 
             #region Add document
@@ -243,7 +243,7 @@ public class EnvelopeReceiverController : ControllerBase
 
                 SELECT @OUT_SUCCESS as [@OUT_SUCCESS];";
 
-            foreach(var rcv in res.SentRecipients)
+            foreach(var rcv in res.SentReceiver)
                 foreach(var sign in request.Receivers.Where(r => r.EmailAddress == rcv.EmailAddress).FirstOrDefault()?.Signatures ?? Array.Empty<Signature>())
                 {
                     using (SqlConnection conn = new(_cnnStr))