fix: Füge try-catch-Blöcke zur Fehlerbehandlung in der Delete-Methode und dem Service hinzu

This commit is contained in:
Developer 02 2024-08-21 17:09:16 +02:00
parent 306956a7be
commit 1673ea81df

View File

@ -29,14 +29,22 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers
if (emailAddress is null && signature is null) if (emailAddress is null && signature is null)
return await base.GetAll(); return await base.GetAll();
try
{
return await _service.ReadByAsync(emailAddress: emailAddress, signature: signature).ThenAsync( return await _service.ReadByAsync(emailAddress: emailAddress, signature: signature).ThenAsync(
Success: Ok, Success: Ok,
Fail: IActionResult (msg,ntc) => Fail: IActionResult (msg, ntc) =>
{ {
_logger.LogNotice(ntc); _logger.LogNotice(ntc);
return StatusCode(StatusCodes.Status500InternalServerError); return StatusCode(StatusCodes.Status500InternalServerError);
}); });
} }
catch
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(500);
}
}
[HttpPost] [HttpPost]
public async override Task<IActionResult> Create(ReceiverCreateDto createDto) public async override Task<IActionResult> Create(ReceiverCreateDto createDto)
@ -59,7 +67,9 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers
if(id is int id_int) if(id is int id_int)
return await base.Delete(id_int); return await base.Delete(id_int);
if (emailAddress is not null && signature is not null) try
{
if (emailAddress is not null || signature is not null)
return await _service.DeleteByAsync(emailAddress: emailAddress, signature: signature).ThenAsync( return await _service.DeleteByAsync(emailAddress: emailAddress, signature: signature).ThenAsync(
Success: Ok, Success: Ok,
Fail: IActionResult (msg, ntc) => Fail: IActionResult (msg, ntc) =>
@ -67,6 +77,12 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers
_logger.LogNotice(ntc); _logger.LogNotice(ntc);
return StatusCode(StatusCodes.Status500InternalServerError); return StatusCode(StatusCodes.Status500InternalServerError);
}); });
}
catch(Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(500);
}
return BadRequest(); return BadRequest();
} }