From 1673ea81df956aef84380c46454dc2ab85c9a77f Mon Sep 17 00:00:00 2001 From: Developer 02 Date: Wed, 21 Aug 2024 17:09:16 +0200 Subject: [PATCH] =?UTF-8?q?fix:=20F=C3=BCge=20`try-catch`-Bl=C3=B6cke=20zu?= =?UTF-8?q?r=20Fehlerbehandlung=20in=20der=20Delete-Methode=20und=20dem=20?= =?UTF-8?q?Service=20hinzu?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Controllers/ReceiverController.cs | 46 +++++++++++++------ 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/EnvelopeGenerator.GeneratorAPI/Controllers/ReceiverController.cs b/EnvelopeGenerator.GeneratorAPI/Controllers/ReceiverController.cs index cea340e8..40f973c5 100644 --- a/EnvelopeGenerator.GeneratorAPI/Controllers/ReceiverController.cs +++ b/EnvelopeGenerator.GeneratorAPI/Controllers/ReceiverController.cs @@ -29,13 +29,21 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers if (emailAddress is null && signature is null) return await base.GetAll(); - return await _service.ReadByAsync(emailAddress: emailAddress, signature: signature).ThenAsync( - Success: Ok, - Fail: IActionResult (msg,ntc) => - { - _logger.LogNotice(ntc); - return StatusCode(StatusCodes.Status500InternalServerError); - }); + try + { + return await _service.ReadByAsync(emailAddress: emailAddress, signature: signature).ThenAsync( + Success: Ok, + Fail: IActionResult (msg, ntc) => + { + _logger.LogNotice(ntc); + return StatusCode(StatusCodes.Status500InternalServerError); + }); + } + catch + { + _logger.LogError(ex, "{Message}", ex.Message); + return StatusCode(500); + } } [HttpPost] @@ -59,14 +67,22 @@ namespace EnvelopeGenerator.GeneratorAPI.Controllers if(id is int id_int) return await base.Delete(id_int); - if (emailAddress is not null && signature is not null) - return await _service.DeleteByAsync(emailAddress: emailAddress, signature: signature).ThenAsync( - Success: Ok, - Fail: IActionResult (msg, ntc) => - { - _logger.LogNotice(ntc); - return StatusCode(StatusCodes.Status500InternalServerError); - }); + try + { + if (emailAddress is not null || signature is not null) + return await _service.DeleteByAsync(emailAddress: emailAddress, signature: signature).ThenAsync( + Success: Ok, + Fail: IActionResult (msg, ntc) => + { + _logger.LogNotice(ntc); + return StatusCode(StatusCodes.Status500InternalServerError); + }); + } + catch(Exception ex) + { + _logger.LogError(ex, "{Message}", ex.Message); + return StatusCode(500); + } return BadRequest(); }