Files
ECMJobRunner/ECMJobRunner.Application/Profiles/Commands/Behaviors/MainQueryExecutionBehavior.cs
TekH d7c8607fbf Fix conditional logic and update exception message
Updated the `else if` condition to use a logical AND (`&&`)
instead of a logical OR (`||`) to ensure the condition checks
if `result.ReturnValue` is both not null and not equal to 0.

Aligned the exception message with the updated logic to
indicate that the expected value is "null or 0" instead of
just "null." This change improves correctness and prevents
unintended behavior.
2026-08-05 09:27:48 +02:00

118 lines
5.1 KiB
C#

using ECMJobRunner.Application.Common.Constants;
using ECMJobRunner.Application.Common.Dtos;
using ECMJobRunner.Application.Common.Exceptions;
using ECMJobRunner.Application.Common.Interfaces;
using ECMJobRunner.Application.Common.Options;
using ECMJobRunner.Application.Profiles.Commands;
using MediatR;
using Microsoft.Extensions.Options;
using System;
using System.Text.RegularExpressions;
using System.Threading;
using System.Threading.Tasks;
namespace ECMJobRunner.Application.Profiles.Commands.Behaviors
{
/// <summary>
/// Pipeline behavior that executes the main SQL query for DEX jobs
/// Runs before the command handler and validates query results
/// </summary>
/// <typeparam name="TRequest">The request type</typeparam>
/// <typeparam name="TResponse">The response type</typeparam>
public class MainQueryExecutionBehavior<TRequest, TResponse> : IPipelineBehavior<TRequest, TResponse>
where TRequest : notnull
{
private readonly ISQLExecutor _executor;
private readonly DexJobOptions _options;
/// <summary>
/// Initializes a new instance of MainQueryExecutionBehavior
/// </summary>
/// <param name="executor">SQL executor for query execution</param>
/// <param name="options">DEX job configuration options</param>
public MainQueryExecutionBehavior(ISQLExecutor executor, IOptions<DexJobOptions> options)
{
_executor = executor;
_options = options.Value;
}
/// <summary>
/// Handles the pipeline behavior
/// Executes main query if request is TriggeringDEXJobCommand
/// </summary>
#if NET48
public async Task<TResponse> Handle(TRequest request, CancellationToken cancellationToken, RequestHandlerDelegate<TResponse> next)
#else
public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TResponse> next, CancellationToken cancellationToken)
#endif
{
if (request is TriggeringProfileJobCommand command)
{
await ExecuteMainQueryAsync(command, cancellationToken);
}
return await next();
}
private async Task ExecuteMainQueryAsync(TriggeringProfileJobCommand command, CancellationToken cancel)
{
if (!string.IsNullOrWhiteSpace(command.Job.SqlMainQuery))
{
var sqlMainQuery = Regex.Replace(
command.Job.SqlMainQuery!,
_options.Placeholders.BatchId.Pattern,
command.BatchId,
_options.Placeholders.BatchId.RegexOptions);
try
{
var result = await _executor.ExecuteQueryAsync<MainQueryResult>(sqlMainQuery, cancel);
if (_options.Error.MainQuery.OnUnexpectedResult == ErrorAction.Stop)
{
if (result is null)
throw new JobSqlException(
profileId: command.Job.ProfileId,
jobName: "Triggering DEX",
processName: "Main Query",
batchId: command.BatchId,
reason: "Main Query returned nothing.",
query: sqlMainQuery,
innerException: null);
else if (result.ReturnValue is not null && result.ReturnValue != 0)
throw new JobSqlException(
profileId: command.Job.ProfileId,
jobName: "Triggering DEX",
processName: "Main Query",
batchId: command.BatchId,
reason: $"The query unexpectedly returned the value {result.ReturnValue}. The expected value was null or 0.",
query: sqlMainQuery, innerException: null);
}
}
catch (Exception ex)
{
if (_options.Error.MainQuery.OnExecution == ErrorAction.Stop)
throw new JobSqlException(
profileId: command.Job.ProfileId,
jobName: "Triggering DEX",
processName: "Main Query",
batchId: command.BatchId,
reason: null,
query: sqlMainQuery,
innerException: ex);
}
}
else if (_options.Error.MainQuery.IfNullOrWhiteSpace == ErrorAction.Stop)
{
throw new JobSqlException(
profileId: command.Job.ProfileId,
jobName: "Triggering DEX",
processName: "Main Query",
batchId: command.BatchId,
reason: "SQL Check Query is null or empty",
query: null,
innerException: null);
}
}
}
}