AppStd/DigitalData.UserManager
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(UserController): remove try-catch block

Browse Source
This commit is contained in:
Developer 02 2025-08-05 19:50:04 +02:00
parent e0683a8d17
commit 5f41e1b604
1 changed files with 30 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
src/DigitalData.UserManager.API/Controllers/UserController.cs
View File

@ -18,84 +18,52 @@ public class UserController : BaseAuthController<IUserService, UserCreateDto, Us
} }
[HttpGet("ByModuleId/{moduleId}")] [HttpGet("ByModuleId/{moduleId}")]
public async Task<IActionResult> GetByModuleId([FromRoute] int moduleId, [FromQuery]bool assigned = true) public async Task<IActionResult> GetByModuleId([FromRoute] int moduleId, [FromQuery] bool assigned = true)
{ {
try return await (assigned ? _service.ReadByModuleIdAsync(moduleId) : _service.ReadUnassignedByModuleIdAsync(moduleId))
{ .ThenAsync(Ok, IActionResult (m, n) =>
return await (assigned ? _service.ReadByModuleIdAsync(moduleId) : _service.ReadUnassignedByModuleIdAsync(moduleId)) {
.ThenAsync(Ok, IActionResult(m, n) => _logger.LogNotice(n);
{ return StatusCode(StatusCodes.Status500InternalServerError);
_logger.LogNotice(n); });
return StatusCode(StatusCodes.Status500InternalServerError);
});
}
catch(Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(StatusCodes.Status500InternalServerError);
}
} }
[HttpGet("ByGroupId/{groupId}")] [HttpGet("ByGroupId/{groupId}")]
public async Task<IActionResult> GetByGroupId([FromRoute] int groupId, [FromQuery] bool assigned = true) public async Task<IActionResult> GetByGroupId([FromRoute] int groupId, [FromQuery] bool assigned = true)
{ {
try return await (assigned ? _service.ReadByGroupIdAsync(groupId) : _service.ReadUnassignedByGroupIdAsync(groupId))
{ .ThenAsync(Ok, IActionResult (m, n) =>
return await (assigned ? _service.ReadByGroupIdAsync(groupId) : _service.ReadUnassignedByGroupIdAsync(groupId)) {
.ThenAsync(Ok, IActionResult (m, n) => _logger.LogNotice(n);
{ return StatusCode(StatusCodes.Status500InternalServerError);
_logger.LogNotice(n); });
return StatusCode(StatusCodes.Status500InternalServerError);
});
}
catch(Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(StatusCodes.Status500InternalServerError);
}
} }
[HttpPost("ByDir")] [HttpPost("ByDir")]
public async Task<IActionResult> CreateByDir(UserPrincipalDto upDto) public async Task<IActionResult> CreateByDir(UserPrincipalDto upDto)
{ {
try return await _service.CreateAsync(upDto).ThenAsync(
{ Success: id =>
return await _service.CreateAsync(upDto).ThenAsync( {
Success: id => var createdResource = new { Id = id };
{ var actionName = nameof(GetById);
var createdResource = new { Id = id }; var routeValues = new { id = createdResource.Id };
var actionName = nameof(GetById); return CreatedAtAction(actionName, routeValues, createdResource);
var routeValues = new { id = createdResource.Id }; },
return CreatedAtAction(actionName, routeValues, createdResource); Fail: IActionResult (m, n) =>
}, {
Fail: IActionResult (m, n) => _logger.LogNotice(n);
{ return BadRequest();
_logger.LogNotice(n); });
return BadRequest();
});
}
catch(Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(StatusCodes.Status500InternalServerError);
}
} }
[HttpGet("ByUsername/{username}")] [HttpGet("ByUsername/{username}")]
public virtual async Task<IActionResult> GetByUsername([FromRoute] string username) public virtual async Task<IActionResult> GetByUsername([FromRoute] string username)
{ {
try return await _service.ReadByUsernameAsync(username).ThenAsync(Ok, IActionResult (m, n) =>
{ {
return await _service.ReadByUsernameAsync(username).ThenAsync(Ok, IActionResult (m, n) => _logger.LogNotice(n);
{ return NotFound();
_logger.LogNotice(n); });
return NotFound();
});
}
catch(Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(StatusCodes.Status500InternalServerError);
}
} }
} }