From 5f41e1b60465093c83cffdea740fbb23a43a13c7 Mon Sep 17 00:00:00 2001
From: Developer 02 <developer02@didaloghe.onmicrosoft.com>
Date: Tue, 5 Aug 2025 19:50:04 +0200
Subject: [PATCH] refactor(UserController): remove try-catch block

---
 .../Controllers/UserController.cs             | 92 ++++++-------------
 1 file changed, 30 insertions(+), 62 deletions(-)

diff --git a/src/DigitalData.UserManager.API/Controllers/UserController.cs b/src/DigitalData.UserManager.API/Controllers/UserController.cs
index dd7be83..bb88f81 100644
--- a/src/DigitalData.UserManager.API/Controllers/UserController.cs
+++ b/src/DigitalData.UserManager.API/Controllers/UserController.cs
@@ -18,84 +18,52 @@ public class UserController : BaseAuthController<IUserService, UserCreateDto, Us
     }
 
     [HttpGet("ByModuleId/{moduleId}")]
-    public async Task<IActionResult> GetByModuleId([FromRoute] int moduleId, [FromQuery]bool assigned = true)
+    public async Task<IActionResult> GetByModuleId([FromRoute] int moduleId, [FromQuery] bool assigned = true)
     {
-        try
-        {
-            return await (assigned ? _service.ReadByModuleIdAsync(moduleId) : _service.ReadUnassignedByModuleIdAsync(moduleId))
-                .ThenAsync(Ok, IActionResult(m, n) =>
-                {
-                    _logger.LogNotice(n);
-                    return StatusCode(StatusCodes.Status500InternalServerError);
-                });
-        }
-        catch(Exception ex)
-        {
-            _logger.LogError(ex, "{Message}", ex.Message);
-            return StatusCode(StatusCodes.Status500InternalServerError);
-        }
+        return await (assigned ? _service.ReadByModuleIdAsync(moduleId) : _service.ReadUnassignedByModuleIdAsync(moduleId))
+            .ThenAsync(Ok, IActionResult (m, n) =>
+            {
+                _logger.LogNotice(n);
+                return StatusCode(StatusCodes.Status500InternalServerError);
+            });
     }
 
     [HttpGet("ByGroupId/{groupId}")]
     public async Task<IActionResult> GetByGroupId([FromRoute] int groupId, [FromQuery] bool assigned = true)
     {
-        try
-        {
-            return await (assigned ? _service.ReadByGroupIdAsync(groupId) : _service.ReadUnassignedByGroupIdAsync(groupId))
-                .ThenAsync(Ok, IActionResult (m, n) =>
-                {
-                    _logger.LogNotice(n);
-                    return StatusCode(StatusCodes.Status500InternalServerError);
-                });
-        }
-        catch(Exception ex)
-        {
-            _logger.LogError(ex, "{Message}", ex.Message);
-            return StatusCode(StatusCodes.Status500InternalServerError);
-        }
+        return await (assigned ? _service.ReadByGroupIdAsync(groupId) : _service.ReadUnassignedByGroupIdAsync(groupId))
+            .ThenAsync(Ok, IActionResult (m, n) =>
+            {
+                _logger.LogNotice(n);
+                return StatusCode(StatusCodes.Status500InternalServerError);
+            });
     }
 
     [HttpPost("ByDir")]
     public async Task<IActionResult> CreateByDir(UserPrincipalDto upDto)
     {
-        try
-        {
-            return await _service.CreateAsync(upDto).ThenAsync(
-                Success: id =>
-                {
-                    var createdResource = new { Id = id };
-                    var actionName = nameof(GetById);
-                    var routeValues = new { id = createdResource.Id };
-                    return CreatedAtAction(actionName, routeValues, createdResource);
-                },
-                Fail: IActionResult (m, n) =>
-                {
-                    _logger.LogNotice(n);
-                    return BadRequest();
-                });
-        }
-        catch(Exception ex)
-        {
-            _logger.LogError(ex, "{Message}", ex.Message);
-            return StatusCode(StatusCodes.Status500InternalServerError);
-        }
+        return await _service.CreateAsync(upDto).ThenAsync(
+            Success: id =>
+            {
+                var createdResource = new { Id = id };
+                var actionName = nameof(GetById);
+                var routeValues = new { id = createdResource.Id };
+                return CreatedAtAction(actionName, routeValues, createdResource);
+            },
+            Fail: IActionResult (m, n) =>
+            {
+                _logger.LogNotice(n);
+                return BadRequest();
+            });
     }
 
     [HttpGet("ByUsername/{username}")]
     public virtual async Task<IActionResult> GetByUsername([FromRoute] string username)
     {
-        try
-        {
-            return await _service.ReadByUsernameAsync(username).ThenAsync(Ok, IActionResult (m, n) =>
-            {
-                _logger.LogNotice(n);
-                return NotFound();
-            });
-        }
-        catch(Exception ex)
+        return await _service.ReadByUsernameAsync(username).ThenAsync(Ok, IActionResult (m, n) =>
         {
-            _logger.LogError(ex, "{Message}", ex.Message);
-            return StatusCode(StatusCodes.Status500InternalServerError);
-        }
+            _logger.LogNotice(n);
+            return NotFound();
+        });
     }
 }
\ No newline at end of file