Refactor: add StoredProcedureBuilder for SQL calls

Introduce StoredProcedureBuilder to centralize and simplify the construction of SQL stored procedure calls and parameter lists. Refactor DeleteObjectProcedureHandler, InsertObjectProcedureHandler, and UpdateObjectProcedureHandler to use this utility, replacing manual StringBuilder and parameter management. Improves code readability, reduces duplication, and standardizes parameter handling, including output parameters.
Refactor SQL param and command construction in procedures
2026-03-27 15:11:16 +01:00 · 2026-03-27 14:58:56 +01:00 · 2026-03-27 14:54:27 +01:00 · 2026-03-27 14:21:45 +01:00 · 2026-03-27 14:19:19 +01:00 · 2026-03-27 13:30:28 +01:00
4 changed files with 185 additions and 178 deletions
--- a/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
@@ -5,6 +5,7 @@ using Microsoft.Data.SqlClient;
 using Microsoft.Extensions.Options;
 using ReC.Application.Common.Exceptions;
 using ReC.Application.Common.Options;
+using System.Text;

 namespace ReC.Application.Common.Procedures.DeleteProcedure;

@@ -35,25 +36,22 @@ public class DeleteObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
 {
    public async Task<int> Handle(DeleteObjectProcedure request, CancellationToken cancel)
    {
-        var parameters = new[]
-        {
-            new SqlParameter("@pENTITY", request.Entity ?? (object)DBNull.Value),
-            new SqlParameter("@pSTART", request.Start.ToString()),
-            new SqlParameter("@pEND", request.End.ToString()),
-            new SqlParameter("@pFORCE", (object?)request.Force ?? DBNull.Value)
-        };
+        var sp = new StoredProcedureBuilder("EXEC @RC = [dbo].[PRREC_DELETE_OBJECT]")
+            .Add("pENTITY", request.Entity)
+            .Add("pSTART", request.Start.ToString())
+            .Add("pEND", request.End.ToString())
+            .Add("pFORCE", request.Force);
+
+        var sql = new StringBuilder()
+            .AppendLine("DECLARE @RC SMALLINT = 0;")
+            .Append(sp.BuildSql()).AppendLine(";")
+            .AppendLine("SELECT @RC;")
+            .ToString();

        try
        {
-            var result = await repo.ExecuteQueryRawAsync(
-                "DECLARE @RC SMALLINT = 0; " +
-                "EXEC @RC = [dbo].[PRREC_DELETE_OBJECT] " +
-                "@pENTITY, @pSTART, @pEND, @pFORCE; " +
-                "SELECT @RC;",
-                parameters,
-                cancel);
+            var result = await repo.ExecuteQueryRawAsync(sql, sp.BuildParameters(), cancel);

-            // The stored procedure returns 0 on success, error codes > 0 on failure
            if (result > 0)
            {
                throw new DeleteObjectFailedException(request, $"DeleteObject stored procedure failed with error code: {result}");
--- a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
@@ -11,6 +11,7 @@ using ReC.Application.Endpoints.Commands;
 using ReC.Application.Profile.Commands;
 using ReC.Application.RecActions.Commands;
 using ReC.Application.Results.Commands;
+using System.Data;

 namespace ReC.Application.Common.Procedures.InsertProcedure;

@@ -36,88 +37,62 @@ public class InsertObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
 {
    public async Task<long> Handle(InsertObjectProcedure request, CancellationToken cancel)
    {
-        var parameters = new[]
-        {
-            new SqlParameter("@pENTITY", request.Entity ?? (object)DBNull.Value),
-
-            new SqlParameter("@pADDED_WHO", (object?)request.AddedWho ?? DBNull.Value),
-            new SqlParameter("@pADDED_WHEN", (object?)DateTime.UtcNow ?? DBNull.Value),
-
-            new SqlParameter("@pACTION_PROFILE_ID", (object?)request.Action?.ProfileId ?? DBNull.Value),
-            new SqlParameter("@pACTION_ACTIVE", (object?)request.Action?.Active ?? DBNull.Value),
-            new SqlParameter("@pACTION_SEQUENCE", (object?)request.Action?.Sequence ?? DBNull.Value),
-            new SqlParameter("@pACTION_ENDPOINT_ID", (object?)request.Action?.EndpointId ?? DBNull.Value),
-            new SqlParameter("@pACTION_ENDPOINT_AUTH_ID", (object?)request.Action?.EndpointAuthId ?? DBNull.Value),
-            new SqlParameter("@pACTION_ENDPOINT_PARAMS_ID", (object?)request.Action?.EndpointParamsId ?? DBNull.Value),
-            new SqlParameter("@pACTION_SQL_CONNECTION_ID", (object?)request.Action?.SqlConnectionId ?? DBNull.Value),
-            new SqlParameter("@pACTION_TYPE_ID", (object?)(byte?)request.Action?.TypeId ?? DBNull.Value),
-            new SqlParameter("@pACTION_PRE_SQL", (object?)request.Action?.PreSql ?? DBNull.Value),
-            new SqlParameter("@pACTION_HEADER_SQL", (object?)request.Action?.HeaderSql ?? DBNull.Value),
-            new SqlParameter("@pACTION_BODY_SQL", (object?)request.Action?.BodySql ?? DBNull.Value),
-            new SqlParameter("@pACTION_POST_SQL", (object?)request.Action?.PostSql ?? DBNull.Value),
-            new SqlParameter("@pACTION_ERROR_ACTION_ID", (object?)request.Action?.ErrorActionId ?? DBNull.Value),
-
-            new SqlParameter("@pENDPOINT_ACTIVE", (object?)request.Endpoint?.Active ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_DESCRIPTION", (object?)request.Endpoint?.Description ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_URI", (object?)request.Endpoint?.Uri ?? DBNull.Value),
-
-            new SqlParameter("@pENDPOINT_AUTH_ACTIVE", (object?)request.EndpointAuth?.Active ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_DESCRIPTION", (object?)request.EndpointAuth?.Description ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_TYPE_ID", (object?)request.EndpointAuth?.TypeId ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_API_KEY", (object?)request.EndpointAuth?.ApiKey ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_API_VALUE", (object?)request.EndpointAuth?.ApiValue ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_API_KEY_ADD_TO_ID", (object?)request.EndpointAuth?.ApiKeyAddToId ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_TOKEN", (object?)request.EndpointAuth?.Token ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_USERNAME", (object?)request.EndpointAuth?.Username ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_PASSWORD", (object?)request.EndpointAuth?.Password ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_DOMAIN", (object?)request.EndpointAuth?.Domain ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_WORKSTATION", (object?)request.EndpointAuth?.Workstation ?? DBNull.Value),
-
-            new SqlParameter("@pPROFILE_ACTIVE", (object?)request.Profile?.Active ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_TYPE_ID", (object?)request.Profile?.TypeId ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_MANDANTOR", (object?)request.Profile?.Mandantor ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_NAME", (object?)request.Profile?.Name ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_DESCRIPTION", (object?)request.Profile?.Description ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_LOG_LEVEL_ID", (object?)request.Profile?.LogLevelId ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_LANGUAGE_ID", (object?)request.Profile?.LanguageId ?? DBNull.Value),
-
-            new SqlParameter("@pRESULT_ACTION_ID", (object?)request.Result?.ActionId ?? DBNull.Value),
-            new SqlParameter("@pRESULT_STATUS_ID", (object?)request.Result?.StatusId ?? DBNull.Value),
-            new SqlParameter("@pRESULT_HEADER", (object?)request.Result?.Header ?? DBNull.Value),
-            new SqlParameter("@pRESULT_BODY", (object?)request.Result?.Body ?? DBNull.Value),
-            new SqlParameter("@pRESULT_INFO", (object?)request.Result?.Info ?? DBNull.Value),
-            new SqlParameter("@pRESULT_ERROR", (object?)request.Result?.Error ?? DBNull.Value),
-            new SqlParameter("@pRESULT_TYPE_ID", (object?)(byte?)request.Result?.Type ?? DBNull.Value),
-
-            new SqlParameter("@pENDPOINT_PARAMS_ACTIVE", (object?)request.EndpointParams?.Active ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_DESCRIPTION", (object?)request.EndpointParams?.Description ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_GROUP_ID", (object?)request.EndpointParams?.GroupId ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_SEQUENCE", (object?)request.EndpointParams?.Sequence ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_KEY", (object?)request.EndpointParams?.Key ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_VALUE", (object?)request.EndpointParams?.Value ?? DBNull.Value),
-
-            new SqlParameter
-            {
-                ParameterName = "@oGUID",
-                SqlDbType = System.Data.SqlDbType.BigInt,
-                Direction = System.Data.ParameterDirection.Output
-            }
-        };
+        var sp = new StoredProcedureBuilder("EXEC [dbo].[PRREC_INSERT_OBJECT]")
+            .Add("pENTITY", request.Entity)
+            .Add("pADDED_WHO", request.AddedWho)
+            .Add("pADDED_WHEN", DateTime.UtcNow)
+            .Add("pACTION_PROFILE_ID", request.Action?.ProfileId)
+            .Add("pACTION_ACTIVE", request.Action?.Active)
+            .Add("pACTION_SEQUENCE", request.Action?.Sequence, SqlDbType.TinyInt)
+            .Add("pACTION_ENDPOINT_ID", request.Action?.EndpointId)
+            .Add("pACTION_ENDPOINT_AUTH_ID", request.Action?.EndpointAuthId)
+            .Add("pACTION_ENDPOINT_PARAMS_ID", request.Action?.EndpointParamsId, SqlDbType.SmallInt)
+            .Add("pACTION_SQL_CONNECTION_ID", request.Action?.SqlConnectionId, SqlDbType.SmallInt)
+            .Add("pACTION_TYPE_ID", request.Action?.TypeId is not null ? (byte)request.Action.TypeId : null, SqlDbType.TinyInt)
+            .Add("pACTION_PRE_SQL", request.Action?.PreSql)
+            .Add("pACTION_HEADER_SQL", request.Action?.HeaderSql)
+            .Add("pACTION_BODY_SQL", request.Action?.BodySql)
+            .Add("pACTION_POST_SQL", request.Action?.PostSql)
+            .Add("pACTION_ERROR_ACTION_ID", request.Action?.ErrorActionId, SqlDbType.TinyInt)
+            .Add("pENDPOINT_ACTIVE", request.Endpoint?.Active)
+            .Add("pENDPOINT_DESCRIPTION", request.Endpoint?.Description)
+            .Add("pENDPOINT_URI", request.Endpoint?.Uri)
+            .Add("pENDPOINT_AUTH_ACTIVE", request.EndpointAuth?.Active)
+            .Add("pENDPOINT_AUTH_DESCRIPTION", request.EndpointAuth?.Description)
+            .Add("pENDPOINT_AUTH_TYPE_ID", request.EndpointAuth?.TypeId, SqlDbType.TinyInt)
+            .Add("pENDPOINT_AUTH_API_KEY", request.EndpointAuth?.ApiKey)
+            .Add("pENDPOINT_AUTH_API_VALUE", request.EndpointAuth?.ApiValue)
+            .Add("pENDPOINT_AUTH_API_KEY_ADD_TO_ID", request.EndpointAuth?.ApiKeyAddToId)
+            .Add("pENDPOINT_AUTH_TOKEN", request.EndpointAuth?.Token)
+            .Add("pENDPOINT_AUTH_USERNAME", request.EndpointAuth?.Username)
+            .Add("pENDPOINT_AUTH_PASSWORD", request.EndpointAuth?.Password)
+            .Add("pENDPOINT_AUTH_DOMAIN", request.EndpointAuth?.Domain)
+            .Add("pENDPOINT_AUTH_WORKSTATION", request.EndpointAuth?.Workstation)
+            .Add("pPROFILE_ACTIVE", request.Profile?.Active)
+            .Add("pPROFILE_TYPE_ID", request.Profile?.TypeId, SqlDbType.TinyInt)
+            .Add("pPROFILE_MANDANTOR", request.Profile?.Mandantor)
+            .Add("pPROFILE_NAME", request.Profile?.Name)
+            .Add("pPROFILE_DESCRIPTION", request.Profile?.Description)
+            .Add("pPROFILE_LOG_LEVEL_ID", request.Profile?.LogLevelId, SqlDbType.TinyInt)
+            .Add("pPROFILE_LANGUAGE_ID", request.Profile?.LanguageId, SqlDbType.SmallInt)
+            .Add("pRESULT_ACTION_ID", request.Result?.ActionId)
+            .Add("pRESULT_STATUS_ID", request.Result?.StatusId, SqlDbType.SmallInt)
+            .Add("pRESULT_TYPE_ID", request.Result?.Type is not null ? (byte)request.Result.Type : null, SqlDbType.TinyInt)
+            .Add("pRESULT_HEADER", request.Result?.Header)
+            .Add("pRESULT_BODY", request.Result?.Body)
+            .Add("pRESULT_INFO", request.Result?.Info)
+            .Add("pRESULT_ERROR", request.Result?.Error)
+            .Add("pENDPOINT_PARAMS_ACTIVE", request.EndpointParams?.Active)
+            .Add("pENDPOINT_PARAMS_DESCRIPTION", request.EndpointParams?.Description)
+            .Add("pENDPOINT_PARAMS_GROUP_ID", request.EndpointParams?.GroupId, SqlDbType.SmallInt)
+            .Add("pENDPOINT_PARAMS_SEQUENCE", request.EndpointParams?.Sequence, SqlDbType.TinyInt)
+            .Add("pENDPOINT_PARAMS_KEY", request.EndpointParams?.Key)
+            .Add("pENDPOINT_PARAMS_VALUE", request.EndpointParams?.Value)
+            .AddOutput("oGUID", SqlDbType.BigInt);

        try
        {
-            await repo.ExecuteQueryRawAsync(
-                "EXEC [dbo].[PRREC_INSERT_OBJECT] " +
-                "@pENTITY, @pADDED_WHO, @pADDED_WHEN, " +
-                "@pACTION_PROFILE_ID, @pACTION_ACTIVE, @pACTION_SEQUENCE, @pACTION_ENDPOINT_ID, @pACTION_ENDPOINT_AUTH_ID, @pACTION_ENDPOINT_PARAMS_ID, @pACTION_SQL_CONNECTION_ID, @pACTION_TYPE_ID, @pACTION_PRE_SQL, @pACTION_HEADER_SQL, @pACTION_BODY_SQL, @pACTION_POST_SQL, @pACTION_ERROR_ACTION_ID, " +
-                "@pENDPOINT_ACTIVE, @pENDPOINT_DESCRIPTION, @pENDPOINT_URI, " +
-                "@pENDPOINT_AUTH_ACTIVE, @pENDPOINT_AUTH_DESCRIPTION, @pENDPOINT_AUTH_TYPE_ID, @pENDPOINT_AUTH_API_KEY, @pENDPOINT_AUTH_API_VALUE, @pENDPOINT_AUTH_API_KEY_ADD_TO_ID, @pENDPOINT_AUTH_TOKEN, @pENDPOINT_AUTH_USERNAME, @pENDPOINT_AUTH_PASSWORD, @pENDPOINT_AUTH_DOMAIN, @pENDPOINT_AUTH_WORKSTATION, " +
-                "@pPROFILE_ACTIVE, @pPROFILE_TYPE_ID, @pPROFILE_MANDANTOR, @pPROFILE_NAME, @pPROFILE_DESCRIPTION, @pPROFILE_LOG_LEVEL_ID, @pPROFILE_LANGUAGE_ID, " +
-                "@pRESULT_ACTION_ID, @pRESULT_STATUS_ID, @pRESULT_HEADER, @pRESULT_BODY, @pRESULT_INFO, @pRESULT_ERROR, @pRESULT_TYPE_ID, " +
-                "@pENDPOINT_PARAMS_ACTIVE, @pENDPOINT_PARAMS_DESCRIPTION, @pENDPOINT_PARAMS_GROUP_ID, @pENDPOINT_PARAMS_SEQUENCE, @pENDPOINT_PARAMS_KEY, @pENDPOINT_PARAMS_VALUE, " +
-                "@oGUID OUTPUT",
-                parameters,
-                cancel);
+            await repo.ExecuteQueryRawAsync(sp.BuildSql(), sp.BuildParameters(), cancel);
        }
        catch (SqlException ex)
        {
@@ -127,12 +102,12 @@ public class InsertObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
                throw;
        }

-        var guidParam = parameters.Last();
+        var guidParam = sp.GetParameter("oGUID");

-        if (guidParam.Value != DBNull.Value)
-            if (guidParam.Value is long longValue)
+        if (guidParam?.Value != DBNull.Value)
+            if (guidParam!.Value is long longValue)
                return longValue;
-            else if (long.TryParse(guidParam.Value.ToString(), out var guid))
+            else if (long.TryParse(guidParam.Value?.ToString(), out var guid))
                return guid;

        throw new InsertObjectFailedException(request, "InsertObject stored procedure did not return a valid identifier.");
--- a/src/ReC.Application/Common/Procedures/StoredProcedureBuilder.cs
+++ b/src/ReC.Application/Common/Procedures/StoredProcedureBuilder.cs
@@ -0,0 +1,54 @@
+using Microsoft.Data.SqlClient;
+using System.Data;
+using System.Text;
+
+namespace ReC.Application.Common.Procedures;
+
+internal sealed class StoredProcedureBuilder
+{
+    private readonly StringBuilder _sql;
+    private readonly List<SqlParameter> _parameters = [];
+    private char _separator = ' ';
+
+    public StoredProcedureBuilder(string execPrefix)
+    {
+        _sql = new StringBuilder(execPrefix);
+    }
+
+    public StoredProcedureBuilder Add(string name, object? value, SqlDbType? dbType = null)
+    {
+        if (value is null) return this;
+
+        _sql.AppendLine($"{_separator}@{name} = @{name}");
+        _separator = ',';
+
+        if (dbType.HasValue)
+            _parameters.Add(new SqlParameter($"@{name}", dbType.Value) { Value = value });
+        else
+            _parameters.Add(new SqlParameter($"@{name}", value));
+
+        return this;
+    }
+
+    public StoredProcedureBuilder AddOutput(string name, SqlDbType dbType)
+    {
+        _sql.AppendLine($"{_separator}@{name} = @{name} OUTPUT");
+        _separator = ',';
+
+        _parameters.Add(new SqlParameter
+        {
+            ParameterName = $"@{name}",
+            SqlDbType = dbType,
+            Direction = ParameterDirection.Output
+        });
+
+        return this;
+    }
+
+    public string BuildSql() => _sql.ToString();
+
+    public SqlParameter[] BuildParameters() => [.. _parameters];
+
+    public SqlParameter? GetParameter(string name) =>
+        _parameters.Find(p => p.ParameterName == $"@{name}");
+}
--- a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
@@ -6,12 +6,8 @@ using Microsoft.Extensions.Options;
 using ReC.Application.Common.Exceptions;
 using ReC.Application.Common.Options;
 using ReC.Application.Common.Procedures.UpdateProcedure.Dto;
-using ReC.Application.EndpointAuth.Commands;
-using ReC.Application.EndpointParams.Commands;
-using ReC.Application.Endpoints.Commands;
-using ReC.Application.Profile.Commands;
-using ReC.Application.RecActions.Commands;
-using ReC.Application.Results.Commands;
+using System.Data;
+using System.Text;

 namespace ReC.Application.Common.Procedures.UpdateProcedure;

@@ -42,85 +38,69 @@ public class UpdateObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
 {
    public async Task<int> Handle(UpdateObjectProcedure request, CancellationToken cancel)
    {
-        var parameters = new[]
-        {
-            new SqlParameter("@pENTITY", request.Entity ?? (object)DBNull.Value),
-            new SqlParameter("@pGUID", (object?)request.Id ?? DBNull.Value),
+        var sp = new StoredProcedureBuilder("EXEC @RC = [dbo].[PRREC_UPDATE_OBJECT]")
+            .Add("pENTITY", request.Entity)
+            .Add("pGUID", request.Id)
+            .Add("pCHANGED_WHO", request.ChangedWho)
+            .Add("pCHANGED_WHEN", DateTime.UtcNow)
+            .Add("pACTION_PROFILE_ID", request.Action.ProfileId)
+            .Add("pACTION_ACTIVE", request.Action.Active)
+            .Add("pACTION_SEQUENCE", request.Action.Sequence, SqlDbType.TinyInt)
+            .Add("pACTION_ENDPOINT_ID", request.Action.EndpointId)
+            .Add("pACTION_ENDPOINT_AUTH_ID", request.Action.EndpointAuthId)
+            .Add("pACTION_ENDPOINT_PARAMS_ID", request.Action.EndpointParamsId, SqlDbType.SmallInt)
+            .Add("pACTION_SQL_CONNECTION_ID", request.Action.SqlConnectionId, SqlDbType.SmallInt)
+            .Add("pACTION_TYPE_ID", request.Action.TypeId, SqlDbType.TinyInt)
+            .Add("pACTION_PRE_SQL", request.Action.PreSql)
+            .Add("pACTION_HEADER_SQL", request.Action.HeaderSql)
+            .Add("pACTION_BODY_SQL", request.Action.BodySql)
+            .Add("pACTION_POST_SQL", request.Action.PostSql)
+            .Add("pACTION_ERROR_ACTION_ID", request.Action.ErrorActionId, SqlDbType.TinyInt)
+            .Add("pENDPOINT_ACTIVE", request.Endpoint.Active)
+            .Add("pENDPOINT_DESCRIPTION", request.Endpoint.Description)
+            .Add("pENDPOINT_URI", request.Endpoint.Uri)
+            .Add("pENDPOINT_AUTH_ACTIVE", request.EndpointAuth.Active)
+            .Add("pENDPOINT_AUTH_DESCRIPTION", request.EndpointAuth.Description)
+            .Add("pENDPOINT_AUTH_TYPE_ID", request.EndpointAuth.TypeId, SqlDbType.TinyInt)
+            .Add("pENDPOINT_AUTH_API_KEY", request.EndpointAuth.ApiKey)
+            .Add("pENDPOINT_AUTH_API_VALUE", request.EndpointAuth.ApiValue)
+            .Add("pENDPOINT_AUTH_API_KEY_ADD_TO_ID", request.EndpointAuth.ApiKeyAddToId)
+            .Add("pENDPOINT_AUTH_TOKEN", request.EndpointAuth.Token)
+            .Add("pENDPOINT_AUTH_USERNAME", request.EndpointAuth.Username)
+            .Add("pENDPOINT_AUTH_PASSWORD", request.EndpointAuth.Password)
+            .Add("pENDPOINT_AUTH_DOMAIN", request.EndpointAuth.Domain)
+            .Add("pENDPOINT_AUTH_WORKSTATION", request.EndpointAuth.Workstation)
+            .Add("pENDPOINT_PARAMS_ACTIVE", request.EndpointParams.Active)
+            .Add("pENDPOINT_PARAMS_DESCRIPTION", request.EndpointParams.Description)
+            .Add("pENDPOINT_PARAMS_GROUP_ID", request.EndpointParams.GroupId, SqlDbType.SmallInt)
+            .Add("pENDPOINT_PARAMS_SEQUENCE", request.EndpointParams.Sequence, SqlDbType.TinyInt)
+            .Add("pENDPOINT_PARAMS_KEY", request.EndpointParams.Key)
+            .Add("pENDPOINT_PARAMS_VALUE", request.EndpointParams.Value)
+            .Add("pPROFILE_ACTIVE", request.Profile.Active)
+            .Add("pPROFILE_TYPE_ID", request.Profile.TypeId, SqlDbType.TinyInt)
+            .Add("pPROFILE_MANDANTOR", request.Profile.Mandantor)
+            .Add("pPROFILE_NAME", request.Profile.Name)
+            .Add("pPROFILE_DESCRIPTION", request.Profile.Description)
+            .Add("pPROFILE_LOG_LEVEL_ID", request.Profile.LogLevelId, SqlDbType.TinyInt)
+            .Add("pPROFILE_LANGUAGE_ID", request.Profile.LanguageId, SqlDbType.SmallInt)
+            .Add("pPROFILE_FIRST_RUN", request.Profile.FirstRun)
+            .Add("pPROFILE_LAST_RUN", request.Profile.LastRun)
+            .Add("pPROFILE_LAST_RESULT", request.Profile.LastResult)
+            .Add("pRESULT_ACTION_ID", request.Result.ActionId)
+            .Add("pRESULT_STATUS_ID", request.Result.StatusId, SqlDbType.SmallInt)
+            .Add("pRESULT_HEADER", request.Result.Header)
+            .Add("pRESULT_BODY", request.Result.Body);

-            new SqlParameter("@pCHANGED_WHO", (object?)request.ChangedWho ?? DBNull.Value),
-            new SqlParameter("@pCHANGED_WHEN", (object?)DateTime.UtcNow ?? DBNull.Value),
-
-            new SqlParameter("@pACTION_PROFILE_ID", (object?)request.Action.ProfileId ?? DBNull.Value),
-            new SqlParameter("@pACTION_ACTIVE", (object?)request.Action.Active ?? DBNull.Value),
-            new SqlParameter("@pACTION_SEQUENCE", (object?)request.Action.Sequence ?? DBNull.Value),
-            new SqlParameter("@pACTION_ENDPOINT_ID", (object?)request.Action.EndpointId ?? DBNull.Value),
-            new SqlParameter("@pACTION_ENDPOINT_AUTH_ID", (object?)request.Action.EndpointAuthId ?? DBNull.Value),
-            new SqlParameter("@pACTION_ENDPOINT_PARAMS_ID", (object?)request.Action.EndpointParamsId ?? DBNull.Value),
-            new SqlParameter("@pACTION_SQL_CONNECTION_ID", (object?)request.Action.SqlConnectionId ?? DBNull.Value),
-            new SqlParameter("@pACTION_TYPE_ID", (object?)request.Action.TypeId ?? DBNull.Value),
-            new SqlParameter("@pACTION_PRE_SQL", (object?)request.Action.PreSql ?? DBNull.Value),
-            new SqlParameter("@pACTION_HEADER_SQL", (object?)request.Action.HeaderSql ?? DBNull.Value),
-            new SqlParameter("@pACTION_BODY_SQL", (object?)request.Action.BodySql ?? DBNull.Value),
-            new SqlParameter("@pACTION_POST_SQL", (object?)request.Action.PostSql ?? DBNull.Value),
-            new SqlParameter("@pACTION_ERROR_ACTION_ID", (object?)request.Action.ErrorActionId ?? DBNull.Value),
-
-            new SqlParameter("@pENDPOINT_ACTIVE", (object?)request.Endpoint.Active ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_DESCRIPTION", (object?)request.Endpoint.Description ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_URI", (object?)request.Endpoint.Uri ?? DBNull.Value),
-
-            new SqlParameter("@pENDPOINT_AUTH_ACTIVE", (object?)request.EndpointAuth.Active ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_DESCRIPTION", (object?)request.EndpointAuth.Description ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_TYPE_ID", (object?)request.EndpointAuth.TypeId ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_API_KEY", (object?)request.EndpointAuth.ApiKey ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_API_VALUE", (object?)request.EndpointAuth.ApiValue ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_API_KEY_ADD_TO_ID", (object?)request.EndpointAuth.ApiKeyAddToId ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_TOKEN", (object?)request.EndpointAuth.Token ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_USERNAME", (object?)request.EndpointAuth.Username ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_PASSWORD", (object?)request.EndpointAuth.Password ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_DOMAIN", (object?)request.EndpointAuth.Domain ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_AUTH_WORKSTATION", (object?)request.EndpointAuth.Workstation ?? DBNull.Value),
-
-            new SqlParameter("@pENDPOINT_PARAMS_ACTIVE", (object?)request.EndpointParams.Active ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_DESCRIPTION", (object?)request.EndpointParams.Description ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_GROUP_ID", (object?)request.EndpointParams.GroupId ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_SEQUENCE", (object?)request.EndpointParams.Sequence ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_KEY", (object?)request.EndpointParams.Key ?? DBNull.Value),
-            new SqlParameter("@pENDPOINT_PARAMS_VALUE", (object?)request.EndpointParams.Value ?? DBNull.Value),
-
-            new SqlParameter("@pPROFILE_ACTIVE", (object?)request.Profile.Active ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_TYPE_ID", (object?)request.Profile.TypeId ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_MANDANTOR", (object?)request.Profile.Mandantor ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_NAME", (object?)request.Profile.Name ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_DESCRIPTION", (object?)request.Profile.Description ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_LOG_LEVEL_ID", (object?)request.Profile.LogLevelId ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_LANGUAGE_ID", (object?)request.Profile.LanguageId ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_FIRST_RUN", (object?)request.Profile.FirstRun ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_LAST_RUN", (object?)request.Profile.LastRun ?? DBNull.Value),
-            new SqlParameter("@pPROFILE_LAST_RESULT", (object?)request.Profile.LastResult ?? DBNull.Value),
-
-            new SqlParameter("@pRESULT_ACTION_ID", (object?)request.Result.ActionId ?? DBNull.Value),
-            new SqlParameter("@pRESULT_STATUS_ID", (object?)request.Result.StatusId ?? DBNull.Value),
-            new SqlParameter("@pRESULT_HEADER", (object?)request.Result.Header ?? DBNull.Value),
-            new SqlParameter("@pRESULT_BODY", (object?)request.Result.Body ?? DBNull.Value)
-        };
+        var sql = new StringBuilder()
+            .AppendLine("DECLARE @RC SMALLINT = 0;")
+            .Append(sp.BuildSql()).AppendLine(";")
+            .AppendLine("SELECT @RC;")
+            .ToString();

        try
        {
-            var result = await repo.ExecuteQueryRawAsync(
-                "DECLARE @RC SMALLINT = 0; " +
-                "EXEC @RC = [dbo].[PRREC_UPDATE_OBJECT] " +
-                "@pENTITY, @pGUID, @pCHANGED_WHO, @pCHANGED_WHEN, " +
-                "@pACTION_PROFILE_ID, @pACTION_ACTIVE, @pACTION_SEQUENCE, @pACTION_ENDPOINT_ID, @pACTION_ENDPOINT_AUTH_ID, @pACTION_ENDPOINT_PARAMS_ID, @pACTION_SQL_CONNECTION_ID, @pACTION_TYPE_ID, @pACTION_PRE_SQL, @pACTION_HEADER_SQL, @pACTION_BODY_SQL, @pACTION_POST_SQL, @pACTION_ERROR_ACTION_ID, " +
-                "@pENDPOINT_ACTIVE, @pENDPOINT_DESCRIPTION, @pENDPOINT_URI, " +
-                "@pENDPOINT_AUTH_ACTIVE, @pENDPOINT_AUTH_DESCRIPTION, @pENDPOINT_AUTH_TYPE_ID, @pENDPOINT_AUTH_API_KEY, @pENDPOINT_AUTH_API_VALUE, @pENDPOINT_AUTH_API_KEY_ADD_TO_ID, @pENDPOINT_AUTH_TOKEN, @pENDPOINT_AUTH_USERNAME, @pENDPOINT_AUTH_PASSWORD, @pENDPOINT_AUTH_DOMAIN, @pENDPOINT_AUTH_WORKSTATION, " +
-                "@pENDPOINT_PARAMS_ACTIVE, @pENDPOINT_PARAMS_DESCRIPTION, @pENDPOINT_PARAMS_GROUP_ID, @pENDPOINT_PARAMS_SEQUENCE, @pENDPOINT_PARAMS_KEY, @pENDPOINT_PARAMS_VALUE, " +
-                "@pPROFILE_ACTIVE, @pPROFILE_TYPE_ID, @pPROFILE_MANDANTOR, @pPROFILE_NAME, @pPROFILE_DESCRIPTION, @pPROFILE_LOG_LEVEL_ID, @pPROFILE_LANGUAGE_ID, @pPROFILE_FIRST_RUN, @pPROFILE_LAST_RUN, @pPROFILE_LAST_RESULT, " +
-                "@pRESULT_ACTION_ID, @pRESULT_STATUS_ID, @pRESULT_HEADER, @pRESULT_BODY; " +
-                "SELECT @RC;",
-                parameters,
-                cancel);
+            var result = await repo.ExecuteQueryRawAsync(sql, sp.BuildParameters(), cancel);

-            // The stored procedure returns 0 on success, error codes > 0 on failure
            if (result > 0)
            {
                throw new UpdateObjectFailedException(request, $"UpdateObject stored procedure failed with error code: {result}");
Author	SHA1	Message	Date
TekH	b66a49f74d	Refactor: add StoredProcedureBuilder for SQL calls Introduce StoredProcedureBuilder to centralize and simplify the construction of SQL stored procedure calls and parameter lists. Refactor DeleteObjectProcedureHandler, InsertObjectProcedureHandler, and UpdateObjectProcedureHandler to use this utility, replacing manual StringBuilder and parameter management. Improves code readability, reduces duplication, and standardizes parameter handling, including output parameters.	2026-03-27 15:11:16 +01:00
TekH	70dc52139d	Refactor SQL param and command construction in procedures Refactored InsertObject, UpdateObject, and DeleteObject procedure handlers to dynamically build SQL command strings and parameter lists. Introduced local Add functions to include only non-null parameters, improving code clarity and reducing unnecessary SQL parameter passing. The logic for handling stored procedure results and exceptions remains unchanged.	2026-03-27 14:58:56 +01:00
TekH	210ed9be8d	Refactor SQL construction with StringBuilder for clarity Refactored DeleteObjectProcedureHandler, InsertObjectProcedureHandler, and UpdateObjectProcedureHandler to use StringBuilder for building SQL command strings. This improves readability and maintainability without changing the logic or parameters. Added System.Text using directives as needed.	2026-03-27 14:54:27 +01:00
TekH	b2544b64e3	Refactor: use named params in SP calls, cleanup usings Updated Delete, Insert, and Update object procedure handlers to use named parameters in SQL stored procedure calls instead of positional parameters, improving clarity and reducing risk of misalignment. Also removed unused using statements from UpdateObjectProcedure.cs.	2026-03-27 14:21:45 +01:00
TekH	0b1e0d25ca	Explicitly set SqlDbType.TinyInt for relevant SQL parameters Updated InsertObjectProcedureHandler and UpdateObjectProcedureHandler to explicitly specify SqlDbType.TinyInt for parameters representing TINYINT columns. Also improved handling of nullable and enum values for these parameters to ensure correct type casting and null handling. This enhances type safety and prevents potential SQL type conversion issues.	2026-03-27 14:19:19 +01:00
TekH	c1027abfc6	Specify SqlDbType.SmallInt for relevant SqlParameters Explicitly set SqlDbType.SmallInt for parameters related to small integer fields in UpdateObjectProcedureHandler. This improves type safety and prevents potential data conversion issues by ensuring correct parameter types are sent to SQL Server.	2026-03-27 13:30:28 +01:00
TekH	40c8fa359c	Specify SqlDbType.SmallInt for relevant SqlParameters Explicitly set SqlDbType.SmallInt for parameters related to endpoint params, SQL connection, profile language, and endpoint params group. This ensures correct type handling and prevents potential data conversion issues with the database.	2026-03-27 13:29:43 +01:00
TekH	1375f5f0e4	Set @pRESULT_STATUS_ID param type to SmallInt explicitly Explicitly specify SqlDbType.SmallInt for the @pRESULT_STATUS_ID parameter when calling the stored procedure. This change ensures correct type handling and helps prevent potential SQL type mismatches or conversion errors.	2026-03-27 13:13:36 +01:00