From e152e9a37aefaa47ce1e35ed4fc7279a96073080 Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Tue, 24 Mar 2026 09:48:37 +0100
Subject: [PATCH] Refactor ChangedWho handling in UpdateObjectProcedure

ChangedWho is now initialized directly and no longer settable via a public method. Removed the ChangedBy method and related extension methods. Added a TODO to move ChangedWho assignment to authentication middleware in the future.
---
 .../UpdateProcedure/UpdateObjectProcedure.cs    | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
index 73a3ca8..793d247 100644
--- a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
@@ -26,13 +26,8 @@ public record UpdateObjectProcedure : IRequest<int>
     /// </summary>
     public long Id { get; set; }
 
-    internal string? ChangedWho { get; private set; }
-
-    public UpdateObjectProcedure ChangedBy(string? changedWho = null)
-    {
-        ChangedWho = changedWho ?? "ReC.API";
-        return this;
-    }
+    //TODO: update to set in authentication middleware or similar, and remove from procedure properties
+    internal string? ChangedWho { get; private set; } = "ReC.API";
 
     public UpdateActionProcedure Action { get; set; } = new();
     public UpdateEndpointProcedure Endpoint { get; set; } = new();
@@ -42,14 +37,6 @@ public record UpdateObjectProcedure : IRequest<int>
     public UpdateEndpointParamsProcedure EndpointParams { get; set; } = new();
 }
 
-public static class UpdateObjectProcedureExtensions
-{
-    public static Task<int> ExecuteUpdateProcedure(this ISender sender, IUpdateProcedure procedure, long id, string? changedWho = null, CancellationToken cancel = default)
-    {
-        return sender.Send(procedure.ToObjectProcedure(id, changedWho ?? "ReC.API"), cancel);
-    }
-}
-
 public class UpdateObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlExceptionOptions> sqlExOpt) : IRequestHandler<UpdateObjectProcedure, int>
 {
     public async Task<int> Handle(UpdateObjectProcedure request, CancellationToken cancel)