From de17d398ff6a61d071612bb8fc8f446442f04989 Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Mon, 1 Dec 2025 12:30:57 +0100
Subject: [PATCH] Rename ActionId to Id across the codebase

Updated the `ActionId` property to `Id` in `RecActionDto`
and `RecAction` classes for consistency. Reflected this
change in all relevant files, including log messages,
property assignments, and database column mappings.
Standardized naming conventions to improve code clarity
and maintainability.
---
 src/ReC.Application/Common/Behaviors/HeaderQueryBehavior.cs | 6 +++---
 src/ReC.Application/Common/Dto/RecActionDto.cs              | 2 +-
 .../RecActions/Commands/InvokeBatchRecActionsCommand.cs     | 4 ++--
 .../RecActions/Commands/InvokeRecActionCommand.cs           | 6 +++---
 src/ReC.Domain/Entities/RecAction.cs                        | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/ReC.Application/Common/Behaviors/HeaderQueryBehavior.cs b/src/ReC.Application/Common/Behaviors/HeaderQueryBehavior.cs
index 966c620..2f901a9 100644
--- a/src/ReC.Application/Common/Behaviors/HeaderQueryBehavior.cs
+++ b/src/ReC.Application/Common/Behaviors/HeaderQueryBehavior.cs
@@ -19,7 +19,7 @@ public class HeaderQueryBehavior<TRecAction>(IRecDbContext dbContext, ILogger<He
 
         if (result?.RawHeader is null)
         {
-            logger?.LogWarning("Header query did not return a result or returned a null REQUEST_HEADER. Profile ID: {ProfileId}, Action ID: {ActionId}", action.ProfileId, action.ActionId);
+            logger?.LogWarning("Header query did not return a result or returned a null REQUEST_HEADER. Profile ID: {ProfileId}, Action ID: {Id}", action.ProfileId, action.Id);
 
             return await next(cancel);
         }
@@ -29,8 +29,8 @@ public class HeaderQueryBehavior<TRecAction>(IRecDbContext dbContext, ILogger<He
         if(headerDict is null)
         {
             logger?.LogWarning(
-                "Header JSON deserialization returned null. RawHeader: {RawHeader}, ProfileId: {ProfileId}, ActionId: {ActionId}",
-                result.RawHeader, action.ProfileId, action.ActionId);
+                "Header JSON deserialization returned null. RawHeader: {RawHeader}, ProfileId: {ProfileId}, Id: {Id}",
+                result.RawHeader, action.ProfileId, action.Id);
 
             return await next(cancel);
         }
diff --git a/src/ReC.Application/Common/Dto/RecActionDto.cs b/src/ReC.Application/Common/Dto/RecActionDto.cs
index 0cb5e74..7674873 100644
--- a/src/ReC.Application/Common/Dto/RecActionDto.cs
+++ b/src/ReC.Application/Common/Dto/RecActionDto.cs
@@ -2,7 +2,7 @@
 
 public record RecActionDto
 {
-    public required long ActionId { get; init; }
+    public required long Id { get; init; }
 
     public long? ProfileId { get; init; }
 
diff --git a/src/ReC.Application/RecActions/Commands/InvokeBatchRecActionsCommand.cs b/src/ReC.Application/RecActions/Commands/InvokeBatchRecActionsCommand.cs
index b9c4d3e..dd52538 100644
--- a/src/ReC.Application/RecActions/Commands/InvokeBatchRecActionsCommand.cs
+++ b/src/ReC.Application/RecActions/Commands/InvokeBatchRecActionsCommand.cs
@@ -33,9 +33,9 @@ public class InvokeRecActionsCommandHandler(ISender sender, IHttpClientFactory c
             {
                 logger?.LogError(
                     ex,
-                    "Error invoking Rec action. ProfileId: {ProfileId}, ActionId: {ActionId}",
+                    "Error invoking Rec action. ProfileId: {ProfileId}, Id: {Id}",
                     action.ProfileId,
-                    action.ActionId
+                    action.Id
                 );
             }
             finally
diff --git a/src/ReC.Application/RecActions/Commands/InvokeRecActionCommand.cs b/src/ReC.Application/RecActions/Commands/InvokeRecActionCommand.cs
index 5cfa8e5..944c9a2 100644
--- a/src/ReC.Application/RecActions/Commands/InvokeRecActionCommand.cs
+++ b/src/ReC.Application/RecActions/Commands/InvokeRecActionCommand.cs
@@ -33,9 +33,9 @@ public class InvokeRecActionCommandHandler(
         if (action.RestType is null)
         {
             logger?.LogWarning(
-               "Rec action could not be invoked because the RestType value is null. ProfileId: {ProfileId}, ActionId: {ActionId}",
+               "Rec action could not be invoked because the RestType value is null. ProfileId: {ProfileId}, Id: {Id}",
                action.ProfileId,
-               action.ActionId
+               action.Id
            );
             return;
         }
@@ -60,7 +60,7 @@ public class InvokeRecActionCommandHandler(
 
         await sender.Send(new CreateOutResCommand
         {
-            ActionId = action.ActionId,
+            ActionId = action.Id,
             Header = JsonSerializer.Serialize(resHeaders, options: new() { WriteIndented = false }),
             Body = resBody,
             AddedWho = config?["AddedWho"]
diff --git a/src/ReC.Domain/Entities/RecAction.cs b/src/ReC.Domain/Entities/RecAction.cs
index c0df82d..e2cba2c 100644
--- a/src/ReC.Domain/Entities/RecAction.cs
+++ b/src/ReC.Domain/Entities/RecAction.cs
@@ -15,7 +15,7 @@ namespace ReC.Domain.Entities;
 public class RecAction
 {
     [Column("ACTION_ID")]
-    public required long ActionId { get; set; }
+    public required long Id { get; set; }
 
     [Column("PROFILE_ID")]
     public long? ProfileId { get; set; }