From c7423fb6fd1c9fc0aaa643796d758c1a0e1d0b0b Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Wed, 14 Jan 2026 15:25:40 +0100
Subject: [PATCH] Refactor RecAction creation and remove fake endpoint

Refactored the CreateAction endpoint to use InsertActionProcedure and mediator.ExecuteInsertProcedure, replacing the obsolete CreateRecActionCommand. Removed the deprecated CreateFakeAction endpoint and all related code from RecActionController.
---
 .../Controllers/RecActionController.cs        | 49 ++-----------------
 1 file changed, 4 insertions(+), 45 deletions(-)

diff --git a/src/ReC.API/Controllers/RecActionController.cs b/src/ReC.API/Controllers/RecActionController.cs
index bdf2107..9bfebdf 100644
--- a/src/ReC.API/Controllers/RecActionController.cs
+++ b/src/ReC.API/Controllers/RecActionController.cs
@@ -1,10 +1,9 @@
 using MediatR;
 using Microsoft.AspNetCore.Mvc;
 using ReC.API.Extensions;
-using ReC.API.Models;
+using ReC.Application.Common.Procedures.InsertProcedure;
 using ReC.Application.RecActions.Commands;
 using ReC.Application.RecActions.Queries;
-using System.Text.Json;
 
 namespace ReC.API.Controllers;
 
@@ -72,51 +71,11 @@ public class RecActionController(IMediator mediator, IConfiguration config) : Co
     /// <returns>An HTTP 201 Created response.</returns>
     [HttpPost]
     [ProducesResponseType(StatusCodes.Status201Created)]
-    [Obsolete("Use the related procedure.")]
-    public async Task<IActionResult> CreateAction([FromBody] CreateRecActionCommand command, CancellationToken cancel)
+    public async Task<IActionResult> CreateAction([FromBody] InsertActionProcedure command, CancellationToken cancel)
     {
-        await mediator.Send(command, cancel);
-
-        return CreatedAtAction(nameof(CreateAction), null);
-    }
-
-    /// <summary>
-    /// Creates a new fake RecAction for testing purposes.
-    /// </summary>
-    /// <param name="cancel">A token to cancel the operation.</param>
-    /// <param name="request">The optional request body and header for the fake action.</param>
-    /// <param name="endpointUri">The target endpoint URI.</param>
-    /// <param name="endpointPath">The optional path to append to the endpoint URI.</param>
-    /// <param name="type">The HTTP method type (e.g., GET, POST).</param>
-    /// <returns>An HTTP 201 Created response.</returns>
-    [HttpPost("fake")]
-    [ProducesResponseType(StatusCodes.Status201Created)]
-    [Obsolete("Use the related procedure.")]
-    public async Task<IActionResult> CreateFakeAction(
-        CancellationToken cancel,
-        [FromBody] FakeRequest? request = null,
-        [FromQuery] string endpointUri = "https://jsonplaceholder.typicode.com/posts",
-        [FromQuery] string? endpointPath = "1",
-        [FromQuery] string type = "GET")
-    {
-        if (endpointPath is not null)
-            endpointUri = new Uri(new Uri(endpointUri.TrimEnd('/') + "/"), endpointPath.TrimStart('/')).ToString();
-
-        var bodyJson = request?.Body is not null ? JsonSerializer.Serialize(request.Body, options: new() { WriteIndented = false }) : null;
-        var headerJson = request?.Header is not null ? JsonSerializer.Serialize(request.Header, options: new() { WriteIndented = false }) : null;
-
-        await mediator.Send(new CreateRecActionCommand()
-        {
-            ProfileId = config.GetFakeProfileId(),
-            EndpointUri = endpointUri,
-            Type = type,
-            BodyQuery = $@"SELECT '{bodyJson ?? "NULL"}' AS REQUEST_BODY;",
-            HeaderQuery = headerJson is not null ? $@"SELECT '{headerJson}' AS REQUEST_HEADER;" : null,
-            Active = true,
-            EndpointAuthId = 4
-        }, cancel);
+        await mediator.ExecuteInsertProcedure(command, config["AddedWho"], cancel);
 
-        return CreatedAtAction(nameof(CreateFakeAction), null);
+        return StatusCode(StatusCodes.Status201Created);
     }
 
     /// <summary>