Refactor: add StoredProcedureBuilder for SQL calls

Introduce StoredProcedureBuilder to centralize and simplify the construction of SQL stored procedure calls and parameter lists. Refactor DeleteObjectProcedureHandler, InsertObjectProcedureHandler, and UpdateObjectProcedureHandler to use this utility, replacing manual StringBuilder and parameter management. Improves code readability, reduces duplication, and standardizes parameter handling, including output parameters.
This commit is contained in:
2026-03-27 15:11:16 +01:00
parent 70dc52139d
commit b66a49f74d
4 changed files with 174 additions and 178 deletions

View File

@@ -36,32 +36,21 @@ public class DeleteObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
{
public async Task<int> Handle(DeleteObjectProcedure request, CancellationToken cancel)
{
var execSql = new StringBuilder("EXEC @RC = [dbo].[PRREC_DELETE_OBJECT]");
var parameters = new List<SqlParameter>();
var separator = ' ';
void Add(string name, object? value)
{
if (value is null) return;
execSql.AppendLine($"{separator}@{name} = @{name}");
separator = ',';
parameters.Add(new SqlParameter($"@{name}", value));
}
Add("pENTITY", request.Entity);
Add("pSTART", request.Start.ToString());
Add("pEND", request.End.ToString());
Add("pFORCE", request.Force);
var sp = new StoredProcedureBuilder("EXEC @RC = [dbo].[PRREC_DELETE_OBJECT]")
.Add("pENTITY", request.Entity)
.Add("pSTART", request.Start.ToString())
.Add("pEND", request.End.ToString())
.Add("pFORCE", request.Force);
var sql = new StringBuilder()
.AppendLine("DECLARE @RC SMALLINT = 0;")
.Append(execSql).AppendLine(";")
.Append(sp.BuildSql()).AppendLine(";")
.AppendLine("SELECT @RC;")
.ToString();
try
{
var result = await repo.ExecuteQueryRawAsync(sql, parameters.ToArray(), cancel);
var result = await repo.ExecuteQueryRawAsync(sql, sp.BuildParameters(), cancel);
if (result > 0)
{