From b2544b64e3bcaa567e84c04331d4fb992dd3093f Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Fri, 27 Mar 2026 14:21:45 +0100
Subject: [PATCH] Refactor: use named params in SP calls, cleanup usings

Updated Delete, Insert, and Update object procedure handlers to use named parameters in SQL stored procedure calls instead of positional parameters, improving clarity and reducing risk of misalignment. Also removed unused using statements from UpdateObjectProcedure.cs.
---
 .../DeleteProcedure/DeleteObjectProcedure.cs  |  2 +-
 .../InsertProcedure/InsertObjectProcedure.cs  | 16 +++++++--------
 .../UpdateProcedure/UpdateObjectProcedure.cs  | 20 +++++++------------
 3 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs b/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
index 1b4f79f..dbca3b6 100644
--- a/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
@@ -48,7 +48,7 @@ public class DeleteObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
             var result = await repo.ExecuteQueryRawAsync(
                 "DECLARE @RC SMALLINT = 0; " +
                 "EXEC @RC = [dbo].[PRREC_DELETE_OBJECT] " +
-                "@pENTITY, @pSTART, @pEND, @pFORCE; " +
+                "@pENTITY = @pENTITY, @pSTART = @pSTART, @pEND = @pEND, @pFORCE = @pFORCE; " +
                 "SELECT @RC;",
                 parameters,
                 cancel);
diff --git a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
index 81e4d00..ac8ab7c 100644
--- a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
@@ -108,14 +108,14 @@ public class InsertObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
         {
             await repo.ExecuteQueryRawAsync(
                 "EXEC [dbo].[PRREC_INSERT_OBJECT] " +
-                "@pENTITY, @pADDED_WHO, @pADDED_WHEN, " +
-                "@pACTION_PROFILE_ID, @pACTION_ACTIVE, @pACTION_SEQUENCE, @pACTION_ENDPOINT_ID, @pACTION_ENDPOINT_AUTH_ID, @pACTION_ENDPOINT_PARAMS_ID, @pACTION_SQL_CONNECTION_ID, @pACTION_TYPE_ID, @pACTION_PRE_SQL, @pACTION_HEADER_SQL, @pACTION_BODY_SQL, @pACTION_POST_SQL, @pACTION_ERROR_ACTION_ID, " +
-                "@pENDPOINT_ACTIVE, @pENDPOINT_DESCRIPTION, @pENDPOINT_URI, " +
-                "@pENDPOINT_AUTH_ACTIVE, @pENDPOINT_AUTH_DESCRIPTION, @pENDPOINT_AUTH_TYPE_ID, @pENDPOINT_AUTH_API_KEY, @pENDPOINT_AUTH_API_VALUE, @pENDPOINT_AUTH_API_KEY_ADD_TO_ID, @pENDPOINT_AUTH_TOKEN, @pENDPOINT_AUTH_USERNAME, @pENDPOINT_AUTH_PASSWORD, @pENDPOINT_AUTH_DOMAIN, @pENDPOINT_AUTH_WORKSTATION, " +
-                "@pPROFILE_ACTIVE, @pPROFILE_TYPE_ID, @pPROFILE_MANDANTOR, @pPROFILE_NAME, @pPROFILE_DESCRIPTION, @pPROFILE_LOG_LEVEL_ID, @pPROFILE_LANGUAGE_ID, " +
-                "@pRESULT_ACTION_ID, @pRESULT_STATUS_ID, @pRESULT_HEADER, @pRESULT_BODY, @pRESULT_INFO, @pRESULT_ERROR, @pRESULT_TYPE_ID, " +
-                "@pENDPOINT_PARAMS_ACTIVE, @pENDPOINT_PARAMS_DESCRIPTION, @pENDPOINT_PARAMS_GROUP_ID, @pENDPOINT_PARAMS_SEQUENCE, @pENDPOINT_PARAMS_KEY, @pENDPOINT_PARAMS_VALUE, " +
-                "@oGUID OUTPUT",
+                "@pENTITY = @pENTITY, @pADDED_WHO = @pADDED_WHO, @pADDED_WHEN = @pADDED_WHEN, " +
+                "@pACTION_PROFILE_ID = @pACTION_PROFILE_ID, @pACTION_ACTIVE = @pACTION_ACTIVE, @pACTION_SEQUENCE = @pACTION_SEQUENCE, @pACTION_ENDPOINT_ID = @pACTION_ENDPOINT_ID, @pACTION_ENDPOINT_AUTH_ID = @pACTION_ENDPOINT_AUTH_ID, @pACTION_ENDPOINT_PARAMS_ID = @pACTION_ENDPOINT_PARAMS_ID, @pACTION_SQL_CONNECTION_ID = @pACTION_SQL_CONNECTION_ID, @pACTION_TYPE_ID = @pACTION_TYPE_ID, @pACTION_PRE_SQL = @pACTION_PRE_SQL, @pACTION_HEADER_SQL = @pACTION_HEADER_SQL, @pACTION_BODY_SQL = @pACTION_BODY_SQL, @pACTION_POST_SQL = @pACTION_POST_SQL, @pACTION_ERROR_ACTION_ID = @pACTION_ERROR_ACTION_ID, " +
+                "@pENDPOINT_ACTIVE = @pENDPOINT_ACTIVE, @pENDPOINT_DESCRIPTION = @pENDPOINT_DESCRIPTION, @pENDPOINT_URI = @pENDPOINT_URI, " +
+                "@pENDPOINT_AUTH_ACTIVE = @pENDPOINT_AUTH_ACTIVE, @pENDPOINT_AUTH_DESCRIPTION = @pENDPOINT_AUTH_DESCRIPTION, @pENDPOINT_AUTH_TYPE_ID = @pENDPOINT_AUTH_TYPE_ID, @pENDPOINT_AUTH_API_KEY = @pENDPOINT_AUTH_API_KEY, @pENDPOINT_AUTH_API_VALUE = @pENDPOINT_AUTH_API_VALUE, @pENDPOINT_AUTH_API_KEY_ADD_TO_ID = @pENDPOINT_AUTH_API_KEY_ADD_TO_ID, @pENDPOINT_AUTH_TOKEN = @pENDPOINT_AUTH_TOKEN, @pENDPOINT_AUTH_USERNAME = @pENDPOINT_AUTH_USERNAME, @pENDPOINT_AUTH_PASSWORD = @pENDPOINT_AUTH_PASSWORD, @pENDPOINT_AUTH_DOMAIN = @pENDPOINT_AUTH_DOMAIN, @pENDPOINT_AUTH_WORKSTATION = @pENDPOINT_AUTH_WORKSTATION, " +
+                "@pPROFILE_ACTIVE = @pPROFILE_ACTIVE, @pPROFILE_TYPE_ID = @pPROFILE_TYPE_ID, @pPROFILE_MANDANTOR = @pPROFILE_MANDANTOR, @pPROFILE_NAME = @pPROFILE_NAME, @pPROFILE_DESCRIPTION = @pPROFILE_DESCRIPTION, @pPROFILE_LOG_LEVEL_ID = @pPROFILE_LOG_LEVEL_ID, @pPROFILE_LANGUAGE_ID = @pPROFILE_LANGUAGE_ID, " +
+                "@pRESULT_ACTION_ID = @pRESULT_ACTION_ID, @pRESULT_STATUS_ID = @pRESULT_STATUS_ID, @pRESULT_HEADER = @pRESULT_HEADER, @pRESULT_BODY = @pRESULT_BODY, @pRESULT_INFO = @pRESULT_INFO, @pRESULT_ERROR = @pRESULT_ERROR, @pRESULT_TYPE_ID = @pRESULT_TYPE_ID, " +
+                "@pENDPOINT_PARAMS_ACTIVE = @pENDPOINT_PARAMS_ACTIVE, @pENDPOINT_PARAMS_DESCRIPTION = @pENDPOINT_PARAMS_DESCRIPTION, @pENDPOINT_PARAMS_GROUP_ID = @pENDPOINT_PARAMS_GROUP_ID, @pENDPOINT_PARAMS_SEQUENCE = @pENDPOINT_PARAMS_SEQUENCE, @pENDPOINT_PARAMS_KEY = @pENDPOINT_PARAMS_KEY, @pENDPOINT_PARAMS_VALUE = @pENDPOINT_PARAMS_VALUE, " +
+                "@oGUID = @oGUID OUTPUT",
                 parameters,
                 cancel);
         }
diff --git a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
index 61687d4..974b0d1 100644
--- a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
@@ -6,12 +6,6 @@ using Microsoft.Extensions.Options;
 using ReC.Application.Common.Exceptions;
 using ReC.Application.Common.Options;
 using ReC.Application.Common.Procedures.UpdateProcedure.Dto;
-using ReC.Application.EndpointAuth.Commands;
-using ReC.Application.EndpointParams.Commands;
-using ReC.Application.Endpoints.Commands;
-using ReC.Application.Profile.Commands;
-using ReC.Application.RecActions.Commands;
-using ReC.Application.Results.Commands;
 
 namespace ReC.Application.Common.Procedures.UpdateProcedure;
 
@@ -109,13 +103,13 @@ public class UpdateObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
             var result = await repo.ExecuteQueryRawAsync(
                 "DECLARE @RC SMALLINT = 0; " +
                 "EXEC @RC = [dbo].[PRREC_UPDATE_OBJECT] " +
-                "@pENTITY, @pGUID, @pCHANGED_WHO, @pCHANGED_WHEN, " +
-                "@pACTION_PROFILE_ID, @pACTION_ACTIVE, @pACTION_SEQUENCE, @pACTION_ENDPOINT_ID, @pACTION_ENDPOINT_AUTH_ID, @pACTION_ENDPOINT_PARAMS_ID, @pACTION_SQL_CONNECTION_ID, @pACTION_TYPE_ID, @pACTION_PRE_SQL, @pACTION_HEADER_SQL, @pACTION_BODY_SQL, @pACTION_POST_SQL, @pACTION_ERROR_ACTION_ID, " +
-                "@pENDPOINT_ACTIVE, @pENDPOINT_DESCRIPTION, @pENDPOINT_URI, " +
-                "@pENDPOINT_AUTH_ACTIVE, @pENDPOINT_AUTH_DESCRIPTION, @pENDPOINT_AUTH_TYPE_ID, @pENDPOINT_AUTH_API_KEY, @pENDPOINT_AUTH_API_VALUE, @pENDPOINT_AUTH_API_KEY_ADD_TO_ID, @pENDPOINT_AUTH_TOKEN, @pENDPOINT_AUTH_USERNAME, @pENDPOINT_AUTH_PASSWORD, @pENDPOINT_AUTH_DOMAIN, @pENDPOINT_AUTH_WORKSTATION, " +
-                "@pENDPOINT_PARAMS_ACTIVE, @pENDPOINT_PARAMS_DESCRIPTION, @pENDPOINT_PARAMS_GROUP_ID, @pENDPOINT_PARAMS_SEQUENCE, @pENDPOINT_PARAMS_KEY, @pENDPOINT_PARAMS_VALUE, " +
-                "@pPROFILE_ACTIVE, @pPROFILE_TYPE_ID, @pPROFILE_MANDANTOR, @pPROFILE_NAME, @pPROFILE_DESCRIPTION, @pPROFILE_LOG_LEVEL_ID, @pPROFILE_LANGUAGE_ID, @pPROFILE_FIRST_RUN, @pPROFILE_LAST_RUN, @pPROFILE_LAST_RESULT, " +
-                "@pRESULT_ACTION_ID, @pRESULT_STATUS_ID, @pRESULT_HEADER, @pRESULT_BODY; " +
+                "@pENTITY = @pENTITY, @pGUID = @pGUID, @pCHANGED_WHO = @pCHANGED_WHO, @pCHANGED_WHEN = @pCHANGED_WHEN, " +
+                "@pACTION_PROFILE_ID = @pACTION_PROFILE_ID, @pACTION_ACTIVE = @pACTION_ACTIVE, @pACTION_SEQUENCE = @pACTION_SEQUENCE, @pACTION_ENDPOINT_ID = @pACTION_ENDPOINT_ID, @pACTION_ENDPOINT_AUTH_ID = @pACTION_ENDPOINT_AUTH_ID, @pACTION_ENDPOINT_PARAMS_ID = @pACTION_ENDPOINT_PARAMS_ID, @pACTION_SQL_CONNECTION_ID = @pACTION_SQL_CONNECTION_ID, @pACTION_TYPE_ID = @pACTION_TYPE_ID, @pACTION_PRE_SQL = @pACTION_PRE_SQL, @pACTION_HEADER_SQL = @pACTION_HEADER_SQL, @pACTION_BODY_SQL = @pACTION_BODY_SQL, @pACTION_POST_SQL = @pACTION_POST_SQL, @pACTION_ERROR_ACTION_ID = @pACTION_ERROR_ACTION_ID, " +
+                "@pENDPOINT_ACTIVE = @pENDPOINT_ACTIVE, @pENDPOINT_DESCRIPTION = @pENDPOINT_DESCRIPTION, @pENDPOINT_URI = @pENDPOINT_URI, " +
+                "@pENDPOINT_AUTH_ACTIVE = @pENDPOINT_AUTH_ACTIVE, @pENDPOINT_AUTH_DESCRIPTION = @pENDPOINT_AUTH_DESCRIPTION, @pENDPOINT_AUTH_TYPE_ID = @pENDPOINT_AUTH_TYPE_ID, @pENDPOINT_AUTH_API_KEY = @pENDPOINT_AUTH_API_KEY, @pENDPOINT_AUTH_API_VALUE = @pENDPOINT_AUTH_API_VALUE, @pENDPOINT_AUTH_API_KEY_ADD_TO_ID = @pENDPOINT_AUTH_API_KEY_ADD_TO_ID, @pENDPOINT_AUTH_TOKEN = @pENDPOINT_AUTH_TOKEN, @pENDPOINT_AUTH_USERNAME = @pENDPOINT_AUTH_USERNAME, @pENDPOINT_AUTH_PASSWORD = @pENDPOINT_AUTH_PASSWORD, @pENDPOINT_AUTH_DOMAIN = @pENDPOINT_AUTH_DOMAIN, @pENDPOINT_AUTH_WORKSTATION = @pENDPOINT_AUTH_WORKSTATION, " +
+                "@pENDPOINT_PARAMS_ACTIVE = @pENDPOINT_PARAMS_ACTIVE, @pENDPOINT_PARAMS_DESCRIPTION = @pENDPOINT_PARAMS_DESCRIPTION, @pENDPOINT_PARAMS_GROUP_ID = @pENDPOINT_PARAMS_GROUP_ID, @pENDPOINT_PARAMS_SEQUENCE = @pENDPOINT_PARAMS_SEQUENCE, @pENDPOINT_PARAMS_KEY = @pENDPOINT_PARAMS_KEY, @pENDPOINT_PARAMS_VALUE = @pENDPOINT_PARAMS_VALUE, " +
+                "@pPROFILE_ACTIVE = @pPROFILE_ACTIVE, @pPROFILE_TYPE_ID = @pPROFILE_TYPE_ID, @pPROFILE_MANDANTOR = @pPROFILE_MANDANTOR, @pPROFILE_NAME = @pPROFILE_NAME, @pPROFILE_DESCRIPTION = @pPROFILE_DESCRIPTION, @pPROFILE_LOG_LEVEL_ID = @pPROFILE_LOG_LEVEL_ID, @pPROFILE_LANGUAGE_ID = @pPROFILE_LANGUAGE_ID, @pPROFILE_FIRST_RUN = @pPROFILE_FIRST_RUN, @pPROFILE_LAST_RUN = @pPROFILE_LAST_RUN, @pPROFILE_LAST_RESULT = @pPROFILE_LAST_RESULT, " +
+                "@pRESULT_ACTION_ID = @pRESULT_ACTION_ID, @pRESULT_STATUS_ID = @pRESULT_STATUS_ID, @pRESULT_HEADER = @pRESULT_HEADER, @pRESULT_BODY = @pRESULT_BODY; " +
                 "SELECT @RC;",
                 parameters,
                 cancel);