From 5df36d94e0a0f0953df7102721073a5a994dc396 Mon Sep 17 00:00:00 2001 From: TekH Date: Tue, 24 Mar 2026 11:37:30 +0100 Subject: [PATCH] Rename EndpointParams procedures to commands for CQRS clarity Renamed Insert/Update/DeleteEndpointParamsProcedure classes and handlers to use the "Command" suffix (e.g., InsertEndpointParamsCommand) for consistency with CQRS conventions. Updated all controller actions, handlers, and tests to use the new command names. This improves clarity and aligns naming with standard command patterns. --- src/ReC.API/Controllers/EndpointParamsController.cs | 6 +++--- .../Procedures/InsertProcedure/InsertObjectProcedure.cs | 2 +- ...intParamsProcedure.cs => DeleteEndpointParamsCommand.cs} | 6 +++--- ...intParamsProcedure.cs => InsertEndpointParamsCommand.cs} | 6 +++--- ...intParamsProcedure.cs => UpdateEndpointParamsCommand.cs} | 6 +++--- .../EndpointParams/EndpointParamsProcedureTests.cs | 6 +++--- 6 files changed, 16 insertions(+), 16 deletions(-) rename src/ReC.Application/EndpointParams/Commands/{DeleteEndpointParamsProcedure.cs => DeleteEndpointParamsCommand.cs} (78%) rename src/ReC.Application/EndpointParams/Commands/{InsertEndpointParamsProcedure.cs => InsertEndpointParamsCommand.cs} (73%) rename src/ReC.Application/EndpointParams/Commands/{UpdateEndpointParamsProcedure.cs => UpdateEndpointParamsCommand.cs} (69%) diff --git a/src/ReC.API/Controllers/EndpointParamsController.cs b/src/ReC.API/Controllers/EndpointParamsController.cs index 3c675be..361b38f 100644 --- a/src/ReC.API/Controllers/EndpointParamsController.cs +++ b/src/ReC.API/Controllers/EndpointParamsController.cs @@ -16,7 +16,7 @@ public class EndpointParamsController(IMediator mediator) : ControllerBase /// The created ENDPOINT_PARAMS identifier. [HttpPost] [ProducesResponseType(StatusCodes.Status201Created)] - public async Task Post([FromBody] InsertEndpointParamsProcedure procedure, CancellationToken cancel) + public async Task Post([FromBody] InsertEndpointParamsCommand procedure, CancellationToken cancel) { var id = await mediator.Send(procedure, cancel); return StatusCode(StatusCodes.Status201Created, id); @@ -30,7 +30,7 @@ public class EndpointParamsController(IMediator mediator) : ControllerBase /// No content on success. [HttpPut] [ProducesResponseType(StatusCodes.Status204NoContent)] - public async Task Put([FromBody] UpdateEndpointParamsProcedure procedure, CancellationToken cancel) + public async Task Put([FromBody] UpdateEndpointParamsCommand procedure, CancellationToken cancel) { await mediator.Send(procedure, cancel); return NoContent(); @@ -44,7 +44,7 @@ public class EndpointParamsController(IMediator mediator) : ControllerBase /// No content on success. [HttpDelete] [ProducesResponseType(StatusCodes.Status204NoContent)] - public async Task Delete([FromBody] DeleteEndpointParamsProcedure procedure, CancellationToken cancel) + public async Task Delete([FromBody] DeleteEndpointParamsCommand procedure, CancellationToken cancel) { await mediator.Send(procedure, cancel); return NoContent(); diff --git a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs index 09604fc..9333029 100644 --- a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs +++ b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs @@ -29,7 +29,7 @@ public record InsertObjectProcedure : IRequest public InsertEndpointAuthCommand EndpointAuth { get; set; } = new(); public InsertProfileProcedure Profile { get; set; } = new(); public InsertResultProcedure Result { get; set; } = new(); - public InsertEndpointParamsProcedure EndpointParams { get; set; } = new(); + public InsertEndpointParamsCommand EndpointParams { get; set; } = new(); } public class InsertObjectProcedureHandler(IRepository repo, IOptionsMonitor sqlExOpt) : IRequestHandler diff --git a/src/ReC.Application/EndpointParams/Commands/DeleteEndpointParamsProcedure.cs b/src/ReC.Application/EndpointParams/Commands/DeleteEndpointParamsCommand.cs similarity index 78% rename from src/ReC.Application/EndpointParams/Commands/DeleteEndpointParamsProcedure.cs rename to src/ReC.Application/EndpointParams/Commands/DeleteEndpointParamsCommand.cs index d358a97..eea8d52 100644 --- a/src/ReC.Application/EndpointParams/Commands/DeleteEndpointParamsProcedure.cs +++ b/src/ReC.Application/EndpointParams/Commands/DeleteEndpointParamsCommand.cs @@ -3,7 +3,7 @@ using ReC.Application.Common.Procedures.DeleteProcedure; namespace ReC.Application.EndpointParams.Commands; -public record DeleteEndpointParamsProcedure : IDeleteProcedure +public record DeleteEndpointParamsCommand : IDeleteProcedure { /// /// Start GUID/ID (inclusive) @@ -21,9 +21,9 @@ public record DeleteEndpointParamsProcedure : IDeleteProcedure public bool Force { get; set; } } -public class DeleteEndpointParamsProcedureHandler(ISender sender) : IRequestHandler +public class DeleteEndpointParamsProcedureHandler(ISender sender) : IRequestHandler { - public async Task Handle(DeleteEndpointParamsProcedure request, CancellationToken cancel) + public async Task Handle(DeleteEndpointParamsCommand request, CancellationToken cancel) { return await sender.Send(new DeleteObjectProcedure { diff --git a/src/ReC.Application/EndpointParams/Commands/InsertEndpointParamsProcedure.cs b/src/ReC.Application/EndpointParams/Commands/InsertEndpointParamsCommand.cs similarity index 73% rename from src/ReC.Application/EndpointParams/Commands/InsertEndpointParamsProcedure.cs rename to src/ReC.Application/EndpointParams/Commands/InsertEndpointParamsCommand.cs index 3c475e5..40e0fbb 100644 --- a/src/ReC.Application/EndpointParams/Commands/InsertEndpointParamsProcedure.cs +++ b/src/ReC.Application/EndpointParams/Commands/InsertEndpointParamsCommand.cs @@ -3,7 +3,7 @@ using ReC.Application.Common.Procedures.InsertProcedure; namespace ReC.Application.EndpointParams.Commands; -public record InsertEndpointParamsProcedure : IInsertProcedure +public record InsertEndpointParamsCommand : IInsertProcedure { public bool? Active { get; set; } public string? Description { get; set; } @@ -13,9 +13,9 @@ public record InsertEndpointParamsProcedure : IInsertProcedure public string? Value { get; set; } } -public class InsertEndpointParamsProcedureHandler(ISender sender) : IRequestHandler +public class InsertEndpointParamsProcedureHandler(ISender sender) : IRequestHandler { - public async Task Handle(InsertEndpointParamsProcedure request, CancellationToken cancel) + public async Task Handle(InsertEndpointParamsCommand request, CancellationToken cancel) { return await sender.Send(new InsertObjectProcedure { diff --git a/src/ReC.Application/EndpointParams/Commands/UpdateEndpointParamsProcedure.cs b/src/ReC.Application/EndpointParams/Commands/UpdateEndpointParamsCommand.cs similarity index 69% rename from src/ReC.Application/EndpointParams/Commands/UpdateEndpointParamsProcedure.cs rename to src/ReC.Application/EndpointParams/Commands/UpdateEndpointParamsCommand.cs index 1de5dac..446e71e 100644 --- a/src/ReC.Application/EndpointParams/Commands/UpdateEndpointParamsProcedure.cs +++ b/src/ReC.Application/EndpointParams/Commands/UpdateEndpointParamsCommand.cs @@ -4,16 +4,16 @@ using ReC.Application.Common.Procedures.UpdateProcedure.Dto; namespace ReC.Application.EndpointParams.Commands; -public record UpdateEndpointParamsProcedure : IUpdateProcedure +public record UpdateEndpointParamsCommand : IUpdateProcedure { public long Id { get; set; } public UpdateEndpointParamsDto Data { get; set; } = null!; } -public class UpdateEndpointParamsProcedureHandler(ISender sender) : IRequestHandler +public class UpdateEndpointParamsProcedureHandler(ISender sender) : IRequestHandler { - public async Task Handle(UpdateEndpointParamsProcedure request, CancellationToken cancel) + public async Task Handle(UpdateEndpointParamsCommand request, CancellationToken cancel) { return await sender.Send(new UpdateObjectProcedure { diff --git a/tests/ReC.Tests/Application/EndpointParams/EndpointParamsProcedureTests.cs b/tests/ReC.Tests/Application/EndpointParams/EndpointParamsProcedureTests.cs index e82da0c..2bd3320 100644 --- a/tests/ReC.Tests/Application/EndpointParams/EndpointParamsProcedureTests.cs +++ b/tests/ReC.Tests/Application/EndpointParams/EndpointParamsProcedureTests.cs @@ -17,7 +17,7 @@ public class EndpointParamsProcedureTests : RecApplicationTestBase [Test] public async Task InsertEndpointParamsProcedure_runs_via_mediator() { - var procedure = new InsertEndpointParamsProcedure { Active = true, Description = "param", GroupId = 1, Sequence = 1, Key = "k", Value = "v" }; + var procedure = new InsertEndpointParamsCommand { Active = true, Description = "param", GroupId = 1, Sequence = 1, Key = "k", Value = "v" }; var (sender, scope) = CreateScopedSender(); using var _ = scope; @@ -29,7 +29,7 @@ public class EndpointParamsProcedureTests : RecApplicationTestBase [Test] public async Task UpdateEndpointParamsProcedure_runs_via_mediator() { - var procedure = new UpdateEndpointParamsProcedure { Data = { Active = false, Description = "param-update", GroupId = 2, Sequence = 2, Key = "k2", Value = "v2" }, Id = 25 }; + var procedure = new UpdateEndpointParamsCommand { Data = { Active = false, Description = "param-update", GroupId = 2, Sequence = 2, Key = "k2", Value = "v2" }, Id = 25 }; var (sender, scope) = CreateScopedSender(); using var _ = scope; @@ -41,7 +41,7 @@ public class EndpointParamsProcedureTests : RecApplicationTestBase [Test] public async Task DeleteEndpointParamsProcedure_runs_via_mediator() { - var procedure = new DeleteEndpointParamsProcedure { Start = 5, End = 6, Force = true }; + var procedure = new DeleteEndpointParamsCommand { Start = 5, End = 6, Force = true }; var (sender, scope) = CreateScopedSender(); using var _ = scope;