From 2ded140ad54cc65038111c5d29e7407a3fd72b89 Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Thu, 22 Jan 2026 09:33:54 +0100
Subject: [PATCH] Rename SqlExceptionNumber to BadRequestSqlExceptionNumber

Clarify intent by renaming SqlExceptionNumber to BadRequestSqlExceptionNumber in both configuration and code. This makes it explicit that these SQL exception numbers are mapped to HTTP 400 Bad Request errors. All relevant usages and settings have been updated accordingly.
---
 src/ReC.API/appsettings.json                                  | 4 ++--
 src/ReC.Application/Common/Options/SqlExceptionOptions.cs     | 2 +-
 .../Procedures/DeleteProcedure/DeleteObjectProcedure.cs       | 2 +-
 .../Procedures/InsertProcedure/InsertObjectProcedure.cs       | 2 +-
 .../Procedures/UpdateProcedure/UpdateObjectProcedure.cs       | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/ReC.API/appsettings.json b/src/ReC.API/appsettings.json
index 769ff22..9e4d561 100644
--- a/src/ReC.API/appsettings.json
+++ b/src/ReC.API/appsettings.json
@@ -8,10 +8,10 @@
   "RecAction": {
     "MaxConcurrentInvocations": 5
   },
-  // SqlException numbers can be updated at runtime; no restart required.
+  // Bad request SqlException numbers numbers can be updated at runtime; no restart required.
   "SqlException": {
     // https://learn.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlexception.number
-    "SqlExceptionNumber": [ 515, 547, 2601, 2627, 50000 ]
+    "BadRequestSqlExceptionNumbers": [ 515, 547, 2601, 2627, 50000 ]
   },
   "AddedWho": "ReC.API",
   "FakeProfileId": 2
diff --git a/src/ReC.Application/Common/Options/SqlExceptionOptions.cs b/src/ReC.Application/Common/Options/SqlExceptionOptions.cs
index 1ac7691..6bb9cc3 100644
--- a/src/ReC.Application/Common/Options/SqlExceptionOptions.cs
+++ b/src/ReC.Application/Common/Options/SqlExceptionOptions.cs
@@ -2,5 +2,5 @@ namespace ReC.Application.Common.Options;
 
 public class SqlExceptionOptions
 {
-    public HashSet<int> SqlExceptionNumber { get; set; } = [];
+    public HashSet<int> BadRequestSqlExceptionNumbers { get; set; } = [];
 }
\ No newline at end of file
diff --git a/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs b/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
index 6033097..026482b 100644
--- a/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/DeleteProcedure/DeleteObjectProcedure.cs
@@ -82,7 +82,7 @@ public class DeleteObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
         }
         catch (SqlException ex)
         {
-            if (sqlExOpt.CurrentValue.SqlExceptionNumber.Contains(ex.Number))
+            if (sqlExOpt.CurrentValue.BadRequestSqlExceptionNumbers.Contains(ex.Number))
                 throw new BadRequestException(ex.Message, ex);
             else
                 throw;
diff --git a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
index 022e0dd..c2ce803 100644
--- a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
@@ -130,7 +130,7 @@ public class InsertObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
         }
         catch (SqlException ex)
         {
-            if (sqlExOpt.CurrentValue.SqlExceptionNumber.Contains(ex.Number))
+            if (sqlExOpt.CurrentValue.BadRequestSqlExceptionNumbers.Contains(ex.Number))
                 throw new BadRequestException(ex.Message, ex);
             else
                 throw;
diff --git a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
index cf64741..73a3ca8 100644
--- a/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/UpdateProcedure/UpdateObjectProcedure.cs
@@ -142,7 +142,7 @@ public class UpdateObjectProcedureHandler(IRepository repo, IOptionsMonitor<SqlE
         }
         catch (SqlException ex)
         {
-            if (sqlExOpt.CurrentValue.SqlExceptionNumber.Contains(ex.Number))
+            if (sqlExOpt.CurrentValue.BadRequestSqlExceptionNumbers.Contains(ex.Number))
                 throw new BadRequestException(ex.Message, ex);
             else
                 throw;