From 24f146ca26b739a9fee9cba992e5ce9c950e9135 Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Wed, 14 Jan 2026 09:44:31 +0100
Subject: [PATCH] Refactor InsertObjectFailedException for more context

InsertObjectFailedException now requires an InsertObjectProcedure
instance, improving error context. Exception throwing in
InsertObjectProcedureHandler updated to pass the procedure object
instead of just a message and serialized request.
---
 .../Exceptions/InsertObjectFailedException.cs       | 13 ++++++++++---
 .../InsertProcedure/InsertObjectProcedure.cs        |  4 +---
 2 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/ReC.Application/Common/Exceptions/InsertObjectFailedException.cs b/src/ReC.Application/Common/Exceptions/InsertObjectFailedException.cs
index 5a048a8..0e092a2 100644
--- a/src/ReC.Application/Common/Exceptions/InsertObjectFailedException.cs
+++ b/src/ReC.Application/Common/Exceptions/InsertObjectFailedException.cs
@@ -1,16 +1,23 @@
+using ReC.Application.Common.Procedures.InsertProcedure;
+
 namespace ReC.Application.Common.Exceptions;
 
 public class InsertObjectFailedException : Exception
 {
-    public InsertObjectFailedException() : base()
+    private readonly InsertObjectProcedure _procedure;
+
+    public InsertObjectFailedException(InsertObjectProcedure procedure) : base()
     {
+        _procedure = procedure;
     }
 
-    public InsertObjectFailedException(string? message) : base(message)
+    public InsertObjectFailedException(InsertObjectProcedure procedure, string? message) : base(message)
     {
+        _procedure = procedure;
     }
 
-    public InsertObjectFailedException(string? message, Exception? innerException) : base(message, innerException)
+    public InsertObjectFailedException(InsertObjectProcedure procedure, string? message, Exception? innerException) : base(message, innerException)
     {
+        _procedure = procedure;
     }
 }
\ No newline at end of file
diff --git a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
index 77ccac5..b307fb9 100644
--- a/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/InsertProcedure/InsertObjectProcedure.cs
@@ -113,8 +113,6 @@ public class InsertObjectProcedureHandler(IRepository repo) : IRequestHandler<In
             else if (long.TryParse(guidParam.Value.ToString(), out var guid))
                 return guid;
 
-        throw new InsertObjectFailedException(
-            "InsertObject stored procedure did not return a valid identifier." +
-            JsonSerializer.Serialize(request, options: new() { WriteIndented = true }));
+        throw new InsertObjectFailedException(request, "InsertObject stored procedure did not return a valid identifier.");
     }
 }
\ No newline at end of file