From 11206cf84f6214ddfda66b7270b1681154e23b69 Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Mon, 12 Jan 2026 16:27:45 +0100
Subject: [PATCH] Throw exception on failed InsertObject identifier return

Replace default return of 0 with InsertObjectFailedException when the stored procedure does not return a valid identifier. Exception message includes serialized request for easier debugging. Added necessary imports for exception and JSON serialization.
---
 .../Common/Procedures/InsertObjectProcedure.cs              | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/ReC.Application/Common/Procedures/InsertObjectProcedure.cs b/src/ReC.Application/Common/Procedures/InsertObjectProcedure.cs
index 9996468..1ab6e6c 100644
--- a/src/ReC.Application/Common/Procedures/InsertObjectProcedure.cs
+++ b/src/ReC.Application/Common/Procedures/InsertObjectProcedure.cs
@@ -1,6 +1,8 @@
 using DigitalData.Core.Abstraction.Application.Repository;
 using MediatR;
 using Microsoft.Data.SqlClient;
+using ReC.Application.Common.Exceptions;
+using System.Text.Json;
 
 namespace ReC.Application.Common.Procedures;
 
@@ -183,6 +185,8 @@ public class InsertObjectProcedureHandler(IRepository repo) : IRequestHandler<In
             else if (long.TryParse(guidParam.Value.ToString(), out var guid))
                 return guid;
 
-        return 0;
+        throw new InsertObjectFailedException(
+            $"InsertObject stored procedure did not return a valid identifier." +
+            $"{JsonSerializer.Serialize(request, options: new() { WriteIndented = true })}");
     }
 }
\ No newline at end of file