AppStd/Modules
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Interfaces: Dont log ZUGFeRD Exceptions while validating, leads to misleading error messages

Browse Source
This commit is contained in:
Jonathan Jenne 2020-04-22 10:47:09 +02:00
parent afe42e52c0
commit 99e7a36d84
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Modules.Interfaces/ZUGFeRDInterface.vb
View File

@ -141,6 +141,10 @@ Public Class ZUGFeRDInterface
Try Try
Dim oResults = oAttachmentExtractor.Extract(Path, oAllowedExtensions) Dim oResults = oAttachmentExtractor.Extract(Path, oAllowedExtensions)
Return HandleAttachments(oResults) Return HandleAttachments(oResults)
Catch ex As ZUGFeRDExecption
' Don't log ZUGFeRD Exceptions here, they should be handled by the calling code.
' It also produces misleading error messages when checking if an attachment is a zugferd file.
Throw ex
Catch ex As Exception Catch ex As Exception
_logger.Error(ex) _logger.Error(ex)
Throw ex Throw ex
@ -178,6 +182,10 @@ Public Class ZUGFeRDInterface
End Using End Using
Return oXmlDocument Return oXmlDocument
Catch ex As ZUGFeRDExecption
' Don't log ZUGFeRD Exceptions here, they should be handled by the calling code.
' It also produces misleading error messages when checking if an attachment is a zugferd file.
Throw ex
Catch ex As Exception Catch ex As Exception
_logger.Error(ex) _logger.Error(ex)
Throw ex Throw ex