refactor: simplify AddReportBehavior by making DoCreateReport static and reordering base64 conversion

EnvelopeGenerator.Application.VB/EnvelopeGenerator.Application.VB.vbproj

@@ -6,11 +6,11 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="DevExpress.Data" Version="25.1.6" />
+    <PackageReference Include="DevExpress.Data" Version="21.2.4" />
-    <PackageReference Include="DevExpress.Reporting.Core" Version="25.1.6" />
+    <PackageReference Include="DevExpress.Reporting.Core" Version="21.2.4" />
-    <PackageReference Include="DevExpress.Win" Version="25.1.6" />
+    <PackageReference Include="DevExpress.Win" Version="21.2.0" />
-    <PackageReference Include="DevExpress.Xpo" Version="25.1.6" />
+    <PackageReference Include="DevExpress.Xpo" Version="21.2.4" />
-    <PackageReference Include="System.Drawing.Common" Version="10.0.0" />
+    <PackageReference Include="System.Drawing.Common" Version="7.0.0" />
   </ItemGroup>
 
   <ItemGroup>

EnvelopeGenerator.Application/EnvelopeGenerator.Application.csproj

@@ -52,6 +52,8 @@
 	</ItemGroup>
 
 	<ItemGroup>
+		<ProjectReference Include="..\EnvelopeGenerator.Application.VB\EnvelopeGenerator.Application.VB.vbproj" />
+		<ProjectReference Include="..\EnvelopeGenerator.CommonServices\EnvelopeGenerator.CommonServices.vbproj" />
 		<ProjectReference Include="..\EnvelopeGenerator.Domain\EnvelopeGenerator.Domain.csproj" />
 		<ProjectReference Include="..\EnvelopeGenerator.PdfEditor\EnvelopeGenerator.PdfEditor.csproj" />
 	</ItemGroup>

EnvelopeGenerator.Application/Pdf/Behaviors/AddReportBehavior.cs

@@ -5,6 +5,7 @@ using EnvelopeGenerator.Application.EnvelopeReports;
 using EnvelopeGenerator.Application.Exceptions;
 using EnvelopeGenerator.Domain.Entities;
 using Microsoft.Extensions.Logging;
+using EnvelopeGenerator.Application.VB;
 
 namespace EnvelopeGenerator.Application.Pdf.Behaviors;
 
@@ -38,7 +39,6 @@ public class AddReportBehavior : IPipelineBehavior<BurnPdfCommand, byte[]>
     public async Task<byte[]> Handle(BurnPdfCommand request, RequestHandlerDelegate<byte[]> next, CancellationToken cancel)
     {
         var docResult = await next(cancel);
-        var base64 = Convert.ToBase64String(docResult);
 
         if (!request.Debug)
             await _sender.Send(new CreateHistoryCommand()
@@ -50,6 +50,8 @@ public class AddReportBehavior : IPipelineBehavior<BurnPdfCommand, byte[]>
 
         docResult = await CreateReport(request.Envelope!, cancel);
 
+        var base64 = Convert.ToBase64String(docResult);
+
         return docResult;
     }
 
@@ -69,12 +71,12 @@ public class AddReportBehavior : IPipelineBehavior<BurnPdfCommand, byte[]>
             throw new CreateReportException("No report data found!");
         }
 
-        var oBuffer = DoCreateReport(oItems);
+        var oBuffer = AddReportBehavior.DoCreateReport(oItems);
 
         return oBuffer;
     }
 
-    private byte[] DoCreateReport(IEnumerable<EnvelopeReport> oItems)
+    private static byte[] DoCreateReport(IEnumerable<EnvelopeReport> oItems)
     {
         var oSource = new ReportSource { Items = oItems };
         var oReport = new rptEnvelopeHistory

EnvelopeGenerator.CommonServices/EnvelopeGenerator.CommonServices.vbproj

@@ -560,10 +560,6 @@
       <Project>{4f32a98d-e6f0-4a09-bd97-1cf26107e837}</Project>
       <Name>EnvelopeGenerator.Domain</Name>
     </ProjectReference>
-    <ProjectReference Include="..\EnvelopeGenerator.Infrastructure\EnvelopeGenerator.Infrastructure.csproj">
-      <Project>{63e32615-0eca-42dc-96e3-91037324b7c7}</Project>
-      <Name>EnvelopeGenerator.Infrastructure</Name>
-    </ProjectReference>
     <ProjectReference Include="..\EnvelopeGenerator.PdfEditor\EnvelopeGenerator.PdfEditor.csproj">
       <Project>{211619f5-ae25-4ba5-a552-bacafe0632d3}</Project>
       <Name>EnvelopeGenerator.PdfEditor</Name>

EnvelopeGenerator.CommonServices/Jobs/FinalizeDocument/FinalizeDocumentJob.vb

@@ -69,29 +69,6 @@ Namespace Jobs
                 Dim oConnectionString As String = pContext.MergedJobDataMap.Item(Value.DATABASE)
                 Database = New MSSQLServer(LogConfig, MSSQLServer.DecryptConnectionString(oConnectionString))
 
-#Disable Warning BC40000 ' Type or member is obsolete
-                Factory.Shared _
-                .BehaveOnPostBuild(PostBuildBehavior.Ignore) _
-                .AddEGInfrastructureServices(
-                Sub(opt)
-                    opt.AddDbTriggerParams(
-                        Sub(triggers)
-                            triggers("Envelope") = New List(Of String) From {"TBSIG_ENVELOPE_AFT_INS"}
-                            triggers("History") = New List(Of String) From {"TBSIG_ENVELOPE_HISTORY_AFT_INS"}
-                            triggers("EmailOut") = New List(Of String) From {"TBEMLP_EMAIL_OUT_AFT_INS", "TBEMLP_EMAIL_OUT_AFT_UPD"}
-                            triggers("EnvelopeReceiverReadOnly") = New List(Of String) From {"TBSIG_ENVELOPE_RECEIVER_READ_ONLY_UPD"}
-                            triggers("Receiver") = New List(Of String)() ' no tigger
-                            triggers("EmailTemplate") = New List(Of String) From {"TBSIG_EMAIL_TEMPLATE_AFT_UPD"}
-                        End Sub)
-                    opt.AddDbContext(
-                        Sub(options)
-                            options.UseSqlServer(oConnectionString) _
-                                   .EnableSensitiveDataLogging() _
-                                   .EnableDetailedErrors()
-                        End Sub)
-                End Sub)
-#Enable Warning BC40000 ' Type or member is obsolete
-
                 Logger.Debug("Loading Models & Services")
                 Dim oState = GetState()
                 InitializeModels(oState)

EnvelopeGenerator.sln

@@ -43,6 +43,8 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EnvelopeGenerator.Finalizer
 EndProject
 Project("{F184B08F-C81C-45F6-A57F-5ABD9991F28F}") = "EnvelopeGenerator.Application.VB", "EnvelopeGenerator.Application.VB\EnvelopeGenerator.Application.VB.vbproj", "{9E123E6B-2A94-47C7-8BA1-ECDA5E1422C6}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EnvelopeGenerator.Application.Abstractions", "EnvelopeGenerator.Application.Abstractions\EnvelopeGenerator.Application.Abstractions.csproj", "{AC34E68D-B660-4E65-9875-4EB8ACAC43AE}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -109,6 +111,10 @@ Global
 		{9E123E6B-2A94-47C7-8BA1-ECDA5E1422C6}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{9E123E6B-2A94-47C7-8BA1-ECDA5E1422C6}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{9E123E6B-2A94-47C7-8BA1-ECDA5E1422C6}.Release|Any CPU.Build.0 = Release|Any CPU
+		{AC34E68D-B660-4E65-9875-4EB8ACAC43AE}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{AC34E68D-B660-4E65-9875-4EB8ACAC43AE}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{AC34E68D-B660-4E65-9875-4EB8ACAC43AE}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{AC34E68D-B660-4E65-9875-4EB8ACAC43AE}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -132,6 +138,7 @@ Global
 		{B97DE7DD-3190-4A84-85E9-E57AD735BE61} = {E3C758DC-914D-4B7E-8457-0813F1FDB0CB}
 		{C4970E6C-DB2E-48C5-B3C5-2AF589405ED9} = {E3C758DC-914D-4B7E-8457-0813F1FDB0CB}
 		{9E123E6B-2A94-47C7-8BA1-ECDA5E1422C6} = {9943209E-1744-4944-B1BA-4F87FC1A0EEB}
+		{AC34E68D-B660-4E65-9875-4EB8ACAC43AE} = {9943209E-1744-4944-B1BA-4F87FC1A0EEB}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {73E60370-756D-45AD-A19A-C40A02DACCC7}