AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Refactor PDF editor UI and improve PDF loading logic

Browse Source 
Simplify and restructure conditional logic in `SenderPdfImageEditor.razor` for better readability and maintainability. Merge redundant `else` blocks and reorganize rendering logic for page previews and fields.

Enhance PDF loading and page preview generation in `SenderEditorPage.razor`. Add error handling for failed page rendering, log warnings, and ensure consistent `_pageCount` initialization based on available data.

These changes improve code clarity, robustness, and maintainability.
This commit is contained in:
tekh
2026-10-02 11:51:14 +02:00
parent 0eaa9ff08f
commit f86588551c
2 changed files with 77 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
EnvelopeGenerator.Server/EnvelopeGenerator.Server.Client/Components/PdfEditor/SenderPdfImageEditor.razor
View File

@@ -47,9 +47,7 @@
{ {
<div class="sender-image-editor__empty">@L("SenderEditor_NoPagesToDisplay", "Keine Seiten zur Anzeige verfügbar.")</div> <div class="sender-image-editor__empty">@L("SenderEditor_NoPagesToDisplay", "Keine Seiten zur Anzeige verfügbar.")</div>
} }
else else if (Pages.Count == 0 && !string.IsNullOrWhiteSpace(PdfDataUrl))
{
@if (Pages.Count == 0 && !string.IsNullOrWhiteSpace(PdfDataUrl))
{ {
<div class="sender-image-editor__native-preview" style="@GetZoomStyle()"> <div class="sender-image-editor__native-preview" style="@GetZoomStyle()">
<iframe class="sender-image-editor__native-frame" <iframe class="sender-image-editor__native-frame"
@@ -57,7 +55,8 @@
title="PDF Preview"></iframe> title="PDF Preview"></iframe>
</div> </div>
} }
else
{
<div class="sender-image-editor__pages" style="@GetZoomStyle()"> <div class="sender-image-editor__pages" style="@GetZoomStyle()">
@for (var pageIndex = 0; pageIndex < PageCount; pageIndex++) @for (var pageIndex = 0; pageIndex < PageCount; pageIndex++)
{ {

24
EnvelopeGenerator.Server/EnvelopeGenerator.Server.Client/Pages/SenderEditorPage.razor
View File

@@ -826,11 +826,31 @@
_originalPdfBytes = document?.ByteData; _originalPdfBytes = document?.ByteData;
_pdfLoaded = _originalPdfBytes is { Length: > 0 }; _pdfLoaded = _originalPdfBytes is { Length: > 0 };
if (_pdfLoaded)
{
try
{
_pagePreviews = (await PdfRenderService.RenderPagesAsync(_originalPdfBytes!))
.OrderBy(p => p.PageNumber)
.ToList();
}
catch (Exception renderEx)
{
Logger.LogWarning(renderEx, "Failed to render PDF page previews for envelope {EnvelopeId}. Falling back to native preview.", envelopeId);
_pagePreviews = []; _pagePreviews = [];
}
_pageCount = _pagePreviews.Count > 0 _pageCount = _pagePreviews.Count > 0
? _pagePreviews.Count ? _pagePreviews.Count
: EstimatePdfPageCount(_originalPdfBytes) : 1;
?? Math.Max(1, _signatureFields.Select(f => f.Page).DefaultIfEmpty(1).Max()); }
else
{
_pagePreviews = [];
_pageCount = Math.Max(1, _signatureFields.Select(f => f.Page).DefaultIfEmpty(1).Max());
}
_fileName = $"Envelope-{envelopeId}.pdf"; _fileName = $"Envelope-{envelopeId}.pdf";
_pendingReceiverForPlacement = null; _pendingReceiverForPlacement = null;
_loadedEnvelopeId = envelopeId; _loadedEnvelopeId = envelopeId;