From e62830973445d87d90074831a5103b371494eea6 Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Fri, 27 Jun 2025 13:14:14 +0200
Subject: [PATCH] Refactor TestEnvelopeMailController for clarity

Updated using directives, added Obsolete attributes, and improved error handling in SendAccessCode method. Enhanced code clarity while preserving overall structure.
---
 .../Test/TestEnvelopeMailController.cs        | 74 ++++++++++---------
 1 file changed, 38 insertions(+), 36 deletions(-)

diff --git a/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeMailController.cs b/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeMailController.cs
index 5b0327eb..59b3abbf 100644
--- a/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeMailController.cs
+++ b/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeMailController.cs
@@ -1,48 +1,50 @@
-using DigitalData.Core.DTO;
+using DigitalData.Core.Abstraction.Application.DTO;
 using EnvelopeGenerator.Application.Contracts.Services;
 using EnvelopeGenerator.Application.DTOs.EnvelopeReceiver;
 using Microsoft.AspNetCore.Mvc;
-using System.Net;
 
-namespace EnvelopeGenerator.Web.Controllers.Test
-{
-    [ApiController]
-	[Route("api/test/[controller]")]
-	public class TestEnvelopeMailController : ControllerBase
-	{
-		private readonly ILogger<TestEnvelopeMailController> _logger;
-		private readonly IEnvelopeMailService _mailService;
-		private readonly IEnvelopeReceiverService _envRcvService;
+namespace EnvelopeGenerator.Web.Controllers.Test;
 
-		public TestEnvelopeMailController(ILogger<TestEnvelopeMailController> logger, IEnvelopeMailService envelopeMailService, IEnvelopeReceiverService envelopeReceiverService)
-		{
-			_logger = logger;
-			_mailService = envelopeMailService;
-			_envRcvService = envelopeReceiverService;
-		}
+[ApiController]
+[Route("api/test/[controller]")]
+public class TestEnvelopeMailController : ControllerBase
+{
+	private readonly ILogger<TestEnvelopeMailController> _logger;
+    [Obsolete("Use MediatR")]
+    private readonly IEnvelopeMailService _mailService;
+    [Obsolete("Use MediatR")]
+    private readonly IEnvelopeReceiverService _envRcvService;
 
-		[HttpGet]
-		public async Task<IActionResult> SendAccessCode([FromQuery] string envelopeReceiverId = "ZDlmYjZmYjctNTBhNS00NTcyLWI5NTQtYzJjYmY4N2UwZmZhOjowRDI3MkEwNTdGMjRBMkY3MEZDMzM3QkRBQzA1MjYxRjU3NTI2QzgxQ0IyMUE5NzE1RjA1NTJFQzdFNjIwNjY1")
-		{
-			return await _envRcvService.ReadByEnvelopeReceiverIdAsync(envelopeReceiverId: envelopeReceiverId).ThenAsync<EnvelopeReceiverDto, IActionResult>(
-				SuccessAsync: async er =>
-				{
+    [Obsolete("Use MediatR")]
+    public TestEnvelopeMailController(ILogger<TestEnvelopeMailController> logger, IEnvelopeMailService envelopeMailService, IEnvelopeReceiverService envelopeReceiverService)
+	{
+		_logger = logger;
+		_mailService = envelopeMailService;
+		_envRcvService = envelopeReceiverService;
+	}
 
+	[HttpGet]
+    [Obsolete("Use MediatR")]
+    public async Task<IActionResult> SendAccessCode([FromQuery] string envelopeReceiverId = "ZDlmYjZmYjctNTBhNS00NTcyLWI5NTQtYzJjYmY4N2UwZmZhOjowRDI3MkEwNTdGMjRBMkY3MEZDMzM3QkRBQzA1MjYxRjU3NTI2QzgxQ0IyMUE5NzE1RjA1NTJFQzdFNjIwNjY1")
+	{
+		return await _envRcvService.ReadByEnvelopeReceiverIdAsync(envelopeReceiverId: envelopeReceiverId).ThenAsync<EnvelopeReceiverDto, IActionResult>(
+			SuccessAsync: async er =>
+			{
 
-					var mailRes = await _mailService.SendAccessCodeAsync(envelopeReceiverDto: er);
-					if (mailRes.IsFailed)
-					{
-						_logger.LogNotice(mailRes);
-						return StatusCode(500, mailRes.Notices);
-					}
 
-					return Ok();
-				},
-				Fail: (messages, notices) =>
+				var mailRes = await _mailService.SendAccessCodeAsync(envelopeReceiverDto: er);
+				if (mailRes.IsFailed)
 				{
-					_logger.LogNotice(notices);
-					return StatusCode(500, notices);
-				});
-		}
+					_logger.LogNotice(mailRes);
+					return StatusCode(500, mailRes.Notices);
+				}
+
+				return Ok();
+			},
+			Fail: (messages, notices) =>
+			{
+				_logger.LogNotice(notices);
+				return StatusCode(500, notices);
+			});
 	}
 }
\ No newline at end of file