diff --git a/EnvelopeGenerator.Web/Controllers/ReadOnlyController.cs b/EnvelopeGenerator.Web/Controllers/ReadOnlyController.cs index 4bdce152..37ed0c5f 100644 --- a/EnvelopeGenerator.Web/Controllers/ReadOnlyController.cs +++ b/EnvelopeGenerator.Web/Controllers/ReadOnlyController.cs @@ -5,7 +5,6 @@ using EnvelopeGenerator.Extensions; using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Mvc; using Newtonsoft.Json; -using static System.Runtime.InteropServices.JavaScript.JSType; namespace EnvelopeGenerator.Web.Controllers { @@ -79,14 +78,21 @@ namespace EnvelopeGenerator.Web.Controllers var new_erro = read_res.Data; //send email two receiver - return await _mailService.SendAsync(new_erro).ThenAsync(Success: res => + return await _mailService.SendAsync(new_erro).ThenAsync(SuccessAsync: async res => { //TODO: remove casting after change the id type - _histService.RecordAsync((int) createDto.EnvelopeId, createDto.AddedWho, Common.Constants.EnvelopeStatus.EnvelopeShared); + var hist_res = await _histService.RecordAsync((int) createDto.EnvelopeId, createDto.AddedWho, Common.Constants.EnvelopeStatus.EnvelopeShared); + + if (hist_res.IsFailed) + { + _logger.LogError("Although the envelope was sent as read-only, the EnvelopeShared hisotry could not be saved. Create DTO:\n{createDto}", JsonConvert.SerializeObject(createDto)); + _logger.LogNotice(hist_res.Notices); + } + return Ok(); }, - Fail: IActionResult (msg, ntc) => + Fail: (msg, ntc) => { _logger.LogNotice(ntc); return StatusCode(StatusCodes.Status500InternalServerError);