Refactor: Use FinalEmailType enum for email settings
Replaced raw `int` values with the strongly-typed `FinalEmailType` enum for `FinalEmailToCreator` and `FinalEmailToReceivers` across the codebase. Updated DTOs, entities, commands, handlers, Razor components, and test controllers to reflect this change. This improves type safety, code readability, and maintainability. Default values now use `FinalEmailType.No` instead of integer casting. Adjusted database mappings and added necessary imports to support the new enum type.
This commit is contained in:
@@ -79,12 +79,12 @@ public record EnvelopeDto : IEnvelope
|
|||||||
/// <summary>
|
/// <summary>
|
||||||
///
|
///
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public int? FinalEmailToCreator { get; set; }
|
public FinalEmailType? FinalEmailToCreator { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
///
|
///
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public int? FinalEmailToReceivers { get; set; }
|
public FinalEmailType? FinalEmailToReceivers { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
///
|
///
|
||||||
|
|||||||
@@ -35,12 +35,12 @@ public class EnvelopeTypeDefaultsDto
|
|||||||
/// <summary>
|
/// <summary>
|
||||||
/// Gets or sets the final email template ID to be sent to the creator.
|
/// Gets or sets the final email template ID to be sent to the creator.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public int? FinalEmailToCreator { get; set; }
|
public FinalEmailType? FinalEmailToCreator { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Gets or sets the final email template ID to be sent to the receivers.
|
/// Gets or sets the final email template ID to be sent to the receivers.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public int? FinalEmailToReceivers { get; set; }
|
public FinalEmailType? FinalEmailToReceivers { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Gets or sets the timestamp when this envelope type was added.
|
/// Gets or sets the timestamp when this envelope type was added.
|
||||||
|
|||||||
@@ -46,8 +46,8 @@ public class ReadEnvelopeTypesQueryHandler : IRequestHandler<ReadEnvelopeTypesQu
|
|||||||
Language = string.IsNullOrWhiteSpace(t.Language) ? "de-DE" : t.Language,
|
Language = string.IsNullOrWhiteSpace(t.Language) ? "de-DE" : t.Language,
|
||||||
ExpiresDays = t.ExpiresDays,
|
ExpiresDays = t.ExpiresDays,
|
||||||
UseAccessCode = t.UseAccessCode,
|
UseAccessCode = t.UseAccessCode,
|
||||||
FinalEmailToCreator = (int?)t.FinalEmailToCreator,
|
FinalEmailToCreator = t.FinalEmailToCreator,
|
||||||
FinalEmailToReceivers = (int?)t.FinalEmailToReceivers,
|
FinalEmailToReceivers = t.FinalEmailToReceivers,
|
||||||
AddedWhen = t.AddedWhen,
|
AddedWhen = t.AddedWhen,
|
||||||
ChangedWhen = t.ChangedWhen,
|
ChangedWhen = t.ChangedWhen,
|
||||||
ExpiresWarningDays = t.ExpiresWarningDays,
|
ExpiresWarningDays = t.ExpiresWarningDays,
|
||||||
|
|||||||
@@ -37,12 +37,12 @@ public record CreateEnvelopeCommand : IRequest<EnvelopeDto?>
|
|||||||
/// <summary>
|
/// <summary>
|
||||||
/// Finale E-Mail-Einstellung fuer den Ersteller.
|
/// Finale E-Mail-Einstellung fuer den Ersteller.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public int? FinalEmailToCreator { get; set; }
|
public FinalEmailType? FinalEmailToCreator { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Finale E-Mail-Einstellung fuer die Empfaenger.
|
/// Finale E-Mail-Einstellung fuer die Empfaenger.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public int? FinalEmailToReceivers { get; set; }
|
public FinalEmailType? FinalEmailToReceivers { get; set; }
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Gibt an, ob Erinnerungs-E-Mails aktiviert sind.
|
/// Gibt an, ob Erinnerungs-E-Mails aktiviert sind.
|
||||||
|
|||||||
@@ -256,13 +256,13 @@ public class CreateEnvelopeCommandHandler(IServiceProvider Provider, IMapper Map
|
|||||||
Language: ResolveLanguage(request.Language, selectedType?.Language, existing?.Language),
|
Language: ResolveLanguage(request.Language, selectedType?.Language, existing?.Language),
|
||||||
UseAccessCode: useAccessCode,
|
UseAccessCode: useAccessCode,
|
||||||
FinalEmailToCreator: request.FinalEmailToCreator
|
FinalEmailToCreator: request.FinalEmailToCreator
|
||||||
?? (int?)selectedType?.FinalEmailToCreator
|
?? selectedType?.FinalEmailToCreator
|
||||||
?? existing?.FinalEmailToCreator
|
?? existing?.FinalEmailToCreator
|
||||||
?? (int)FinalEmailType.No,
|
?? FinalEmailType.No,
|
||||||
FinalEmailToReceivers: request.FinalEmailToReceivers
|
FinalEmailToReceivers: request.FinalEmailToReceivers
|
||||||
?? (int?)selectedType?.FinalEmailToReceivers
|
?? selectedType?.FinalEmailToReceivers
|
||||||
?? existing?.FinalEmailToReceivers
|
?? existing?.FinalEmailToReceivers
|
||||||
?? (int)FinalEmailType.No,
|
?? FinalEmailType.No,
|
||||||
SendReminderEmails: request.SendReminderEmails
|
SendReminderEmails: request.SendReminderEmails
|
||||||
?? selectedType?.SendReminderEmails
|
?? selectedType?.SendReminderEmails
|
||||||
?? existing?.SendReminderEmails
|
?? existing?.SendReminderEmails
|
||||||
@@ -301,8 +301,8 @@ public class CreateEnvelopeCommandHandler(IServiceProvider Provider, IMapper Map
|
|||||||
EnvelopeType? Type,
|
EnvelopeType? Type,
|
||||||
string Language,
|
string Language,
|
||||||
bool UseAccessCode,
|
bool UseAccessCode,
|
||||||
int FinalEmailToCreator,
|
FinalEmailType FinalEmailToCreator,
|
||||||
int FinalEmailToReceivers,
|
FinalEmailType FinalEmailToReceivers,
|
||||||
bool SendReminderEmails,
|
bool SendReminderEmails,
|
||||||
int FirstReminderDays,
|
int FirstReminderDays,
|
||||||
int ReminderIntervalDays,
|
int ReminderIntervalDays,
|
||||||
|
|||||||
@@ -128,10 +128,10 @@ namespace EnvelopeGenerator.Domain.Entities
|
|||||||
public bool? UseAccessCode { get; set; }
|
public bool? UseAccessCode { get; set; }
|
||||||
|
|
||||||
[Column("FINAL_EMAIL_TO_CREATOR")]
|
[Column("FINAL_EMAIL_TO_CREATOR")]
|
||||||
public int? FinalEmailToCreator { get; set; }
|
public FinalEmailType? FinalEmailToCreator { get; set; }
|
||||||
|
|
||||||
[Column("FINAL_EMAIL_TO_RECEIVERS")]
|
[Column("FINAL_EMAIL_TO_RECEIVERS")]
|
||||||
public int? FinalEmailToReceivers { get; set; }
|
public FinalEmailType? FinalEmailToReceivers { get; set; }
|
||||||
|
|
||||||
[Column("EXPIRES_WHEN_DAYS")]
|
[Column("EXPIRES_WHEN_DAYS")]
|
||||||
public int? ExpiresWhenDays { get; set; }
|
public int? ExpiresWhenDays { get; set; }
|
||||||
|
|||||||
@@ -439,8 +439,8 @@
|
|||||||
private string _language = "de-DE";
|
private string _language = "de-DE";
|
||||||
private bool _useAccessCode;
|
private bool _useAccessCode;
|
||||||
private bool _tfaEnabled;
|
private bool _tfaEnabled;
|
||||||
private int _finalEmailToCreator = (int)FinalEmailType.No;
|
private FinalEmailType _finalEmailToCreator = FinalEmailType.No;
|
||||||
private int _finalEmailToReceivers = (int)FinalEmailType.No;
|
private FinalEmailType _finalEmailToReceivers = FinalEmailType.No;
|
||||||
private bool _sendReminderEmails;
|
private bool _sendReminderEmails;
|
||||||
private int _firstReminderDays;
|
private int _firstReminderDays;
|
||||||
private int _reminderIntervalDays;
|
private int _reminderIntervalDays;
|
||||||
@@ -1097,8 +1097,8 @@
|
|||||||
_language = "de-DE";
|
_language = "de-DE";
|
||||||
_useAccessCode = false;
|
_useAccessCode = false;
|
||||||
_tfaEnabled = false;
|
_tfaEnabled = false;
|
||||||
_finalEmailToCreator = (int)FinalEmailType.No;
|
_finalEmailToCreator = FinalEmailType.No;
|
||||||
_finalEmailToReceivers = (int)FinalEmailType.No;
|
_finalEmailToReceivers = FinalEmailType.No;
|
||||||
_sendReminderEmails = false;
|
_sendReminderEmails = false;
|
||||||
_firstReminderDays = 0;
|
_firstReminderDays = 0;
|
||||||
_reminderIntervalDays = 0;
|
_reminderIntervalDays = 0;
|
||||||
|
|||||||
@@ -9,8 +9,8 @@ public sealed record CreateEnvelopeWizardResult(
|
|||||||
string Language,
|
string Language,
|
||||||
bool UseAccessCode,
|
bool UseAccessCode,
|
||||||
bool TFAEnabled,
|
bool TFAEnabled,
|
||||||
int FinalEmailToCreator,
|
FinalEmailType FinalEmailToCreator,
|
||||||
int FinalEmailToReceivers,
|
FinalEmailType FinalEmailToReceivers,
|
||||||
bool SendReminderEmails,
|
bool SendReminderEmails,
|
||||||
int FirstReminderDays,
|
int FirstReminderDays,
|
||||||
int ReminderIntervalDays,
|
int ReminderIntervalDays,
|
||||||
|
|||||||
@@ -696,8 +696,8 @@
|
|||||||
string _language = "de-DE";
|
string _language = "de-DE";
|
||||||
bool _useAccessCode;
|
bool _useAccessCode;
|
||||||
bool _tfaEnabled;
|
bool _tfaEnabled;
|
||||||
int _finalEmailToCreator = (int)FinalEmailType.No;
|
FinalEmailType _finalEmailToCreator = FinalEmailType.No;
|
||||||
int _finalEmailToReceivers = (int)FinalEmailType.No;
|
FinalEmailType _finalEmailToReceivers = FinalEmailType.No;
|
||||||
bool _sendReminderEmails;
|
bool _sendReminderEmails;
|
||||||
int _firstReminderDays;
|
int _firstReminderDays;
|
||||||
int _reminderIntervalDays;
|
int _reminderIntervalDays;
|
||||||
|
|||||||
@@ -50,8 +50,8 @@ public sealed record CreateEnvelopeBootstrapPayload(
|
|||||||
string Language,
|
string Language,
|
||||||
bool UseAccessCode,
|
bool UseAccessCode,
|
||||||
bool TFAEnabled,
|
bool TFAEnabled,
|
||||||
int FinalEmailToCreator,
|
FinalEmailType FinalEmailToCreator,
|
||||||
int FinalEmailToReceivers,
|
FinalEmailType FinalEmailToReceivers,
|
||||||
bool SendReminderEmails,
|
bool SendReminderEmails,
|
||||||
int FirstReminderDays,
|
int FirstReminderDays,
|
||||||
int ReminderIntervalDays,
|
int ReminderIntervalDays,
|
||||||
|
|||||||
@@ -1,11 +1,12 @@
|
|||||||
using EnvelopeGenerator.Domain.Entities;
|
using EnvelopeGenerator.Domain.Entities;
|
||||||
using EnvelopeGenerator.Application.Common.Dto;
|
using EnvelopeGenerator.Application.Common.Dto;
|
||||||
using EnvelopeGenerator.Application.Common.Interfaces.Services;
|
using EnvelopeGenerator.Application.Common.Interfaces.Services;
|
||||||
|
using EnvelopeGenerator.Domain.Constants;
|
||||||
|
|
||||||
namespace EnvelopeGenerator.Web.Controllers.Test;
|
namespace EnvelopeGenerator.Web.Controllers.Test;
|
||||||
|
|
||||||
[Obsolete("Use MediatR")]
|
[Obsolete("Use MediatR")]
|
||||||
public class TestEnvelopeTypeController : TestControllerBase<IEnvelopeTypeService, EnvelopeTypeDefaultsDto, EnvelopeTypeDefaults, int>
|
public class TestEnvelopeTypeController : TestControllerBase<IEnvelopeTypeService, EnvelopeTypeDefaultsDto, EnvelopeTypeDefaults, EnvelopeType>
|
||||||
{
|
{
|
||||||
public TestEnvelopeTypeController(ILogger<TestEnvelopeTypeController> logger, IEnvelopeTypeService service) : base(logger, service)
|
public TestEnvelopeTypeController(ILogger<TestEnvelopeTypeController> logger, IEnvelopeTypeService service) : base(logger, service)
|
||||||
{
|
{
|
||||||
|
|||||||
Reference in New Issue
Block a user