AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Refactor envelope ID retrieval and error handling

Browse Source 
Replaced hardcoded `envelopeId` with dynamic retrieval from
user claims. Reintroduced and updated error handling logic
to validate the `envelopeId` and log detailed errors when
parsing fails. Improved robustness by returning a 500 error
for invalid or missing envelope claims.
This commit is contained in:
tekh
2026-05-31 16:15:00 +02:00
parent 21c6b65318
commit a668dfa3eb
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
EnvelopeGenerator.API/Controllers/DocumentController.cs
View File

@@ -70,19 +70,17 @@ public class DocumentController(IMediator mediator, IAuthorizationService authSe
[HttpGet("{envelopeKey}")] [HttpGet("{envelopeKey}")]
public async Task<IActionResult> GetDocumentOfReceiver(string envelopeKey, CancellationToken cancel) public async Task<IActionResult> GetDocumentOfReceiver(string envelopeKey, CancellationToken cancel)
{ {
var envelopeId = 2071; var envelopeIdStr = User.FindFirst(EnvelopeClaimNames.EnvelopeId)?.Value;
//var envelopeIdStr = User.FindFirst(EnvelopeClaimNames.EnvelopeId)?.Value; if (!int.TryParse(envelopeIdStr, out int envelopeId))
{
logger.LogError(
"Inner service error: Failed to parse Envelope ID from claims. Claim '{ClaimName}' had an invalid or missing value: '{ClaimValue}'.",
EnvelopeClaimNames.EnvelopeId,
envelopeIdStr ?? "null");
//if (!int.TryParse(envelopeIdStr, out int envelopeId)) return StatusCode(StatusCodes.Status500InternalServerError, "Inner service error: Invalid envelope claim.");
//{ }
// logger.LogError(
// "Inner service error: Failed to parse Envelope ID from claims. Claim '{ClaimName}' had an invalid or missing value: '{ClaimValue}'.",
// EnvelopeClaimNames.EnvelopeId,
// envelopeIdStr ?? "null");
// return StatusCode(StatusCodes.Status500InternalServerError, "Inner service error: Invalid envelope claim.");
//}
var senderDoc = await mediator.Send(new ReadDocumentQuery() { EnvelopeId = envelopeId }, cancel); var senderDoc = await mediator.Send(new ReadDocumentQuery() { EnvelopeId = envelopeId }, cancel);