AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactor(ViewControllerBase): remvoe sanitzer

Browse Source
This commit is contained in:
tekh 2025-08-23 00:17:59 +02:00
parent d390802305
commit a080aaec95
3 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
EnvelopeGenerator.Web/Controllers/HomeController.cs
View File

@ -42,7 +42,7 @@ public class HomeController : ViewControllerBase
private readonly IMediator _mediator; private readonly IMediator _mediator;
[Obsolete("Use MediatR")] [Obsolete("Use MediatR")]
public HomeController(ILogger<HomeController> logger, IEnvelopeReceiverService envelopeReceiverService, IEnvelopeHistoryService historyService, IStringLocalizer<Resource> localizer, IConfiguration configuration, HtmlSanitizer sanitizer, Cultures cultures, IEnvelopeMailService envelopeMailService, IEnvelopeReceiverReadOnlyService readOnlyService, IAuthenticator authenticator, IReceiverService receiverService, IEnvelopeSmsHandler envelopeSmsService, IMediator mediator) : base(logger, sanitizer, cultures, localizer) public HomeController(ILogger<HomeController> logger, IEnvelopeReceiverService envelopeReceiverService, IEnvelopeHistoryService historyService, IStringLocalizer<Resource> localizer, IConfiguration configuration, Cultures cultures, IEnvelopeMailService envelopeMailService, IEnvelopeReceiverReadOnlyService readOnlyService, IAuthenticator authenticator, IReceiverService receiverService, IEnvelopeSmsHandler envelopeSmsService, IMediator mediator) : base(logger, cultures, localizer)
{ {
_envRcvService = envelopeReceiverService; _envRcvService = envelopeReceiverService;
_historyService = historyService; _historyService = historyService;
@ -70,8 +70,6 @@ public class HomeController : ViewControllerBase
{ {
try try
{ {
envelopeReceiverId = _sanitizer.Sanitize(envelopeReceiverId);
if (!envelopeReceiverId.TryDecode(out var decoded)) if (!envelopeReceiverId.TryDecode(out var decoded))
{ {
Response.StatusCode = StatusCodes.Status401Unauthorized; Response.StatusCode = StatusCodes.Status401Unauthorized;
@ -148,8 +146,6 @@ public class HomeController : ViewControllerBase
try try
{ {
ViewData["EnvelopeKey"] = envelopeReceiverId; ViewData["EnvelopeKey"] = envelopeReceiverId;
envelopeReceiverId = _sanitizer.Sanitize(envelopeReceiverId);
(string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId(); (string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId();
if (uuid is null || signature is null) if (uuid is null || signature is null)
@ -306,8 +302,6 @@ public class HomeController : ViewControllerBase
try try
{ {
ViewData["EnvelopeKey"] = envelopeReceiverId; ViewData["EnvelopeKey"] = envelopeReceiverId;
envelopeReceiverId = _sanitizer.Sanitize(envelopeReceiverId);
(string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId(); (string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId();
if (uuid is null || signature is null) if (uuid is null || signature is null)
@ -380,7 +374,6 @@ public class HomeController : ViewControllerBase
{ {
try try
{ {
envelopeReceiverId = _sanitizer.Sanitize(envelopeReceiverId);
return await _envRcvService.IsExisting(envelopeReceiverId: envelopeReceiverId).ThenAsync( return await _envRcvService.IsExisting(envelopeReceiverId: envelopeReceiverId).ThenAsync(
SuccessAsync: (Func<bool, Task<IActionResult>>)(async isExisting => SuccessAsync: (Func<bool, Task<IActionResult>>)(async isExisting =>
{ {
@ -415,8 +408,6 @@ public class HomeController : ViewControllerBase
{ {
try try
{ {
envelopeReceiverId = _sanitizer.Sanitize(envelopeReceiverId);
await HttpContext.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme); await HttpContext.SignOutAsync(CookieAuthenticationDefaults.AuthenticationScheme);
return await _envRcvService.ReadByEnvelopeReceiverIdAsync(envelopeReceiverId).ThenAsync( return await _envRcvService.ReadByEnvelopeReceiverIdAsync(envelopeReceiverId).ThenAsync(
SuccessAsync: async (er) => SuccessAsync: async (er) =>
@ -445,8 +436,6 @@ public class HomeController : ViewControllerBase
{ {
try try
{ {
readOnlyKey = _sanitizer.Sanitize(readOnlyKey);
// check if the readOnlyId is valid // check if the readOnlyId is valid
if (!readOnlyKey.TryDecode(out var decodedKeys) || decodedKeys.GetEncodeType() != EncodeType.EnvelopeReceiverReadOnly) if (!readOnlyKey.TryDecode(out var decodedKeys) || decodedKeys.GetEncodeType() != EncodeType.EnvelopeReceiverReadOnly)
{ {

3
EnvelopeGenerator.Web/Controllers/TFARegController.cs
View File

@ -26,7 +26,7 @@ public class TFARegController : ViewControllerBase
private readonly TFARegParams _params; private readonly TFARegParams _params;
[Obsolete("Use MediatR")] [Obsolete("Use MediatR")]
public TFARegController(ILogger<TFARegController> logger, HtmlSanitizer sanitizer, Cultures cultures, IStringLocalizer<Resource> localizer, IEnvelopeReceiverService erService, IAuthenticator authenticator, IReceiverService receiverService, IOptions<TFARegParams> tfaRegParamsOptions) : base(logger, sanitizer, cultures, localizer) public TFARegController(ILogger<TFARegController> logger, Cultures cultures, IStringLocalizer<Resource> localizer, IEnvelopeReceiverService erService, IAuthenticator authenticator, IReceiverService receiverService, IOptions<TFARegParams> tfaRegParamsOptions) : base(logger, cultures, localizer)
{ {
_envRcvService = erService; _envRcvService = erService;
_authenticator = authenticator; _authenticator = authenticator;
@ -42,7 +42,6 @@ public class TFARegController : ViewControllerBase
{ {
try try
{ {
envelopeReceiverId = _sanitizer.Sanitize(envelopeReceiverId);
(string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId(); (string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId();
if (uuid is null || signature is null) if (uuid is null || signature is null)

4
EnvelopeGenerator.Web/Controllers/ViewControllerBase.cs
View File

@ -9,14 +9,12 @@ namespace EnvelopeGenerator.Web.Controllers;
public class ViewControllerBase : Controller public class ViewControllerBase : Controller
{ {
protected readonly ILogger _logger; protected readonly ILogger _logger;
protected readonly HtmlSanitizer _sanitizer;
protected readonly Cultures _cultures; protected readonly Cultures _cultures;
protected readonly IStringLocalizer<Resource> _localizer; protected readonly IStringLocalizer<Resource> _localizer;
public ViewControllerBase(ILogger logger, HtmlSanitizer sanitizer, Cultures cultures, IStringLocalizer<Resource> localizer) public ViewControllerBase(ILogger logger, Cultures cultures, IStringLocalizer<Resource> localizer)
{ {
_logger = logger; _logger = logger;
_sanitizer = sanitizer;
_cultures = cultures; _cultures = cultures;
_localizer = localizer; _localizer = localizer;
} }