AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove client-side SigningTime handling

Browse Source 
The `SigningTime` property has been removed from the `PdfSignOptionsDto` class and related client-side input handling. It is now set automatically on the server side based on the `UseUtcSigningTime` configuration (`UtcNow` or local time).

Updated the `PdfDigitalSignatureService` to always set `SigningTime` server-side, ensuring consistent and deterministic behavior. Removed `SigningTime` from the `PdfSignatureController` and adjusted the logic to exclude it from the `signOptions` object.

Updated the `README.md` to reflect these changes, clarifying that `SigningTime` is now server-side only. These changes improve security and simplify client integration.
This commit is contained in:
tekh
2026-10-14 14:49:15 +02:00
parent 5194d638ac
commit 816bbce9c6
4 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
EnvelopeGenerator.Application/Common/Dto/PdfSignOptionsDto.cs
View File

@@ -9,7 +9,6 @@ public sealed record PdfSignOptionsDto
public string? Reason { get; set; } public string? Reason { get; set; }
public string? Location { get; set; } public string? Location { get; set; }
public string? ContactInfo { get; set; } public string? ContactInfo { get; set; }
public DateTimeOffset? SigningTime { get; set; }
public string? ApplicationName { get; set; } public string? ApplicationName { get; set; }
public PdfSignatureCertificationLevel? CertificationLevel { get; set; } public PdfSignatureCertificationLevel? CertificationLevel { get; set; }
} }

1
EnvelopeGenerator.Infrastructure.Crypt/README.md
View File

@@ -338,6 +338,7 @@ Aktueller Standard:
- `UUID` kommt aus Sign-Input (nullable string). Wenn ungeltig/leer -> neue Guid wird erzeugt. - `UUID` kommt aus Sign-Input (nullable string). Wenn ungeltig/leer -> neue Guid wird erzeugt.
- `Reason` wird intern angereichert mit strukturiertem Meta (`SFMETA:v1`). - `Reason` wird intern angereichert mit strukturiertem Meta (`SFMETA:v1`).
- `ApplicationName` ist rein serverseitig aus `appsettings` gesetzt. - `ApplicationName` ist rein serverseitig aus `appsettings` gesetzt.
- `SigningTime` ist rein serverseitig und wird automatisch gesetzt (`UseUtcSigningTime=true` => `UtcNow`, sonst lokale Zeit).
- `CertificationLevel` wird im Controller serverseitig gesetzt (`FormFillingAndAnnotations`), nicht vom Client. - `CertificationLevel` wird im Controller serverseitig gesetzt (`FormFillingAndAnnotations`), nicht vom Client.
Damit ist das Verhalten deterministisch und manipulationsaermer fuer Integrationsclients. Damit ist das Verhalten deterministisch und manipulationsaermer fuer Integrationsclients.

2
EnvelopeGenerator.Infrastructure.Crypt/Services/PdfDigitalSignatureService.cs
View File

@@ -43,7 +43,7 @@ public sealed class PdfDigitalSignatureService(IOptions<Pkcs11Options> options)
Reason = reasonWithMeta, Reason = reasonWithMeta,
Location = request.Location, Location = request.Location,
ContactInfo = request.ContactInfo, ContactInfo = request.ContactInfo,
SigningTime = request.SigningTime ?? (pkcs11Options.UseUtcSigningTime ? DateTimeOffset.UtcNow : DateTimeOffset.Now), SigningTime = pkcs11Options.UseUtcSigningTime ? DateTimeOffset.UtcNow : DateTimeOffset.Now,
ApplicationName = pkcs11Options.ApplicationName, ApplicationName = pkcs11Options.ApplicationName,
CertificationLevel = ToDevExpressCertificationLevel(request.CertificationLevel) CertificationLevel = ToDevExpressCertificationLevel(request.CertificationLevel)
?? ToDevExpressCertificationLevel(pkcs11Options.DefaultCertificationLevel) ?? ToDevExpressCertificationLevel(pkcs11Options.DefaultCertificationLevel)

2
EnvelopeGenerator.Server/EnvelopeGenerator.Server/Controllers/PdfSignatureController.cs
View File

@@ -18,7 +18,6 @@ public class PdfSignatureController(IPdfDigitalSignatureService signatureService
public string? Reason { get; set; } public string? Reason { get; set; }
public string? Location { get; set; } public string? Location { get; set; }
public string? ContactInfo { get; set; } public string? ContactInfo { get; set; }
public DateTimeOffset? SigningTime { get; set; }
} }
public sealed class CheckPdfSignatureForm public sealed class CheckPdfSignatureForm
@@ -54,7 +53,6 @@ public class PdfSignatureController(IPdfDigitalSignatureService signatureService
Reason = request.Reason, Reason = request.Reason,
Location = request.Location, Location = request.Location,
ContactInfo = request.ContactInfo, ContactInfo = request.ContactInfo,
SigningTime = request.SigningTime,
CertificationLevel = PdfSignatureCertificationLevel.FormFillingAndAnnotations CertificationLevel = PdfSignatureCertificationLevel.FormFillingAndAnnotations
}; };