Refactor EnvelopeReceiverService and update methods

- Changed return type of `ReadLastUsedReceiverNameByMailAsync` to non-nullable string.
- Marked `EnvelopeReceiverService` as obsolete; suggested using MediatR.
- Added new methods for enhanced functionality: `ReadBySignatureAsync`, `ReadByUuidAsync`, `ReadAccessCodeByUuidAsync`, `ReadByUuidSignatureAsync`, `ReadWithSecretByUuidSignatureAsync`, `ReadByEnvelopeReceiverIdAsync`, `VerifyAccessCodeAsync`, and `IsExisting`.
- Improved null handling in `ReadAccessCodeByUuidAsync` and added localized failure messages.
- Overloaded `VerifyAccessCodeAsync` to accept `envelopeReceiverId`.
- Introduced `SendSmsAsync` for sending SMS messages.
- Added `ReadWithSecretByUuidAsync` method (not yet implemented).
- Enhanced error handling in `ReadAccessCodeByIdAsync`.
- Updated `ReadByUsernameAsync` to support additional filtering parameters.

EnvelopeGenerator.Application/Contracts/Services/IEnvelopeReceiverService.cs

@@ -129,7 +129,7 @@ public interface IEnvelopeReceiverService : IBasicCRUDService<EnvelopeReceiverDt
     /// <param name="id"></param>
     /// <param name="signature"></param>
     /// <returns></returns>
-    Task<DataResult<string?>> ReadLastUsedReceiverNameByMailAsync(string? mail = null, int? id = null, string? signature = null);
+    Task<DataResult<string>> ReadLastUsedReceiverNameByMailAsync(string? mail = null, int? id = null, string? signature = null);
 
     /// <summary>
     /// 

EnvelopeGenerator.Application/Services/EnvelopeReceiverService.cs

@@ -15,12 +15,23 @@ using EnvelopeGenerator.Application.Receivers.Queries.Read;
 
 namespace EnvelopeGenerator.Application.Services;
 
+/// <summary>
+/// 
+/// </summary>
+[Obsolete("Use MediatR")]
 public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverRepository, EnvelopeReceiverDto, EnvelopeReceiver, (int Envelope, int Receiver)>, IEnvelopeReceiverService
 {
     private readonly IStringLocalizer<Resource> _localizer;
 
     private readonly ISmsSender _smsSender;
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="repository"></param>
+    /// <param name="localizer"></param>
+    /// <param name="mapper"></param>
+    /// <param name="smsSender"></param>
     public EnvelopeReceiverService(IEnvelopeReceiverRepository repository, IStringLocalizer<Resource> localizer, IMapper mapper, ISmsSender smsSender)
         : base(repository, mapper)
     {
@@ -28,24 +39,59 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         _smsSender = smsSender;
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="signature"></param>
+    /// <param name="withEnvelope"></param>
+    /// <param name="withReceiver"></param>
+    /// <param name="readOnly"></param>
+    /// <returns></returns>
     public async Task<DataResult<IEnumerable<EnvelopeReceiverDto>>> ReadBySignatureAsync(string signature, bool withEnvelope = false, bool withReceiver = true, bool readOnly = true)
     {
         var env_rcvs = await _repository.ReadBySignatureAsync(signature: signature, withEnvelope: withEnvelope, withReceiver: withReceiver, readOnly: readOnly);
         return Result.Success(_mapper.Map<IEnumerable<EnvelopeReceiverDto>>(env_rcvs));
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="uuid"></param>
+    /// <param name="withEnvelope"></param>
+    /// <param name="withReceiver"></param>
+    /// <param name="readOnly"></param>
+    /// <returns></returns>
     public async Task<DataResult<IEnumerable<EnvelopeReceiverDto>>> ReadByUuidAsync(string uuid, bool withEnvelope = true, bool withReceiver = false, bool readOnly = true)
     {
         var env_rcvs = await _repository.ReadByUuidAsync(uuid: uuid, withEnvelope: withEnvelope, withReceiver: withReceiver, readOnly: readOnly);
         return Result.Success(_mapper.Map<IEnumerable<EnvelopeReceiverDto>>(env_rcvs));
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="uuid"></param>
+    /// <param name="withEnvelope"></param>
+    /// <param name="withReceiver"></param>
+    /// <returns></returns>
     public async Task<DataResult<IEnumerable<string?>>> ReadAccessCodeByUuidAsync(string uuid, bool withEnvelope = false, bool withReceiver = true)
     {
         var env_rcvs = await _repository.ReadByUuidAsync(uuid: uuid, withEnvelope: withEnvelope, withReceiver: withReceiver);
-        return Result.Success(env_rcvs.Select(er => er.AccessCode));
+        if( env_rcvs is null || !env_rcvs.Any())
+            return Result.Fail<IEnumerable<string?>>()
+                .Message(_localizer[Key.EnvelopeReceiverNotFound]);
+        return Result.Success(env_rcvs.Select(er => er.AccessCode) ?? Enumerable.Empty<string?>());
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="uuid"></param>
+    /// <param name="signature"></param>
+    /// <param name="withEnvelope"></param>
+    /// <param name="withReceiver"></param>
+    /// <param name="readOnly"></param>
+    /// <returns></returns>
     public async Task<DataResult<EnvelopeReceiverDto>> ReadByUuidSignatureAsync(string uuid, string signature, bool withEnvelope = true, bool withReceiver = true, bool readOnly = true)
     {
         var env_rcv = await _repository.ReadByUuidSignatureAsync(uuid: uuid, signature: signature, withEnvelope: withEnvelope, withReceiver: withReceiver, readOnly: readOnly);
@@ -56,6 +102,15 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return Result.Success(_mapper.Map<EnvelopeReceiverDto>(env_rcv));
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="uuid"></param>
+    /// <param name="signature"></param>
+    /// <param name="withEnvelope"></param>
+    /// <param name="withReceiver"></param>
+    /// <param name="readOnly"></param>
+    /// <returns></returns>
     public async Task<DataResult<EnvelopeReceiverSecretDto>> ReadWithSecretByUuidSignatureAsync(string uuid, string signature, bool withEnvelope = true, bool withReceiver = true, bool readOnly = true)
     {
         var env_rcv = await _repository.ReadByUuidSignatureAsync(uuid: uuid, signature: signature, withEnvelope: withEnvelope, withReceiver: withReceiver, readOnly: readOnly);
@@ -66,6 +121,14 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return Result.Success(_mapper.Map<EnvelopeReceiverSecretDto>(env_rcv));
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="envelopeReceiverId"></param>
+    /// <param name="withEnvelope"></param>
+    /// <param name="withReceiver"></param>
+    /// <param name="readOnly"></param>
+    /// <returns></returns>
     public async Task<DataResult<EnvelopeReceiverDto>> ReadByEnvelopeReceiverIdAsync(string envelopeReceiverId, bool withEnvelope = true, bool withReceiver = true, bool readOnly = true)
     {
         (string? uuid, string? signature)  = envelopeReceiverId.DecodeEnvelopeReceiverId();
@@ -80,6 +143,13 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return await ReadByUuidSignatureAsync(uuid: uuid, signature: signature, withEnvelope: withEnvelope, withReceiver: withReceiver, readOnly: readOnly);
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="uuid"></param>
+    /// <param name="signature"></param>
+    /// <param name="accessCode"></param>
+    /// <returns></returns>
     public async Task<DataResult<bool>> VerifyAccessCodeAsync(string uuid, string signature, string accessCode)
     {
         var er = await _repository.ReadByUuidSignatureAsync(uuid: uuid, signature: signature);
@@ -106,6 +176,12 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
             return Result.Success(true);
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="envelopeReceiverId"></param>
+    /// <param name="accessCode"></param>
+    /// <returns></returns>
     public async Task<DataResult<bool>> VerifyAccessCodeAsync(string envelopeReceiverId, string accessCode)
     {
         (string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId();
@@ -120,6 +196,11 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return await VerifyAccessCodeAsync(uuid: uuid, signature: signature, accessCode: accessCode);
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="envelopeReceiverId"></param>
+    /// <returns></returns>
     public async Task<DataResult<bool>> IsExisting(string envelopeReceiverId)
     {
         (string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId();
@@ -131,14 +212,30 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return Result.Success(count > 0);
     }
 
-		public async Task<DataResult<string>> ReadAccessCodeByIdAsync(int envelopeId, int receiverId)
+    /// <summary>
-		{
+    /// 
-        var code = await _repository.ReadAccessCodeByIdAsync(envelopeId: envelopeId, receiverId: receiverId);
+    /// </summary>
-        return code is null ? 
+    /// <param name="envelopeId"></param>
-            Result.Fail<string>().Notice(LogLevel.Error, Flag.DataIntegrityIssue, $"Access code is null. Envelope ID is {envelopeId} and receiver ID {receiverId}")
+    /// <param name="receiverId"></param>
-            : Result.Success(code);
+    /// <returns></returns>
-		}
+	public async Task<DataResult<string>> ReadAccessCodeByIdAsync(int envelopeId, int receiverId)
+	{
+    var code = await _repository.ReadAccessCodeByIdAsync(envelopeId: envelopeId, receiverId: receiverId);
+    return code is null ? 
+        Result.Fail<string>().Notice(LogLevel.Error, Flag.DataIntegrityIssue, $"Access code is null. Envelope ID is {envelopeId} and receiver ID {receiverId}")
+        : Result.Success(code);
+	}
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="username"></param>
+    /// <param name="min_status"></param>
+    /// <param name="max_status"></param>
+    /// <param name="envelopeQuery"></param>
+    /// <param name="receiverQuery"></param>
+    /// <param name="ignore_statuses"></param>
+    /// <returns></returns>
     public async Task<DataResult<IEnumerable<EnvelopeReceiverDto>>> ReadByUsernameAsync(string username, int? min_status = null, int? max_status = null, EnvelopeQuery? envelopeQuery = null, ReadReceiverQuery? receiverQuery = null, params int[] ignore_statuses)
     {
         var er_list = await _repository.ReadByUsernameAsync(username: username, min_status: min_status, max_status: max_status, ignore_statuses: ignore_statuses);
@@ -162,12 +259,25 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return Result.Success(dto_list);
     }
 
-    public async Task<DataResult<string?>> ReadLastUsedReceiverNameByMailAsync(string? mail = null, int? id = null, string? signature = null)
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="mail"></param>
+    /// <param name="id"></param>
+    /// <param name="signature"></param>
+    /// <returns></returns>
+    public async Task<DataResult<string>> ReadLastUsedReceiverNameByMailAsync(string? mail = null, int? id = null, string? signature = null)
     {
         var er = await _repository.ReadLastByReceiverAsync(mail, id, signature);
-        return er is null ? Result.Fail<string?>().Notice(LogLevel.None, Flag.NotFound) : Result.Success(er.Name);
+        return er is null ? Result.Fail<string>().Notice(LogLevel.None, Flag.NotFound) : Result.Success(er.Name);
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="envelopeReceiverId"></param>
+    /// <param name="message"></param>
+    /// <returns></returns>
     public async Task<DataResult<SmsResponse>> SendSmsAsync(string envelopeReceiverId, string message)
     {
         (string? uuid, string? signature) = envelopeReceiverId.DecodeEnvelopeReceiverId();
@@ -194,6 +304,12 @@ public class EnvelopeReceiverService : BasicCRUDService<IEnvelopeReceiverReposit
         return Result.Success(res);
     }
 
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="uuid"></param>
+    /// <returns></returns>
+    /// <exception cref="NotImplementedException"></exception>
     public Task<DataResult<IEnumerable<EnvelopeReceiverSecretDto>>> ReadWithSecretByUuidAsync(string uuid)
     {
         throw new NotImplementedException();