From 728385b70a6a1d04fd39310e06e12e37b3cac5b5 Mon Sep 17 00:00:00 2001 From: Developer 02 Date: Tue, 1 Oct 2024 17:25:50 +0200 Subject: [PATCH] feat(extensions): created extensions project. - Moved encoding extensions from application to extensions project to increase the abstraction --- .../EnvelopeGenerator.Application.csproj | 1 + .../Services/EnvelopeMailService.cs | 1 + .../Services/EnvelopeReceiverService.cs | 1 + .../EncodeType.cs | 2 +- .../EncodingExtensions.cs | 4 ++-- .../EnvelopeGenerator.Extensions.csproj | 13 +++++++++++++ .../Controllers/DocumentController.cs | 1 + .../Controllers/EnvelopeController.cs | 2 +- EnvelopeGenerator.Web/Controllers/HomeController.cs | 2 +- .../Controllers/Test/TestEnvelopeController.cs | 4 ++-- .../Test/TestEnvelopeReceiverController.cs | 6 +++--- EnvelopeGenerator.Web/EnvelopeGenerator.Web.csproj | 1 + EnvelopeGenerator.sln | 6 ++++++ 13 files changed, 34 insertions(+), 10 deletions(-) rename {EnvelopeGenerator.Application => EnvelopeGenerator.Extensions}/EncodeType.cs (70%) rename EnvelopeGenerator.Application/EnvelopeGeneratorExtensions.cs => EnvelopeGenerator.Extensions/EncodingExtensions.cs (98%) create mode 100644 EnvelopeGenerator.Extensions/EnvelopeGenerator.Extensions.csproj diff --git a/EnvelopeGenerator.Application/EnvelopeGenerator.Application.csproj b/EnvelopeGenerator.Application/EnvelopeGenerator.Application.csproj index 5ca8bdf4..f1267868 100644 --- a/EnvelopeGenerator.Application/EnvelopeGenerator.Application.csproj +++ b/EnvelopeGenerator.Application/EnvelopeGenerator.Application.csproj @@ -22,6 +22,7 @@ + diff --git a/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs b/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs index 296ad932..46d2d8ec 100644 --- a/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs +++ b/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs @@ -11,6 +11,7 @@ using Microsoft.Extensions.Localization; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Options; using static EnvelopeGenerator.Common.Constants; +using EnvelopeGenerator.Extensions; namespace EnvelopeGenerator.Application.Services { diff --git a/EnvelopeGenerator.Application/Services/EnvelopeReceiverService.cs b/EnvelopeGenerator.Application/Services/EnvelopeReceiverService.cs index bd09cac4..12b5ea11 100644 --- a/EnvelopeGenerator.Application/Services/EnvelopeReceiverService.cs +++ b/EnvelopeGenerator.Application/Services/EnvelopeReceiverService.cs @@ -8,6 +8,7 @@ using EnvelopeGenerator.Domain.Entities; using EnvelopeGenerator.Infrastructure.Contracts; using Microsoft.Extensions.Localization; using Microsoft.Extensions.Logging; +using EnvelopeGenerator.Extensions; namespace EnvelopeGenerator.Application.Services { diff --git a/EnvelopeGenerator.Application/EncodeType.cs b/EnvelopeGenerator.Extensions/EncodeType.cs similarity index 70% rename from EnvelopeGenerator.Application/EncodeType.cs rename to EnvelopeGenerator.Extensions/EncodeType.cs index 677073df..41c706a7 100644 --- a/EnvelopeGenerator.Application/EncodeType.cs +++ b/EnvelopeGenerator.Extensions/EncodeType.cs @@ -1,4 +1,4 @@ -namespace EnvelopeGenerator.Application +namespace EnvelopeGenerator.Extensions { public enum EncodeType { diff --git a/EnvelopeGenerator.Application/EnvelopeGeneratorExtensions.cs b/EnvelopeGenerator.Extensions/EncodingExtensions.cs similarity index 98% rename from EnvelopeGenerator.Application/EnvelopeGeneratorExtensions.cs rename to EnvelopeGenerator.Extensions/EncodingExtensions.cs index 51daee31..f35c07d5 100644 --- a/EnvelopeGenerator.Application/EnvelopeGeneratorExtensions.cs +++ b/EnvelopeGenerator.Extensions/EncodingExtensions.cs @@ -1,12 +1,12 @@ using Microsoft.Extensions.Logging; using System.Text; -namespace EnvelopeGenerator.Application +namespace EnvelopeGenerator.Extensions { /// /// Provides extension methods for decoding and extracting information from an envelope receiver ID. /// - public static class EnvelopeGeneratorExtensions + public static class EncodingExtensions { /// /// Validates whether a given string is a correctly formatted Base-64 encoded string. diff --git a/EnvelopeGenerator.Extensions/EnvelopeGenerator.Extensions.csproj b/EnvelopeGenerator.Extensions/EnvelopeGenerator.Extensions.csproj new file mode 100644 index 00000000..2f15281d --- /dev/null +++ b/EnvelopeGenerator.Extensions/EnvelopeGenerator.Extensions.csproj @@ -0,0 +1,13 @@ + + + + net7.0 + enable + enable + + + + + + + diff --git a/EnvelopeGenerator.Web/Controllers/DocumentController.cs b/EnvelopeGenerator.Web/Controllers/DocumentController.cs index c418a143..c6c309a9 100644 --- a/EnvelopeGenerator.Web/Controllers/DocumentController.cs +++ b/EnvelopeGenerator.Web/Controllers/DocumentController.cs @@ -4,6 +4,7 @@ using EnvelopeGenerator.Web.Services; using EnvelopeGenerator.Application.Contracts; using Microsoft.AspNetCore.Authorization; using EnvelopeGenerator.Application; +using EnvelopeGenerator.Extensions; namespace EnvelopeGenerator.Web.Controllers { diff --git a/EnvelopeGenerator.Web/Controllers/EnvelopeController.cs b/EnvelopeGenerator.Web/Controllers/EnvelopeController.cs index 1353c8b1..1e491892 100644 --- a/EnvelopeGenerator.Web/Controllers/EnvelopeController.cs +++ b/EnvelopeGenerator.Web/Controllers/EnvelopeController.cs @@ -6,8 +6,8 @@ using EnvelopeGenerator.Web.Services; using Microsoft.AspNetCore.Authorization; using Microsoft.AspNetCore.Mvc; using System.Text.Encodings.Web; -using EnvelopeGenerator.Application.DTOs.EnvelopeHistory; using static EnvelopeGenerator.Common.Constants; +using EnvelopeGenerator.Extensions; namespace EnvelopeGenerator.Web.Controllers { diff --git a/EnvelopeGenerator.Web/Controllers/HomeController.cs b/EnvelopeGenerator.Web/Controllers/HomeController.cs index 431901e7..b5b03111 100644 --- a/EnvelopeGenerator.Web/Controllers/HomeController.cs +++ b/EnvelopeGenerator.Web/Controllers/HomeController.cs @@ -7,7 +7,7 @@ using Microsoft.AspNetCore.Mvc; using System.Security.Claims; using Microsoft.AspNetCore.Authorization; using DigitalData.Core.API; -using EnvelopeGenerator.Application; +using EnvelopeGenerator.Extensions; using Microsoft.Extensions.Localization; using DigitalData.Core.DTO; using Microsoft.AspNetCore.Localization; diff --git a/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeController.cs b/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeController.cs index acaecb9c..ea2b25f7 100644 --- a/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeController.cs +++ b/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeController.cs @@ -1,8 +1,8 @@ -using EnvelopeGenerator.Application; -using EnvelopeGenerator.Application.Contracts; +using EnvelopeGenerator.Application.Contracts; using EnvelopeGenerator.Application.DTOs; using EnvelopeGenerator.Domain.Entities; using Microsoft.AspNetCore.Mvc; +using EnvelopeGenerator.Extensions; namespace EnvelopeGenerator.Web.Controllers.Test { diff --git a/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeReceiverController.cs b/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeReceiverController.cs index 3d69a6f0..9c95ff17 100644 --- a/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeReceiverController.cs +++ b/EnvelopeGenerator.Web/Controllers/Test/TestEnvelopeReceiverController.cs @@ -1,7 +1,7 @@ using DigitalData.Core.API; using DigitalData.Core.DTO; using EnvelopeGenerator.Application.Contracts; -using EnvelopeGenerator.Application; +using EnvelopeGenerator.Extensions; using EnvelopeGenerator.Domain.Entities; using Microsoft.AspNetCore.Mvc; using EnvelopeGenerator.Application.DTOs.EnvelopeReceiver; @@ -44,8 +44,8 @@ namespace EnvelopeGenerator.Web.Controllers.Test { if (isReadOnly) { - var (Random1, ReadOnlyId, Random2) = envelopeReceiverId.DecodeEnvelopeReceiverReadOnlyId(); - return Ok(new { random = new string?[] { Random1, Random2 }, readOnlyId = ReadOnlyId }); + var readOnlyId = envelopeReceiverId.DecodeEnvelopeReceiverReadOnlyId(); + return Ok(new { readOnlyId }); } else { diff --git a/EnvelopeGenerator.Web/EnvelopeGenerator.Web.csproj b/EnvelopeGenerator.Web/EnvelopeGenerator.Web.csproj index 8fe87259..6182f451 100644 --- a/EnvelopeGenerator.Web/EnvelopeGenerator.Web.csproj +++ b/EnvelopeGenerator.Web/EnvelopeGenerator.Web.csproj @@ -71,6 +71,7 @@ + diff --git a/EnvelopeGenerator.sln b/EnvelopeGenerator.sln index 650cab96..900a5ca6 100644 --- a/EnvelopeGenerator.sln +++ b/EnvelopeGenerator.sln @@ -21,6 +21,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "EnvelopeGenerator.Applicati EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "EnvelopeGenerator.GeneratorAPI", "EnvelopeGenerator.GeneratorAPI\EnvelopeGenerator.GeneratorAPI.csproj", "{E5E12BA4-60C1-48BA-9053-0F8B62B38124}" EndProject +Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EnvelopeGenerator.Extensions", "EnvelopeGenerator.Extensions\EnvelopeGenerator.Extensions.csproj", "{47F98812-4280-4D53-B04A-2AAEEA5EBC31}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU @@ -63,6 +65,10 @@ Global {E5E12BA4-60C1-48BA-9053-0F8B62B38124}.Debug|Any CPU.Build.0 = Debug|Any CPU {E5E12BA4-60C1-48BA-9053-0F8B62B38124}.Release|Any CPU.ActiveCfg = Release|Any CPU {E5E12BA4-60C1-48BA-9053-0F8B62B38124}.Release|Any CPU.Build.0 = Release|Any CPU + {47F98812-4280-4D53-B04A-2AAEEA5EBC31}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {47F98812-4280-4D53-B04A-2AAEEA5EBC31}.Debug|Any CPU.Build.0 = Debug|Any CPU + {47F98812-4280-4D53-B04A-2AAEEA5EBC31}.Release|Any CPU.ActiveCfg = Release|Any CPU + {47F98812-4280-4D53-B04A-2AAEEA5EBC31}.Release|Any CPU.Build.0 = Release|Any CPU EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE