AppStd/EnvelopeGenerator
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Rename DefaultApplicationName to ApplicationName

Browse Source 
Updated the `Pkcs11Options` class to rename the `DefaultApplicationName` property to `ApplicationName`, clarifying its role as a globally controlled value embedded in PDF signature metadata.

Modified `PdfDigitalSignatureService` to source `ApplicationName` directly from `Pkcs11Options`, removing client-level overrides. Updated `PdfSignatureController` to reflect this change by removing the `ApplicationName` property from `SignOptions`.

Updated `appsettings.json` and `README.md` to reflect the property name change. These changes enforce stricter configuration control, improving metadata consistency and security.
This commit is contained in:
tekh
2026-10-14 14:34:59 +02:00
parent 7a36316b7e
commit 4f8fa9afd8
5 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
EnvelopeGenerator.Application/Common/Configurations/Pkcs11Options.cs
View File

@@ -81,9 +81,10 @@ public sealed class Pkcs11Options
public string? DefaultReason { get; set; } public string? DefaultReason { get; set; }
/// <summary> /// <summary>
/// Optional global default application name used when request-level options do not specify a value. /// Application name embedded into PDF signature metadata.
/// This value is controlled via app settings and is not client-overridable.
/// </summary> /// </summary>
public string? DefaultApplicationName { get; set; } public string? ApplicationName { get; set; }
/// <summary> /// <summary>
/// Controls how fallback signing time is created when request-level options do not specify a value. /// Controls how fallback signing time is created when request-level options do not specify a value.

2
EnvelopeGenerator.Infrastructure.Crypt/README.md
View File

@@ -112,7 +112,7 @@ Configuration section: `Crypt:Pkcs11`
"UserPin": "***", "UserPin": "***",
"PrivateKeyLabel": "sign-key", "PrivateKeyLabel": "sign-key",
"CertificateLabel": "sign-cert", "CertificateLabel": "sign-cert",
"DefaultApplicationName": "signFLOW", "ApplicationName": "signFLOW",
"UseUtcSigningTime": true "UseUtcSigningTime": true
} }
} }

2
EnvelopeGenerator.Infrastructure.Crypt/Services/PdfDigitalSignatureService.cs
View File

@@ -44,7 +44,7 @@ public sealed class PdfDigitalSignatureService(IOptions<Pkcs11Options> options)
Location = request.Location, Location = request.Location,
ContactInfo = request.ContactInfo, ContactInfo = request.ContactInfo,
SigningTime = request.SigningTime ?? (pkcs11Options.UseUtcSigningTime ? DateTimeOffset.UtcNow : DateTimeOffset.Now), SigningTime = request.SigningTime ?? (pkcs11Options.UseUtcSigningTime ? DateTimeOffset.UtcNow : DateTimeOffset.Now),
ApplicationName = request.ApplicationName ?? pkcs11Options.DefaultApplicationName, ApplicationName = pkcs11Options.ApplicationName,
CertificationLevel = ToDevExpressCertificationLevel(request.CertificationLevel) CertificationLevel = ToDevExpressCertificationLevel(request.CertificationLevel)
?? ToDevExpressCertificationLevel(pkcs11Options.DefaultCertificationLevel) ?? ToDevExpressCertificationLevel(pkcs11Options.DefaultCertificationLevel)
?? PdfCertificationLevel.NoCertification ?? PdfCertificationLevel.NoCertification

3
EnvelopeGenerator.Server/EnvelopeGenerator.Server/Controllers/PdfSignatureController.cs
View File

@@ -19,7 +19,6 @@ public class PdfSignatureController(IPdfDigitalSignatureService signatureService
public string? Location { get; set; } public string? Location { get; set; }
public string? ContactInfo { get; set; } public string? ContactInfo { get; set; }
public DateTimeOffset? SigningTime { get; set; } public DateTimeOffset? SigningTime { get; set; }
public string? ApplicationName { get; set; }
} }
public sealed class CheckPdfSignatureForm public sealed class CheckPdfSignatureForm
@@ -56,7 +55,6 @@ public class PdfSignatureController(IPdfDigitalSignatureService signatureService
Location = request.Location, Location = request.Location,
ContactInfo = request.ContactInfo, ContactInfo = request.ContactInfo,
SigningTime = request.SigningTime, SigningTime = request.SigningTime,
ApplicationName = request.ApplicationName,
CertificationLevel = PdfSignatureCertificationLevel.FormFillingAndAnnotations CertificationLevel = PdfSignatureCertificationLevel.FormFillingAndAnnotations
}; };
@@ -106,7 +104,6 @@ public class PdfSignatureController(IPdfDigitalSignatureService signatureService
Reason = "reason", Reason = "reason",
Location = "location", Location = "location",
ContactInfo = "test@example.com", ContactInfo = "test@example.com",
ApplicationName = "signFLOW",
CertificationLevel = PdfSignatureCertificationLevel.FormFillingAndAnnotations CertificationLevel = PdfSignatureCertificationLevel.FormFillingAndAnnotations
}; };

2
EnvelopeGenerator.Server/EnvelopeGenerator.Server/appsettings.json
View File

@@ -65,7 +65,7 @@
"PrivateKeyLabel": "company-sign-key-v1", "PrivateKeyLabel": "company-sign-key-v1",
"CertificateLabel": "company-sign-cert-v1", "CertificateLabel": "company-sign-cert-v1",
"DefaultReason": null, "DefaultReason": null,
"DefaultApplicationName": "signFLOW", "ApplicationName": "signFLOW",
"UseUtcSigningTime": true, "UseUtcSigningTime": true,
"DefaultCertificationLevel": "NoCertification" "DefaultCertificationLevel": "NoCertification"
} }