From 4caf8cd19243c23693c5566092015bb3a2ae3e7c Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Wed, 1 Apr 2026 15:32:09 +0200
Subject: [PATCH] Refactor to use EnvelopeDto in report generation

Updated ReportCreator and ReportItem to accept EnvelopeDto
instead of Envelope, promoting better separation of concerns
and improved data handling via DTOs.
---
 .../Jobs/FinalizeDocument/ReportCreator.cs                     | 3 ++-
 .../Jobs/FinalizeDocument/ReportItem.cs                        | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportCreator.cs b/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportCreator.cs
index 9ff9e190..ce1fac85 100644
--- a/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportCreator.cs
+++ b/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportCreator.cs
@@ -1,5 +1,6 @@
 using DevExpress.Xpo;
 using DigitalData.Core.Abstraction.Application.Repository;
+using EnvelopeGenerator.Application.Common.Dto;
 using EnvelopeGenerator.Domain.Entities;
 using EnvelopeGenerator.ServiceHost.Exceptions;
 
@@ -7,7 +8,7 @@ namespace EnvelopeGenerator.ServiceHost.Jobs.FinalizeDocument;
 
 public class ReportCreator(IRepository<EnvelopeReport> reportRepo)
 {
-    public async Task<byte[]> CreateReportAsync(Envelope envelope, CancellationToken cancel = default)
+    public async Task<byte[]> CreateReportAsync(EnvelopeDto envelope, CancellationToken cancel = default)
     {
         var reports = await reportRepo.Where(r => r.EnvelopeId == envelope.Id).ToListAsync(cancel);
 
diff --git a/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportItem.cs b/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportItem.cs
index e815a04e..fcfae9f1 100644
--- a/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportItem.cs
+++ b/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocument/ReportItem.cs
@@ -1,3 +1,4 @@
+using EnvelopeGenerator.Application.Common.Dto;
 using EnvelopeGenerator.Domain.Constants;
 using EnvelopeGenerator.Domain.Entities;
 
@@ -7,7 +8,7 @@ public class ReportItem
 {
     public ReportItem() { }
 
-    public ReportItem(EnvelopeReport report, Envelope envelope)
+    public ReportItem(EnvelopeReport report, EnvelopeDto envelope)
     {
         CreatorFullName = envelope.User is not null
             ? $"{envelope.User.Prename} {envelope.User.Name}".Trim()