From 42451a767b579dbbcb3e9c4e9bec7545b20439f7 Mon Sep 17 00:00:00 2001 From: Developer 02 Date: Tue, 6 May 2025 17:06:24 +0200 Subject: [PATCH] Refactor SQL command and simplify constructor Updated the `EnvelopeReceiverAddReadSQL` class to correct the formatting of the `@EMAIL_ADRESS` parameter in the SQL command string and improved the XML documentation comments for better readability. Modified the `EnvelopeReceiverExecutor` class by removing the `ILogger` parameter from the constructor, simplifying its signature while retaining necessary dependencies. --- .../SQL/EnvelopeReceiverAddReadSQL.cs | 19 +++++++++---------- .../Executor/EnvelopeReceiverExecutor.cs | 2 +- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs b/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs index 6ed0d9f3..b389a4c4 100644 --- a/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs +++ b/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs @@ -14,12 +14,11 @@ public class EnvelopeReceiverAddReadSQL : ISQL /// public string Raw => @" USE [DD_ECM] - DECLARE @OUT_RECEIVER_ID int EXEC [dbo].[PRSIG_API_CREATE_RECEIVER] @ENV_UID = @ENV_UID, - @EMAIL_ADRESS = @EMAIL_ADRESS , + @EMAIL_ADRESS = @EMAIL_ADRESS, @SALUTATION = @SALUTATION, @PHONE = @PHONE, @OUT_RECEIVER_ID = @OUT_RECEIVER_ID OUTPUT @@ -29,14 +28,14 @@ public class EnvelopeReceiverAddReadSQL : ISQL WHERE [GUID] = @OUT_RECEIVER_ID; "; - /// - /// - /// - /// - /// - /// - /// - /// + /// + /// + /// + /// + /// + /// + /// + /// public static DynamicParameters CreateParameters(string envelope_uuid, string emailAddress, string? salutation = null, string? phone = null) { var parameters = new DynamicParameters(); diff --git a/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs b/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs index 219b0716..2dcbf8f6 100644 --- a/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs +++ b/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs @@ -14,7 +14,7 @@ public class EnvelopeReceiverExecutor: SQLExecutor, IEnvelopeReceiverExecutor { private readonly IEnvelopeReceiverRepository _erRepository; - public EnvelopeReceiverExecutor(ILogger logger, IServiceProvider provider, IOptions sqlExecutorParamsOptions, IEnvelopeReceiverRepository erRepository) : base(provider, sqlExecutorParamsOptions) + public EnvelopeReceiverExecutor(IServiceProvider provider, IOptions sqlExecutorParamsOptions, IEnvelopeReceiverRepository erRepository) : base(provider, sqlExecutorParamsOptions) { _erRepository = erRepository; }