From 2ae6dda27e16c6de01a5e7c8bb0b17a13e4d9efa Mon Sep 17 00:00:00 2001 From: TekH Date: Mon, 8 Sep 2025 17:41:34 +0200 Subject: [PATCH] refactor(EnvelopeMailService): remove SendTFAQrCodeAsync method --- .../EnvelopeReceiverSecretDto.cs | 5 +-- .../Services/IEnvelopeMailService.cs | 7 ----- .../Services/EnvelopeMailService.cs | 31 +++---------------- 3 files changed, 8 insertions(+), 35 deletions(-) diff --git a/EnvelopeGenerator.Application/Dto/EnvelopeReceiver/EnvelopeReceiverSecretDto.cs b/EnvelopeGenerator.Application/Dto/EnvelopeReceiver/EnvelopeReceiverSecretDto.cs index 0e74b16e..78c0fe9d 100644 --- a/EnvelopeGenerator.Application/Dto/EnvelopeReceiver/EnvelopeReceiverSecretDto.cs +++ b/EnvelopeGenerator.Application/Dto/EnvelopeReceiver/EnvelopeReceiverSecretDto.cs @@ -1,4 +1,5 @@ -using Microsoft.AspNetCore.Mvc; +using EnvelopeGenerator.Application.Dto.Receiver; +using Microsoft.AspNetCore.Mvc; namespace EnvelopeGenerator.Application.Dto.EnvelopeReceiver; @@ -6,7 +7,7 @@ namespace EnvelopeGenerator.Application.Dto.EnvelopeReceiver; /// /// [ApiExplorerSettings(IgnoreApi = true)] -public record EnvelopeReceiverSecretDto : EnvelopeReceiverDto +public record EnvelopeReceiverSecretDto : EnvelopeReceiverDto { /// /// diff --git a/EnvelopeGenerator.Application/Interfaces/Services/IEnvelopeMailService.cs b/EnvelopeGenerator.Application/Interfaces/Services/IEnvelopeMailService.cs index a4fd19b3..9ba7dfba 100644 --- a/EnvelopeGenerator.Application/Interfaces/Services/IEnvelopeMailService.cs +++ b/EnvelopeGenerator.Application/Interfaces/Services/IEnvelopeMailService.cs @@ -35,11 +35,4 @@ public interface IEnvelopeMailService : IEmailOutService /// /// Task> SendAccessCodeAsync(EnvelopeReceiverDto envelopeReceiverDto); - - /// - /// - /// - /// - /// - Task> SendTFAQrCodeAsync(EnvelopeReceiverDto envelopeReceiverDto); } \ No newline at end of file diff --git a/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs b/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs index 47bf6468..c7d4403a 100644 --- a/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs +++ b/EnvelopeGenerator.Application/Services/EnvelopeMailService.cs @@ -181,31 +181,10 @@ public async Task> SendAsync(EnvelopeReceiverReadOnlyDto dto, Di return await CreateWithTemplateAsync(createDto: mail, placeholders: placeholders, dto.Envelope); } -/// -/// -/// -/// -/// + /// + /// + /// + /// + /// public async Task> SendAccessCodeAsync(EnvelopeReceiverDto dto) => await SendAsync(dto: dto, tempType: EmailTemplateType.DocumentAccessCodeReceived); - -/// -/// -/// -/// -/// -/// - public Task> SendTFAQrCodeAsync(EnvelopeReceiverDto dto) - { - // Check if receiver or secret key is null - if (dto.Receiver is null) - throw new ArgumentNullException(nameof(dto), $"TFA Qr Code cannot sent. Receiver information is missing. Envelope receiver dto is {JsonConvert.SerializeObject(dto)}"); - if (dto.Receiver.TotpSecretkey is null) - throw new ArgumentNullException(nameof(dto), $"TFA Qr Code cannot sent. Receiver.TotpSecretKey is null. Envelope receiver dto is {JsonConvert.SerializeObject(dto)}"); - - var totp_qr_64 = _authenticator.GenerateTotpQrCode(userEmail: dto.Receiver.EmailAddress, secretKey: dto.Receiver.TotpSecretkey).ToBase64String(); - return SendAsync(dto, EmailTemplateType.TotpSecret, new() - { - {"[TFA_QR_CODE]", totp_qr_64 }, - }); - } } \ No newline at end of file