From 1d74b7ca06c8884a90cc9240b4416c4b9e7ce08f Mon Sep 17 00:00:00 2001 From: Developer 02 Date: Mon, 12 May 2025 09:46:59 +0200 Subject: [PATCH] Remove null check for EmailAddress in GetReceiverName This commit removes the conditional check for the `EmailAddress` property in the `GetReceiverName` method. As a result, the method will no longer return a `BadRequest` if `EmailAddress` is null, which may lead to unvalidated null values being passed to the `_erService.ReadLastUsedReceiverNameByMailAsync` method. --- .../Controllers/EnvelopeReceiverController.cs | 3 --- 1 file changed, 3 deletions(-) diff --git a/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs b/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs index 59537342..24249b44 100644 --- a/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs +++ b/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs @@ -125,9 +125,6 @@ public class EnvelopeReceiverController : ControllerBase [HttpGet("salute")] public async Task GetReceiverName([FromQuery] ReadReceiverNameQuery receiver) { - if (receiver.EmailAddress is null) - return BadRequest(); - return await _erService.ReadLastUsedReceiverNameByMailAsync(receiver.EmailAddress, receiver.Id, receiver.Signature).ThenAsync( Success: res => res is null ? NotFound() : Ok(res), Fail: IActionResult (msg, ntc) =>