From 1a0973075b0f0eabadba5817244be680f43eb1ae Mon Sep 17 00:00:00 2001 From: TekH Date: Wed, 25 Feb 2026 13:43:51 +0100 Subject: [PATCH] Standardize error logging with LogError method Replaced all usages of _logger?.Error with _logger?.LogError in FinalizeDocumentJob.cs. Renamed the Error method to LogError in Logging.cs for consistency. This change ensures uniform error logging across the codebase. --- EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocumentJob.cs | 4 ++-- EnvelopeGenerator.ServiceHost/Jobs/Infrastructure/Logging.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocumentJob.cs b/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocumentJob.cs index d0e6724c..776a349d 100644 --- a/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocumentJob.cs +++ b/EnvelopeGenerator.ServiceHost/Jobs/FinalizeDocumentJob.cs @@ -293,7 +293,7 @@ public class FinalizeDocumentJob(IOptions options, IConfiguration if (_actionService?.CompleteEnvelope(envelope) == false) { - _logger?.Error(new Exception("CompleteEnvelope failed"), "Envelope could not be completed for receiver [{0}]", envelope.User?.Email); + _logger?.LogError(new Exception("CompleteEnvelope failed"), "Envelope could not be completed for receiver [{0}]", envelope.User?.Email); return false; } @@ -309,7 +309,7 @@ public class FinalizeDocumentJob(IOptions options, IConfiguration { if (_actionService?.CompleteEnvelope(envelope, receiver.Receiver) == false) { - _logger?.Error(new Exception("CompleteEnvelope failed"), "Envelope could not be completed for receiver [{0}]", receiver.Receiver?.EmailAddress); + _logger?.LogError(new Exception("CompleteEnvelope failed"), "Envelope could not be completed for receiver [{0}]", receiver.Receiver?.EmailAddress); return false; } } diff --git a/EnvelopeGenerator.ServiceHost/Jobs/Infrastructure/Logging.cs b/EnvelopeGenerator.ServiceHost/Jobs/Infrastructure/Logging.cs index 8ec392bb..1331db0e 100644 --- a/EnvelopeGenerator.ServiceHost/Jobs/Infrastructure/Logging.cs +++ b/EnvelopeGenerator.ServiceHost/Jobs/Infrastructure/Logging.cs @@ -23,7 +23,7 @@ public class Logger public void Error(Exception exception) => logger.LogError(exception, exception.Message); - public void Error(Exception exception, string message, params object?[] args) => Write("ERROR", message + " " + exception.Message, args); + public void LogError(Exception exception, string message, params object?[] args) => Write("ERROR", message + " " + exception.Message, args); private static void Write(string level, string message, params object?[] args) {