From 1875acb7b5d085dc6cb3e95e477f445441eda623 Mon Sep 17 00:00:00 2001 From: Developer 02 Date: Wed, 7 May 2025 14:10:20 +0200 Subject: [PATCH] Refactor SQL queries and data mappings - Updated SQL query in `EnvelopeReceiverAddReadSQL.cs` to select specific columns (`ENVELOPE_ID` and `RECEIVER_ID`) for improved performance and clarity. - Changed mapping of `SentRecipients` in `EnvelopeReceiverController.cs` to expect a single `ReceiverReadDto` instead of a collection, reflecting a change in data handling. - Modified `QueryAsync` in `EnvelopeReceiverExecutor.cs` to remove the generic type parameter, allowing for more flexible data handling. --- .../SQL/EnvelopeReceiverAddReadSQL.cs | 4 ++-- .../Controllers/EnvelopeReceiverController.cs | 2 +- .../Executor/EnvelopeReceiverExecutor.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs b/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs index 1c499858..73fc5de2 100644 --- a/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs +++ b/EnvelopeGenerator.Application/SQL/EnvelopeReceiverAddReadSQL.cs @@ -22,8 +22,8 @@ public class EnvelopeReceiverAddReadSQL : ISQL {3}, @OUT_RECEIVER_ID OUTPUT - SELECT TOP(1) * - FROM TBSIG_ENVELOPE_RECEIVER + SELECT TOP(1) [ENVELOPE_ID] As EnvelopeId, [RECEIVER_ID] As ReceiverId + FROM [dbo].[TBSIG_ENVELOPE_RECEIVER] WHERE [GUID] = @OUT_RECEIVER_ID; "; diff --git a/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs b/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs index 62127f4a..dfeb2628 100644 --- a/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs +++ b/EnvelopeGenerator.GeneratorAPI/Controllers/EnvelopeReceiverController.cs @@ -217,7 +217,7 @@ public class EnvelopeReceiverController : ControllerBase var res = _mapper.Map(envelope); res.UnsentRecipients = unsentRecipients; - res.SentRecipients = _mapper.Map>(sentRecipients); + res.SentRecipients = _mapper.Map>(sentRecipients); #endregion #region Add document diff --git a/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs b/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs index 71f37495..ddcd9d28 100644 --- a/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs +++ b/EnvelopeGenerator.Infrastructure/Executor/EnvelopeReceiverExecutor.cs @@ -24,7 +24,7 @@ public class EnvelopeReceiverExecutor: SQLExecutor, IEnvelopeReceiverExecutor var sql = Provider.GetRequiredService(); var formattedSql = string.Format(sql.Raw, envelope_uuid.ToSqlParam(), emailAddress.ToSqlParam(), salutation.ToSqlParam(), phone.ToSqlParam()); await connection.OpenAsync(cancellation); - var envelopeReceivers = await connection.QueryAsync(formattedSql); + var envelopeReceivers = await connection.QueryAsync(formattedSql); var er = envelopeReceivers.FirstOrDefault(); if (er is null)