From 15e163bd60866d3b7e707c9af53eda583b4f943c Mon Sep 17 00:00:00 2001
From: Jonathan Jenne <j.jenne@digitaldata.works>
Date: Mon, 4 Dec 2023 15:30:35 +0100
Subject: [PATCH] small  fixes

---
 .../Entities/EmailTemplate.vb                   | 17 +++++++++++------
 .../Entities/EnvelopeReceiver.vb                |  3 +++
 .../EnvelopeGenerator.Common.vbproj             |  3 +++
 .../Jobs/CertificateDocumentJob.vb              |  3 ++-
 .../Services/EmailService.vb                    |  2 +-
 EnvelopeGenerator.Common/packages.config        |  1 +
 6 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/EnvelopeGenerator.Common/Entities/EmailTemplate.vb b/EnvelopeGenerator.Common/Entities/EmailTemplate.vb
index b2b9518f..b0eabe8e 100644
--- a/EnvelopeGenerator.Common/Entities/EmailTemplate.vb
+++ b/EnvelopeGenerator.Common/Entities/EmailTemplate.vb
@@ -13,9 +13,13 @@ Public Class EmailTemplate
 
     Private _replaceDictionary As Dictionary(Of String, String)
 
-    Public Sub New()
+    Private DbConfig As DbConfig
+
+    Public Sub New(pState As State)
         InitBodyTemplates()
         InitSubjectTemplates()
+
+        DbConfig = pState.DbConfig
     End Sub
 
     Private Sub InitSubjectTemplates()
@@ -36,16 +40,16 @@ Public Class EmailTemplate
             "<MESSAGE>",
             "",
             "Mit freundlichen Grüßen",
-            "<NAME_SENDER>"
+            "<NAME_PORTAL>"
         }
 
         _DocumentSignedBodyTemplate = New List(Of String) From {
             "Guten Tag, <NAME_RECEIVER>",
             "",
-            "Ihre Unterschrift auf dem Dokument <DOCUMENT_TITLE> wurde gespeichert.",
+            "hiermit bestätigen wir Ihnen die erfolgreiche Signatur für den Vorgang <DOCUMENT_TITLE>.",
             "",
             "Mit freundlichen Grüßen",
-            "<NAME_SENDER>"
+            "<NAME_PORTAL>"
         }
 
         _DocumentDeletedBodyTemplate = New List(Of String) From {
@@ -54,7 +58,7 @@ Public Class EmailTemplate
             "Der User <NAME_SENDER> hat den Umschlag <DOCUMENT_TITLE> gelöscht.",
             "",
             "Mit freundlichen Grüßen",
-            "<NAME_SENDER>"
+            "<NAME_PORTAL>"
         }
 
         _DocumentCompletedBodyTemplate = New List(Of String) From {
@@ -63,7 +67,7 @@ Public Class EmailTemplate
             "Das Dokument <DOCUMENT_TITLE> wurde von allen Beteiligten unterschrieben.",
             "",
             "Mit freundlichen Grüßen",
-            "<NAME_SENDER>"
+            "<NAME_PORTAL>"
         }
     End Sub
 
@@ -71,6 +75,7 @@ Public Class EmailTemplate
         _replaceDictionary = New Dictionary(Of String, String) From {
             {"<NAME_RECEIVER>", pEmailData.ReceiverName},
             {"<NAME_SENDER>", pEmailData.SenderName},
+            {"<NAME_PORTAL>", DbConfig.ExternalProgramName},
             {"<SIGNATURE_TYPE>", "signieren"},
             {"<LINK_TO_DOCUMENT>", pEmailData.SignatureLink},
             {"<LINK_TO_DOCUMENT_TEXT>", $"{pEmailData.SignatureLink.Truncate(40)}.."},
diff --git a/EnvelopeGenerator.Common/Entities/EnvelopeReceiver.vb b/EnvelopeGenerator.Common/Entities/EnvelopeReceiver.vb
index c4293343..cdbc53b8 100644
--- a/EnvelopeGenerator.Common/Entities/EnvelopeReceiver.vb
+++ b/EnvelopeGenerator.Common/Entities/EnvelopeReceiver.vb
@@ -1,7 +1,9 @@
 Imports System.Drawing
+Imports System.Runtime.Serialization
 Imports DevExpress.Utils.Svg
 Imports DigitalData.Modules.Base
 Imports EnvelopeGenerator.Common.Constants
+Imports Newtonsoft.Json
 
 Public Class EnvelopeReceiver
     Public Property Id As Integer = 0
@@ -13,6 +15,7 @@ Public Class EnvelopeReceiver
         End Get
     End Property
 
+    <JsonIgnore>
     Public ReadOnly Property Image As SvgBitmap
         Get
             Try
diff --git a/EnvelopeGenerator.Common/EnvelopeGenerator.Common.vbproj b/EnvelopeGenerator.Common/EnvelopeGenerator.Common.vbproj
index 442d5ff3..59558586 100644
--- a/EnvelopeGenerator.Common/EnvelopeGenerator.Common.vbproj
+++ b/EnvelopeGenerator.Common/EnvelopeGenerator.Common.vbproj
@@ -78,6 +78,9 @@
     <Reference Include="Microsoft.Extensions.Logging.Abstractions, Version=2.1.1.0, Culture=neutral, PublicKeyToken=adb9793829ddae60, processorArchitecture=MSIL">
       <HintPath>..\packages\Microsoft.Extensions.Logging.Abstractions.2.1.1\lib\netstandard2.0\Microsoft.Extensions.Logging.Abstractions.dll</HintPath>
     </Reference>
+    <Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
+      <HintPath>..\packages\Newtonsoft.Json.13.0.3\lib\net45\Newtonsoft.Json.dll</HintPath>
+    </Reference>
     <Reference Include="NLog, Version=5.0.0.0, Culture=neutral, PublicKeyToken=5120e14c03d0593c, processorArchitecture=MSIL">
       <HintPath>..\packages\NLog.5.0.5\lib\net46\NLog.dll</HintPath>
     </Reference>
diff --git a/EnvelopeGenerator.Common/Jobs/CertificateDocumentJob.vb b/EnvelopeGenerator.Common/Jobs/CertificateDocumentJob.vb
index 3f36a768..8f07c9a8 100644
--- a/EnvelopeGenerator.Common/Jobs/CertificateDocumentJob.vb
+++ b/EnvelopeGenerator.Common/Jobs/CertificateDocumentJob.vb
@@ -15,7 +15,8 @@ Public Class CertificateDocumentJob
             Dim JobId = pContext.JobDetail.Key
             oLogger.Info("Starting job {0}", JobId)
 
-            Dim oSql = $"SELECT * FROM TBSIG_ENVELOPE WHERE STATUS = {Constants.EnvelopeStatus.EnvelopeCompletelySigned}"
+            Dim oCompleteStatus As Integer = Constants.EnvelopeStatus.EnvelopeCompletelySigned
+            Dim oSql = $"SELECT * FROM TBSIG_ENVELOPE WHERE STATUS = {oCompleteStatus}"
             Dim oTable = oDatabase.GetDatatable(oSql)
 
             oLogger.Info("Found [{0}] completed envelopes.", oTable.Rows.Count)
diff --git a/EnvelopeGenerator.Common/Services/EmailService.vb b/EnvelopeGenerator.Common/Services/EmailService.vb
index cbc26758..46cc95c2 100644
--- a/EnvelopeGenerator.Common/Services/EmailService.vb
+++ b/EnvelopeGenerator.Common/Services/EmailService.vb
@@ -20,7 +20,7 @@ Public Class EmailService
         EnvelopeModel = New EnvelopeModel(pState)
         ReceiverModel = New ReceiverModel(pState)
         EmailModel = New EmailModel(pState)
-        EmailTemplate = New EmailTemplate()
+        EmailTemplate = New EmailTemplate(pState)
     End Sub
 
     Public Function SendEnvelopeDeletedEmail(pEnvelope As Envelope, pReceiver As EnvelopeReceiver) As Boolean
diff --git a/EnvelopeGenerator.Common/packages.config b/EnvelopeGenerator.Common/packages.config
index ce073819..7c9e9f71 100644
--- a/EnvelopeGenerator.Common/packages.config
+++ b/EnvelopeGenerator.Common/packages.config
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
   <package id="Microsoft.Extensions.Logging.Abstractions" version="2.1.1" targetFramework="net462" />
+  <package id="Newtonsoft.Json" version="13.0.3" targetFramework="net462" />
   <package id="Quartz" version="3.8.0" targetFramework="net462" />
 </packages>
\ No newline at end of file