From b953e3afaafe2dac22327bcbe630451c9e0b93c7 Mon Sep 17 00:00:00 2001
From: Developer 02 <developer02@didaloghe.onmicrosoft.com>
Date: Mon, 14 Apr 2025 16:38:52 +0200
Subject: [PATCH] Refactor email repository and service interfaces
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Die Schnittstelle `IEmailOutRepository` wurde durch Entfernen unnötiger Klammern gestrafft.
- Aktualisierte `IEmailOutService` Schnittstelle, um generische Parameter zu korrigieren und Redundanz zu entfernen.
- Aktualisierte Paketversionen in Projektdateien auf `DigitalData.Core.Abstractions` (3.4.0) und `DigitalData.Core.Application` (3.2.0).
- Verbesserte `CreateWithTemplateAsync` Methoden in `EmailOutService.cs` für bessere Implementierung.
- Das Testprojekt wurde aktualisiert, um die neue Paketversion für `DigitalData.Core.Application` zu berücksichtigen.
---
 .../Contracts/IEmailOutRepository.cs          |  7 ++---
 .../Contracts/IEmailOutService.cs             |  9 +++---
 ...EmailProfilerDispatcher.Abstraction.csproj |  4 +--
 ...DigitalData.EmailProfilerDispatcher.csproj |  4 +--
 .../Services/EmailOutService.cs               | 29 +++++++++----------
 .../EmailProfilerDispatcher.Tests.csproj      |  2 +-
 6 files changed, 26 insertions(+), 29 deletions(-)

diff --git a/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutRepository.cs b/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutRepository.cs
index 8a84cdc..892c41f 100644
--- a/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutRepository.cs
+++ b/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutRepository.cs
@@ -1,9 +1,8 @@
 using DigitalData.Core.Abstractions.Infrastructure;
 using DigitalData.EmailProfilerDispatcher.Abstraction.Entities;
 
-namespace DigitalData.EmailProfilerDispatcher.Abstraction.Contracts
+namespace DigitalData.EmailProfilerDispatcher.Abstraction.Contracts;
+
+public interface IEmailOutRepository : ICRUDRepository<EmailOut, int>
 {
-    public interface IEmailOutRepository : ICRUDRepository<EmailOut, int>
-    {
-    }
 }
\ No newline at end of file
diff --git a/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutService.cs b/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutService.cs
index 3b3b589..c4d906b 100644
--- a/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutService.cs
+++ b/DigitalData.EmailProfilerDispatcher.Abstraction/Contracts/IEmailOutService.cs
@@ -3,10 +3,9 @@ using DigitalData.Core.DTO;
 using DigitalData.EmailProfilerDispatcher.Abstraction.DTOs.EmailOut;
 using DigitalData.EmailProfilerDispatcher.Abstraction.Entities;
 
-namespace DigitalData.EmailProfilerDispatcher.Abstraction.Contracts
+namespace DigitalData.EmailProfilerDispatcher.Abstraction.Contracts;
+
+public interface IEmailOutService : ICRUDService<EmailOutCreateDto, EmailOutDto, EmailOut, int>
 {
-    public interface IEmailOutService : ICRUDService<EmailOutCreateDto, EmailOutDto, EmailOutDto, EmailOut, int>
-    {
-        Task<DataResult<int>> CreateWithTemplateAsync(EmailOutCreateDto createDto, params object[] models);
-	}
+    Task<DataResult<int>> CreateWithTemplateAsync(EmailOutCreateDto createDto, params object[] models);
 }
\ No newline at end of file
diff --git a/DigitalData.EmailProfilerDispatcher.Abstraction/DigitalData.EmailProfilerDispatcher.Abstraction.csproj b/DigitalData.EmailProfilerDispatcher.Abstraction/DigitalData.EmailProfilerDispatcher.Abstraction.csproj
index 85b7b70..80567a7 100644
--- a/DigitalData.EmailProfilerDispatcher.Abstraction/DigitalData.EmailProfilerDispatcher.Abstraction.csproj
+++ b/DigitalData.EmailProfilerDispatcher.Abstraction/DigitalData.EmailProfilerDispatcher.Abstraction.csproj
@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <TargetFramework>net7.0</TargetFramework>
@@ -16,7 +16,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="DigitalData.Core.Abstractions" Version="2.0.0" />
+    <PackageReference Include="DigitalData.Core.Abstractions" Version="3.4.0" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/DigitalData.EmailProfilerDispatcher/DigitalData.EmailProfilerDispatcher.csproj b/DigitalData.EmailProfilerDispatcher/DigitalData.EmailProfilerDispatcher.csproj
index a210694..c9781e7 100644
--- a/DigitalData.EmailProfilerDispatcher/DigitalData.EmailProfilerDispatcher.csproj
+++ b/DigitalData.EmailProfilerDispatcher/DigitalData.EmailProfilerDispatcher.csproj
@@ -17,8 +17,8 @@
 
   <ItemGroup>
     <PackageReference Include="AutoMapper" Version="13.0.1" />
-    <PackageReference Include="DigitalData.Core.Abstractions" Version="2.0.0" />
-    <PackageReference Include="DigitalData.Core.Application" Version="2.0.0" />
+    <PackageReference Include="DigitalData.Core.Abstractions" Version="3.4.0" />
+    <PackageReference Include="DigitalData.Core.Application" Version="3.2.0" />
     <PackageReference Include="DigitalData.Core.Infrastructure" Version="2.0.0" />
     <PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.16" />
     <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="7.0.16" />
diff --git a/DigitalData.EmailProfilerDispatcher/Services/EmailOutService.cs b/DigitalData.EmailProfilerDispatcher/Services/EmailOutService.cs
index 59eaf56..b4bf8a6 100644
--- a/DigitalData.EmailProfilerDispatcher/Services/EmailOutService.cs
+++ b/DigitalData.EmailProfilerDispatcher/Services/EmailOutService.cs
@@ -5,28 +5,27 @@ using DigitalData.EmailProfilerDispatcher.Abstraction.Contracts;
 using DigitalData.EmailProfilerDispatcher.Abstraction.DTOs.EmailOut;
 using DigitalData.EmailProfilerDispatcher.Abstraction.Entities;
 
-namespace DigitalData.EmailProfilerDispatcher.Abstraction.Services
-{
-    public class EmailOutService : CRUDService<IEmailOutRepository, EmailOutCreateDto, EmailOutDto, EmailOutDto, EmailOut, int>, IEmailOutService
+namespace DigitalData.EmailProfilerDispatcher.Abstraction.Services;
+
+    public class EmailOutService : CRUDService<IEmailOutRepository, EmailOutCreateDto, EmailOutDto, EmailOut, int>, IEmailOutService
     {
         public EmailOutService(IEmailOutRepository repository, IMapper mapper) : base(repository, mapper)
         {
         }
 
-		public async Task<DataResult<int>> CreateWithTemplateAsync(EmailOutCreateDto createDto, params object[] models)
-		{
-			createDto.EmailSubj = createDto.EmailSubj.FillTemplate(models);
-			createDto.EmailBody = createDto.EmailBody.FillTemplate(models);
+	public async Task<DataResult<int>> CreateWithTemplateAsync(EmailOutCreateDto createDto, params object[] models)
+	{
+		createDto.EmailSubj = createDto.EmailSubj.FillTemplate(models);
+		createDto.EmailBody = createDto.EmailBody.FillTemplate(models);
 
-			return await base.CreateAsync(createDto);
-		}
+		return await base.CreateAsync(createDto);
+	}
 
-		public async Task<DataResult<int>> CreateWithTemplateAsync(EmailOutCreateDto createDto, Dictionary<string, string> placeholders, params object[] models)
-		{
-			createDto.EmailSubj = createDto.EmailSubj.FillTemplate(placeholders);
-			createDto.EmailBody = createDto.EmailBody.FillTemplate(placeholders);
+	public async Task<DataResult<int>> CreateWithTemplateAsync(EmailOutCreateDto createDto, Dictionary<string, string> placeholders, params object[] models)
+	{
+		createDto.EmailSubj = createDto.EmailSubj.FillTemplate(placeholders);
+		createDto.EmailBody = createDto.EmailBody.FillTemplate(placeholders);
 
-			return await CreateWithTemplateAsync(createDto, models: models);
-		}
+		return await CreateWithTemplateAsync(createDto, models: models);
 	}
 }
\ No newline at end of file
diff --git a/EmailProfilerDispatcher.Tests/EmailProfilerDispatcher.Tests.csproj b/EmailProfilerDispatcher.Tests/EmailProfilerDispatcher.Tests.csproj
index e4b2d10..3dab68d 100644
--- a/EmailProfilerDispatcher.Tests/EmailProfilerDispatcher.Tests.csproj
+++ b/EmailProfilerDispatcher.Tests/EmailProfilerDispatcher.Tests.csproj
@@ -11,7 +11,7 @@
 
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="3.2.0" />
-    <PackageReference Include="DigitalData.Core.Application" Version="2.0.0" />
+    <PackageReference Include="DigitalData.Core.Application" Version="3.2.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.1" />
     <PackageReference Include="NUnit" Version="3.13.3" />
     <PackageReference Include="NUnit.Analyzers" Version="3.6.1" />