AppStd/ECMJobRunner
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

feat(application): add inactive profile validation with custom exception

Browse Source 
- Create InactiveProfileException for profile active status validation
- Update TriggeringDEXJobBatchCommand to check profile active status before execution
- Add ICfgProfileRepository dependency to batch command handler
- Throw InactiveProfileException when attempting to execute inactive profiles
- Add profile not found validation with descriptive error message
- Reorganize commands under DEXJob/Commands directory structure
This commit is contained in:
tekh
2026-07-11 19:16:35 +02:00
parent eaf24e05ee
commit 8255f1f6aa
5 changed files with 239 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ECMJobRunner.Tests/Application/TriggeringDEXJobBatchCommandTests.cs
View File

@@ -1,8 +1,9 @@
using ECMJobRunner.Application.Common.Dtos;
using ECMJobRunner.Domain.Interfaces;
using ECMJobRunner.Application.Common.Interfaces;
using ECMJobRunner.Application.Common.Options;
using ECMJobRunner.Application.DEXJob;
using ECMJobRunner.Application.DEXJob.Commands;
using ECMJobRunner.Domain.Entities;
using ECMJobRunner.Domain.Interfaces;
using FluentAssertions;
using MediatR;
using Microsoft.Extensions.Options;

164
ECMJobRunner.Tests/Application/TriggeringDEXJobCommandExceptionTests.cs Normal file
View File

@@ -0,0 +1,164 @@
using ECMJobRunner.Application.Common.Exceptions;
using FluentAssertions;
using System;
using Xunit;
namespace ECMJobRunner.Tests.Application
{
public class TriggeringDEXJobCommandExceptionTests
{
[Fact]
public void JobSqlException_HasCorrectMessage()
{
// Arrange
var jobName = "Main Query Execution";
var processName = "MainQueryExecution";
var batchId = "12345678901234567890";
var reason = "SQL syntax error";
var query = "SELECT * FROM NonExistentTable";
// Act
var exception = new JobSqlException(
jobName,
processName,
batchId,
reason,
query,
null);
// Assert
exception.JobName.Should().Be(jobName);
exception.ProcessName.Should().Be(processName);
exception.BatchId.Should().Be(batchId);
exception.Query.Should().Be(query);
exception.Message.Should().Contain(jobName);
exception.Message.Should().Contain(processName);
exception.Message.Should().Contain(batchId);
exception.Message.Should().Contain(reason);
exception.Message.Should().Contain(query);
}
[Fact]
public void JobSqlException_WithInnerException_PreservesInnerException()
{
// Arrange
var innerException = new InvalidOperationException("Database connection failed");
var exception = new JobSqlException(
"Main Query",
"Execution",
"12345678901234567890",
"Connection error",
"SELECT 1",
innerException);
// Assert
exception.InnerException.Should().Be(innerException);
exception.InnerException!.Message.Should().Be("Database connection failed");
}
[Fact]
public void JobHttpException_HasCorrectMessage()
{
// Arrange
var jobName = "ReC Request Execution";
var processName = "ReCRequestExecution";
var batchId = "12345678901234567890";
var reason = "HTTP 500 Internal Server Error";
var clientLibrary = "ReC.Client";
var clientMethod = "ExecuteAsync";
// Act
var exception = new JobHttpException(
jobName,
processName,
batchId,
reason,
clientLibrary,
clientMethod,
null);
// Assert
exception.JobName.Should().Be(jobName);
exception.ProcessName.Should().Be(processName);
exception.BatchId.Should().Be(batchId);
exception.ClientLibrary.Should().Be(clientLibrary);
exception.ClientMethod.Should().Be(clientMethod);
exception.Message.Should().Contain(jobName);
exception.Message.Should().Contain(processName);
exception.Message.Should().Contain(batchId);
exception.Message.Should().Contain(reason);
exception.Message.Should().Contain(clientLibrary);
exception.Message.Should().Contain(clientMethod);
}
[Fact]
public void JobHttpException_WithInnerException_PreservesInnerException()
{
// Arrange
var innerException = new TimeoutException("Request timed out");
var exception = new JobHttpException(
"ReC Request",
"Execution",
"12345678901234567890",
"Timeout error",
"ReC.Client",
"ExecuteAsync",
innerException);
// Assert
exception.InnerException.Should().Be(innerException);
exception.InnerException!.Message.Should().Be("Request timed out");
}
[Fact]
public void JobException_OmitsNullValues_WhenIgnoreIfNullIsTrue()
{
// Arrange & Act
var exception = new JobException(
"Test Job",
"Test Process",
"12345678901234567890",
null, // reason is null
null,
("Custom Detail", "Value", false));
// Assert
exception.Message.Should().NotContain("Reason:"); // Should be omitted because it's null and IgnoreIfNull=true
exception.Message.Should().Contain("Custom Detail: Value");
}
[Fact]
public void JobException_IncludesNullValues_WhenIgnoreIfNullIsFalse()
{
// Arrange & Act
var exception = new JobException(
"Test Job",
"Test Process",
"12345678901234567890",
null,
null,
("Custom Detail", null, false)); // IgnoreIfNull=false
// Assert
exception.Message.Should().Contain("Custom Detail:"); // Should be included even though value is null
}
[Fact]
public void JobException_FormatsMessageWithSeparators()
{
// Arrange & Act
var exception = new JobException(
"Test Job",
"Test Process",
"12345678901234567890",
"Test reason",
null);
// Assert
exception.Message.Should().Contain("─────────────────────────────────────────");
exception.Message.Should().Contain("Test Job could not be completed.");
exception.Message.Should().Contain("Process Name: Test Process");
exception.Message.Should().Contain("Batch Id: 12345678901234567890");
}
}
}