AppStd/DigitalData.UserManager
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refaktorierung der Methoden zur Benutzerzuweisung und Verbesserung der Code-Lesbarkeit

Browse Source 
- Umbenennung der Methoden `dropToAssigned` und `dropToUnassigned` in `assign` und `unassign` zur besseren Verständlichkeit
- Vereinfachung der Methoden `assign` und `unassign` durch Verwendung von `map` zur Erstellung von Benutzerarrays
This commit is contained in:
Developer 02 2024-08-08 10:20:00 +02:00
parent 255c6cb138
commit fbfe1f774c
1 changed files with 15 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
DigitalData.UserManager.API/ClientApp/user_manager_ui/src/app/pages/user-assignment/user-assignment.component.ts
View File

@ -60,11 +60,11 @@ export class UserAssignmentComponent extends BasePageComponent implements OnInit
this.transferService.add(() => { this.transferService.add(() => {
if (this.isAssignment) { if (this.isAssignment) {
this.dropToUnassigned(); this.assign();
this.refreshService.executeAll(); this.refreshService.executeAll();
} }
else if (this.isUnassignment) { else if (this.isUnassignment) {
this.dropToAssigned(); this.unassign();
this.refreshService.executeAll(); this.refreshService.executeAll();
} }
}); });
@ -73,15 +73,11 @@ export class UserAssignmentComponent extends BasePageComponent implements OnInit
target: Target = Target.Module; target: Target = Target.Module;
targetId = 0; targetId = 0;
dropToAssigned() { assign() {
var rows = this.unassignedUsers.selectedRows; var users: User[] = this.unassignedUsers.selectedRows.map(row => row.source)
var users: User[] = new Array<User>();
if (!rows) console.log(users)
return
for (var row of rows)
users.push(row.source);
this.unselectUserTables() this.unselectUserTables()
switch (this.target) { switch (this.target) {
case Target.Module: case Target.Module:
@ -95,15 +91,9 @@ export class UserAssignmentComponent extends BasePageComponent implements OnInit
} }
} }
dropToUnassigned() { unassign() {
var rows = this.assignedUsers.selectedRows; var users: User[] = this.assignedUsers.selectedRows.map(row => row.source)
var users: User[] = new Array<User>();
if (!rows)
return
for (var row of rows)
users.push(row.source);
this.unselectUserTables() this.unselectUserTables()
switch (this.target) { switch (this.target) {
case Target.Module: case Target.Module:
@ -158,15 +148,15 @@ export class UserAssignmentComponent extends BasePageComponent implements OnInit
} }
//unselection case //unselection case
private sUnassgnCount = 0; private sUnassgnCount: number = 0;
private sAssgnCount = 0; private sAssgnCount: number = 0;
private get isAssignment() { private get isAssignment(): boolean {
return this.sAssgnCount > 0; return this.sUnassgnCount > 0;
} }
private get isUnassignment() { private get isUnassignment(): boolean {
return this.sUnassgnCount > 0; return this.sAssgnCount > 0;
} }
unassignedUsersOnSelectedRows = (rows: GuiSelectedRow[]) => { unassignedUsersOnSelectedRows = (rows: GuiSelectedRow[]) => {