AppStd/DigitalData.UserManager
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(GroupOfUserController): remove try-catch block

Browse Source
This commit is contained in:
Developer 02 2025-08-05 19:48:36 +02:00
parent d252859b11
commit dda2f25b57
1 changed files with 15 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
src/DigitalData.UserManager.API/Controllers/GroupOfUserController.cs
View File

@ -14,68 +14,44 @@ public class GroupOfUserController : BaseAuthController<IGroupOfUserService, Gro
public GroupOfUserController(ILogger<GroupOfUserController> logger, IGroupOfUserService service, IUserService userService) : base(logger, service, userService) public GroupOfUserController(ILogger<GroupOfUserController> logger, IGroupOfUserService service, IUserService userService) : base(logger, service, userService)
{ {
} }
[HttpDelete] [HttpDelete]
public async Task<IActionResult> Delete([FromQuery] int groupId, [FromQuery] int userId) public async Task<IActionResult> Delete([FromQuery] int groupId, [FromQuery] int userId)
{ {
try return await _service.DeleteAsyncByGroupUserId(groupId, userId).ThenAsync(Ok, IActionResult (m, n) =>
{ {
return await _service.DeleteAsyncByGroupUserId(groupId, userId).ThenAsync(Ok, IActionResult (m, n) => _logger.LogNotice(n);
{
_logger.LogNotice(n);
return StatusCode(StatusCodes.Status500InternalServerError);
});
}
catch (Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(StatusCodes.Status500InternalServerError); return StatusCode(StatusCodes.Status500InternalServerError);
} });
} }
[NonAction] [NonAction]
public override Task<IActionResult> GetAll() => base.GetAll(); public override Task<IActionResult> GetAll() => base.GetAll();
[HttpGet] [HttpGet]
public async Task<IActionResult> GetAll([FromQuery]bool withUser = false, [FromQuery]bool withGroup = false, [FromQuery] string? username = null) public async Task<IActionResult> GetAll([FromQuery] bool withUser = false, [FromQuery] bool withGroup = false, [FromQuery] string? username = null)
{ {
try if (username is not null)
{ return await _service.ReadByUsernameAsync(username).ThenAsync(Ok, IActionResult (m, n) =>
if (username is not null)
return await _service.ReadByUsernameAsync(username).ThenAsync(Ok, IActionResult (m, n) =>
{
_logger.LogNotice(n);
return NotFound();
});
return await _service.ReadAllAsyncWith(withUser, withGroup).ThenAsync(Ok, IActionResult (m, n) =>
{ {
_logger.LogNotice(n); _logger.LogNotice(n);
return NotFound(); return NotFound();
}); });
}
catch(Exception ex) return await _service.ReadAllAsyncWith(withUser, withGroup).ThenAsync(Ok, IActionResult (m, n) =>
{ {
_logger.LogError(ex, "{Message}", ex.Message); _logger.LogNotice(n);
return StatusCode(StatusCodes.Status500InternalServerError); return NotFound();
} });
} }
[HttpGet("Has")] [HttpGet("Has")]
public async Task<IActionResult> HasGroup([FromQuery] string username, [FromQuery] string groupname) public async Task<IActionResult> HasGroup([FromQuery] string username, [FromQuery] string groupname)
{ {
try return await _service.HasGroup(username, groupname).ThenAsync(Ok, (m, n) =>
{ {
return await _service.HasGroup(username, groupname).ThenAsync(Ok, (m, n) => _logger.LogNotice(n);
{
_logger.LogNotice(n);
return StatusCode(StatusCodes.Status500InternalServerError);
});
}
catch(Exception ex)
{
_logger.LogError(ex, "{Message}", ex.Message);
return StatusCode(StatusCodes.Status500InternalServerError); return StatusCode(StatusCodes.Status500InternalServerError);
} });
} }
} }