From efdd5805d3d94db94fbe26c7a6229d337144a67d Mon Sep 17 00:00:00 2001 From: TekH Date: Mon, 2 Nov 2026 10:11:31 +0100 Subject: [PATCH] test(client): await async EmailSender.Send in integration tests Record.Exception does not observe faults from an async method. Convert the affected tests to async Task and use Record.ExceptionAsync so publish failures are actually asserted. --- .../Integration/EmailSenderTests.cs | 8 ++++---- .../Integration/EmailSenderUrlOverloadTests.cs | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderTests.cs b/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderTests.cs index 5d61418..4fbdbc5 100644 --- a/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderTests.cs +++ b/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderTests.cs @@ -74,7 +74,7 @@ public sealed class EmailSenderTests } [Fact] - public void Send_WithValidEmail_DoesNotThrow() + public async Task Send_WithValidEmail_DoesNotThrow() { var email = new EmailContext { @@ -85,13 +85,13 @@ public sealed class EmailSenderTests IsHtml = true, }; - var exception = Record.Exception(() => EmailSender.Send(email)); + var exception = await Record.ExceptionAsync(() => EmailSender.Send(email)); Assert.Null(exception); } [Fact] - public void Send_WithPlainTextBody_DoesNotThrow() + public async Task Send_WithPlainTextBody_DoesNotThrow() { var email = new EmailContext { @@ -102,7 +102,7 @@ public sealed class EmailSenderTests IsHtml = false }; - var exception = Record.Exception(() => EmailSender.Send(email)); + var exception = await Record.ExceptionAsync(() => EmailSender.Send(email)); Assert.Null(exception); } diff --git a/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderUrlOverloadTests.cs b/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderUrlOverloadTests.cs index ef84b44..eaadc64 100644 --- a/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderUrlOverloadTests.cs +++ b/tests/DigitalData.MessagingService.Tests/Integration/EmailSenderUrlOverloadTests.cs @@ -54,7 +54,7 @@ public sealed class EmailSenderUrlOverloadTests } [Fact] - public void Send_AfterUrlOverloadConnection_DoesNotThrow() + public async Task Send_AfterUrlOverloadConnection_DoesNotThrow() { var email = new EmailContext { @@ -67,7 +67,7 @@ public sealed class EmailSenderUrlOverloadTests // Connection was established via Action<> overload in the fixture; // Send should work regardless of which overload was used to connect. - var exception = Record.Exception(() => EmailSender.Send(email)); + var exception = await Record.ExceptionAsync(() => EmailSender.Send(email)); Assert.Null(exception); }