AppStd/DigitalData.MessagingService
8
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor email handling for multiple recipients

Browse Source 
Refactored the `Email` and `OutgoingEmailEvent` classes to replace the `Recipient` property with a `Recipients` collection, enabling support for multiple recipients. Updated all related test cases, including `EmailSenderTests`, `EmailSenderUrlOverloadTests`, and `OutgoingEmailPublisherTests`, to reflect this change.

Moved the `EmailAccountDto` class and its references from the `DigitalData.MessagingService.Application.Common.Dtos` namespace to the `DigitalData.MessagingService.Publisher.Abstraction` namespace for better code organization. Updated `using` directives across affected files.

Removed unused `using` directives and updated the `Email` class's `ToEvent` method to map the new `Recipients` property. Adjusted test assertions to validate collections instead of single recipient strings.
This commit is contained in:
tekh
2026-08-05 13:11:19 +02:00
parent e47333cd1d
commit 0d9d15032f
12 changed files with 17 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/DigitalData.MessagingService.Application/Common/Interfaces/IEmailService.cs
View File

@@ -1,4 +1,4 @@
using DigitalData.MessagingService.Application.Common.Dtos;
using DigitalData.MessagingService.Publisher.Abstraction;
namespace DigitalData.MessagingService.Application.Common.Interfaces;

2
src/core/DigitalData.MessagingService.Application/Common/Options/EmailAccountsOptions.cs
View File

@@ -1,4 +1,4 @@
using DigitalData.MessagingService.Application.Common.Dtos;
using DigitalData.MessagingService.Publisher.Abstraction;
namespace DigitalData.MessagingService.Application.Common.Options;

4
src/core/DigitalData.MessagingService.Application/EmailAccount/Queries/GetSenderQuery.cs
View File

@@ -1,5 +1,5 @@
using DigitalData.MessagingService.Application.Common.Dtos;
using DigitalData.MessagingService.Application.Common.Options;
using DigitalData.MessagingService.Application.Common.Options;
using DigitalData.MessagingService.Publisher.Abstraction;
using MediatR;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;

1
src/core/DigitalData.MessagingService.Application/EmailSending/Commands/SendEmailCommand.cs
View File

@@ -1,5 +1,4 @@
using AutoMapper;
using DigitalData.MessagingService.Application.Common.Dtos;
using DigitalData.MessagingService.Application.EmailAccount.Queries;
using DigitalData.MessagingService.Domain.Exceptions;
using DigitalData.MessagingService.Publisher.Abstraction;

2
src/core/DigitalData.MessagingService.Publisher.Abstraction/EmailAccountDto.cs
View File

@@ -1,4 +1,4 @@
namespace DigitalData.MessagingService.Application.Common.Dtos;
namespace DigitalData.MessagingService.Publisher.Abstraction;
/// <summary>
/// DTO for a single email account configuration.

4
src/core/DigitalData.MessagingService.Publisher.Abstraction/OutgoingEmailEvent.cs
View File

@@ -1,6 +1,4 @@
using DigitalData.MessagingService.Application.Common.Dtos;
namespace DigitalData.MessagingService.Publisher.Abstraction;
namespace DigitalData.MessagingService.Publisher.Abstraction;
public record OutgoingEmailEvent
{

4
src/infrastructure/DigitalData.MessagingService.Infrastructure/Services/LimilabsEmailService.cs
View File

@@ -1,13 +1,11 @@
using System.Text;
using DigitalData.MessagingService.Application.Common.Dtos;
using DigitalData.MessagingService.Application.Common.Interfaces;
using DigitalData.MessagingService.Domain.Exceptions;
using Limilabs.Client.SMTP;
using Limilabs.Mail;
using Limilabs.Mail.Headers;
using Microsoft.Extensions.Options;
using DigitalData.MessagingService.Application.Common.Options;
using DigitalData.MessagingService.Infrastructure.Services.Extensions;
using DigitalData.MessagingService.Publisher.Abstraction;
namespace DigitalData.MessagingService.Infrastructure.Services;

1
src/presentation/DigitalData.MessagingService.API/Program.cs
View File

@@ -1,6 +1,5 @@
using DigitalData.MessagingService.API.Middleware;
using DigitalData.MessagingService.Application;
using DigitalData.MessagingService.Application.Common.Dtos;
using DigitalData.MessagingService.Infrastructure;
using Serilog;
using Serilog.Ui.Core.Extensions;

4
src/presentation/DigitalData.MessagingService.Client/Email.cs
View File

@@ -10,7 +10,7 @@ public record Email
/// <summary>
/// Recipient email address
/// </summary>
public string Recipient { get; set; } = null!;
public IEnumerable<string> Recipients { get; set; } = null!;
/// <summary>
/// Email subject
@@ -36,7 +36,7 @@ public record Email
return new OutgoingEmailEvent
{
Id = Guid.NewGuid(),
Recipient = Recipient,
Recipients = Recipients,
Subject = Subject,
Body = Body,
IsHtml = IsHtml,

4
tests/DigitalData.MessagingService.Tests/Integration/EmailSenderTests.cs
View File

@@ -77,7 +77,7 @@ public sealed class EmailSenderTests
{
var email = new Email
{
Recipient = "hakanttek@gmail.com",
Recipients = ["hakanttek@gmail.com"],
Subject = "EmailSender.Send Integration Test",
Body = "<p>Sent via EmailSender static client.</p>",
IsHtml = true,
@@ -93,7 +93,7 @@ public sealed class EmailSenderTests
{
var email = new Email
{
Recipient = "hakanttek@gmail.com",
Recipients = ["hakanttek@gmail.com"],
Subject = "Plain Text Test",
Body = "This is a plain text email.",
IsHtml = false

2
tests/DigitalData.MessagingService.Tests/Integration/EmailSenderUrlOverloadTests.cs
View File

@@ -57,7 +57,7 @@ public sealed class EmailSenderUrlOverloadTests
{
var email = new Email
{
Recipient = "url-overload-test@example.com",
Recipients = ["url-overload-test@example.com"],
Subject = "URL Overload Integration Test",
Body = "<p>Sent after URL-based connection.</p>",
IsHtml = true

10
tests/DigitalData.MessagingService.Tests/Integration/OutgoingEmailPublisherTests.cs
View File

@@ -37,7 +37,7 @@ public sealed class OutgoingEmailPublisherTests : IAsyncDisposable
var email = new OutgoingEmailEvent
{
Id = Guid.NewGuid(),
Recipient = "test@example.com",
Recipients = ["test@example.com"],
Subject = "Integration Test - EnqueueAsync",
Body = "<p>Hello from integration test.</p>",
IsHtml = true,
@@ -62,7 +62,7 @@ public sealed class OutgoingEmailPublisherTests : IAsyncDisposable
var emails = Enumerable.Range(1, 3).Select(i => new OutgoingEmailEvent
{
Id = Guid.NewGuid(),
Recipient = $"recipient{i}@example.com",
Recipients = new List<string> { $"recipient{i}@example.com" },
Subject = $"Integration Test - Batch #{i}",
Body = $"Batch message {i}",
IsHtml = false,
@@ -85,7 +85,7 @@ public sealed class OutgoingEmailPublisherTests : IAsyncDisposable
var email = new OutgoingEmailEvent
{
Id = Guid.NewGuid(),
Recipient = "depth-test@example.com",
Recipients = ["depth-test@example.com"],
Subject = "Integration Test - GetQueueDepth",
Body = "Queue depth test",
IsHtml = false,
@@ -108,7 +108,7 @@ public sealed class OutgoingEmailPublisherTests : IAsyncDisposable
var email = new OutgoingEmailEvent
{
Id = id,
Recipient = "serialize@example.com",
Recipients = new List<string> { "serialize@example.com" },
Subject = "Serialization Test",
Body = "<strong>Bold</strong>",
IsHtml = true,
@@ -123,7 +123,7 @@ public sealed class OutgoingEmailPublisherTests : IAsyncDisposable
Assert.NotNull(received);
Assert.Equal(id, received.Id);
Assert.Equal("serialize@example.com", received.Recipient);
Assert.Equal(["serialize@example.com"], received.Recipients);
Assert.Equal("Serialization Test", received.Subject);
Assert.Equal("<strong>Bold</strong>", received.Body);
Assert.True(received.IsHtml);