AppStd/DigitalData.Core
Template
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refaktorisierung von CRUDControllerBase zur Nutzung des Result-Musters für eine sauberere Fehlerbehandlung und Codestruktur.

Browse Source
This commit is contained in:
Developer 02 2024-05-03 09:36:26 +02:00
parent f5c0a76f30
commit efb573b945
1 changed files with 41 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
DigitalData.Core.API/CRUDControllerBase.cs
View File

@ -50,16 +50,19 @@ namespace DigitalData.Core.API
[HttpPost] [HttpPost]
public virtual async Task<IActionResult> Create(TCreateDto createDto) public virtual async Task<IActionResult> Create(TCreateDto createDto)
{ {
var result = await _service.CreateAsync(createDto); return await _service.CreateAsync(createDto).ThenAsync<TId, IActionResult>(
if (result.IsSuccess) Success: id =>
{ {
var createdResource = new { Id = result.Data }; var createdResource = new { Id = id };
var actionName = nameof(GetById); var actionName = nameof(GetById);
var routeValues = new { id = createdResource.Id }; var routeValues = new { id = createdResource.Id };
return CreatedAtAction(actionName, routeValues, createdResource); return CreatedAtAction(actionName, routeValues, createdResource);
} },
Fail: (messages, notices) =>
return BadRequest(result); {
_logger.LogNotice(notices);
return BadRequest(messages);
});
} }
/// <summary> /// <summary>
@ -70,12 +73,13 @@ namespace DigitalData.Core.API
[HttpGet("{id}")] [HttpGet("{id}")]
public virtual async Task<IActionResult> GetById([FromRoute] TId id) public virtual async Task<IActionResult> GetById([FromRoute] TId id)
{ {
var result = await _service.ReadByIdAsync(id); return await _service.ReadByIdAsync(id).ThenAsync(
if (result.IsSuccess) Success: Ok,
{ Fail: IActionResult (messages, notices) =>
return Ok(result); {
} _logger.LogNotice(notices);
return NotFound(result); return NotFound(messages);
});
} }
/// <summary> /// <summary>
@ -85,12 +89,13 @@ namespace DigitalData.Core.API
[HttpGet] [HttpGet]
public virtual async Task<IActionResult> GetAll() public virtual async Task<IActionResult> GetAll()
{ {
var result = await _service.ReadAllAsync(); return await _service.ReadAllAsync().ThenAsync(
if (result.IsSuccess) Success: Ok,
{ Fail: IActionResult (messages, notices) =>
return Ok(result); {
} _logger.LogNotice(notices);
return NotFound(result); return NotFound(messages);
});
} }
/// <summary> /// <summary>
@ -101,12 +106,13 @@ namespace DigitalData.Core.API
[HttpPut] [HttpPut]
public virtual async Task<IActionResult> Update(TUpdateDto updateDto) public virtual async Task<IActionResult> Update(TUpdateDto updateDto)
{ {
var result = await _service.UpdateAsync(updateDto); return await _service.UpdateAsync(updateDto).ThenAsync(
if (result.IsSuccess) Success: Ok,
{ Fail: IActionResult (messages, notices) =>
return Ok(result); {
} _logger.LogNotice(notices);
return BadRequest(result); return BadRequest(messages);
});
} }
/// <summary> /// <summary>
@ -117,13 +123,13 @@ namespace DigitalData.Core.API
[HttpDelete("{id}")] [HttpDelete("{id}")]
public virtual async Task<IActionResult> Delete([FromRoute] TId id) public virtual async Task<IActionResult> Delete([FromRoute] TId id)
{ {
var result = await _service.DeleteAsyncById(id); return await _service.DeleteAsyncById(id).ThenAsync(
if (result.IsSuccess) Success: Ok,
{ Fail: IActionResult (messages, notices) =>
return Ok(result); {
} _logger.LogNotice(notices);
return BadRequest(result); return BadRequest(messages);
});
} }
} }
} }