From c69635fc4365147afe69953de24184be0de8f2cb Mon Sep 17 00:00:00 2001
From: TekH <h.tek@digitaldata.works>
Date: Fri, 29 May 2026 10:21:50 +0200
Subject: [PATCH] Refactor and enhance CookieNamesTests methods

Refactored and renamed several test methods in `CookieNamesTests` to improve clarity and align with updated functionality. Replaced methods testing `GetEnvelopeReceiverKeyOrDefault` with new methods for `GetEnvelopeReceiverCookieName` and `GetEnvelopeKeyOrDefault`. Added new tests to validate behavior with default cookie names and incorrect bases. Renamed `TryGetEnvelopeReceiverKey` methods to `TryGetEnvelopeKey` for consistency, while maintaining their functionality.
---
 .../Claims/CookieNamesTests.cs                | 72 +++++++++++++++++--
 1 file changed, 66 insertions(+), 6 deletions(-)

diff --git a/DigitalData.Auth.Tests/Claims/CookieNamesTests.cs b/DigitalData.Auth.Tests/Claims/CookieNamesTests.cs
index b229ba1..d79cac1 100644
--- a/DigitalData.Auth.Tests/Claims/CookieNamesTests.cs
+++ b/DigitalData.Auth.Tests/Claims/CookieNamesTests.cs
@@ -22,7 +22,20 @@ public class CookieNamesTests
     }
 
     [Test]
-    public void GetEnvelopeReceiverKeyOrDefault_ShouldReturnKey_WhenCookieNameIsValid()
+    public void GetEnvelopeReceiverCookieName_WithKeyOnly_ShouldUseDefaultCookieName()
+    {
+        // Arrange
+        var expected = $"{DefaultCookieName}SignFLOWReceiver.{Key}";
+
+        // Act
+        var result = CookieNames.GetEnvelopeReceiverCookieName(Key);
+
+        // Assert
+        Assert.That(result, Is.EqualTo(expected));
+    }
+
+    [Test]
+    public void GetEnvelopeKeyOrDefault_ShouldReturnKey_WhenCookieNameIsValid()
     {
         // Arrange
         var cookieName = CookieNames.GetEnvelopeReceiverCookieName(DefaultCookieName, Key);
@@ -35,7 +48,20 @@ public class CookieNamesTests
     }
 
     [Test]
-    public void GetEnvelopeReceiverKeyOrDefault_ShouldReturnNull_WhenCookieNameHasWrongBase()
+    public void GetEnvelopeKeyOrDefault_WithDefaultParam_ShouldReturnKey_WhenCookieUsesDefaultBase()
+    {
+        // Arrange
+        var cookieName = CookieNames.GetEnvelopeReceiverCookieName(Key); // uses "AuthToken" base
+
+        // Act
+        var result = CookieNames.GetEnvelopeKeyOrDefault(cookieName); // defaultCookieName = "AuthToken"
+
+        // Assert
+        Assert.That(result, Is.EqualTo(Key));
+    }
+
+    [Test]
+    public void GetEnvelopeKeyOrDefault_ShouldReturnNull_WhenCookieNameHasWrongBase()
     {
         // Arrange
         var cookieName = CookieNames.GetEnvelopeReceiverCookieName("OtherCookie", Key);
@@ -48,7 +74,7 @@ public class CookieNamesTests
     }
 
     [Test]
-    public void GetEnvelopeReceiverKeyOrDefault_ShouldReturnNull_WhenCookieNameIsUnrelated()
+    public void GetEnvelopeKeyOrDefault_ShouldReturnNull_WhenCookieNameIsUnrelated()
     {
         // Act
         var result = CookieNames.GetEnvelopeKeyOrDefault("SomeOtherCookie", DefaultCookieName);
@@ -58,7 +84,41 @@ public class CookieNamesTests
     }
 
     [Test]
-    public void TryGetEnvelopeReceiverKey_ShouldReturnTrueAndKey_WhenCookieNameIsValid()
+    public void TryGetEnvelopeKey_WithDefaultCookieName_ShouldReturnTrueAndKey_WhenCookieNameIsValid()
+    {
+        // Arrange
+        var cookieName = CookieNames.GetEnvelopeReceiverCookieName(Key); // uses "AuthToken" base
+
+        // Act
+        var success = CookieNames.TryGetEnvelopeKey(cookieName, out var key);
+
+        // Assert
+        Assert.Multiple(() =>
+        {
+            Assert.That(success, Is.True);
+            Assert.That(key, Is.EqualTo(Key));
+        });
+    }
+
+    [Test]
+    public void TryGetEnvelopeKey_WithDefaultCookieName_ShouldReturnFalse_WhenCookieNameHasWrongBase()
+    {
+        // Arrange
+        var cookieName = CookieNames.GetEnvelopeReceiverCookieName("OtherCookie", Key);
+
+        // Act
+        var success = CookieNames.TryGetEnvelopeKey(cookieName, out var key);
+
+        // Assert
+        Assert.Multiple(() =>
+        {
+            Assert.That(success, Is.False);
+            Assert.That(key, Is.Null);
+        });
+    }
+
+    [Test]
+    public void TryGetEnvelopeKey_ShouldReturnTrueAndKey_WhenCookieNameIsValid()
     {
         // Arrange
         var cookieName = CookieNames.GetEnvelopeReceiverCookieName(DefaultCookieName, Key);
@@ -75,7 +135,7 @@ public class CookieNamesTests
     }
 
     [Test]
-    public void TryGetEnvelopeReceiverKey_ShouldReturnFalse_WhenCookieNameHasWrongBase()
+    public void TryGetEnvelopeKey_ShouldReturnFalse_WhenCookieNameHasWrongBase()
     {
         // Arrange
         var cookieName = CookieNames.GetEnvelopeReceiverCookieName("OtherCookie", Key);
@@ -92,7 +152,7 @@ public class CookieNamesTests
     }
 
     [Test]
-    public void TryGetEnvelopeReceiverKey_ShouldReturnFalse_WhenCookieNameIsUnrelated()
+    public void TryGetEnvelopeKey_ShouldReturnFalse_WhenCookieNameIsUnrelated()
     {
         // Act
         var success = CookieNames.TryGetEnvelopeKey("SomeOtherCookie", DefaultCookieName, out var key);