AppStd/DigitalData.Auth
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor cookie name methods and update tests

Browse Source 
Renamed and refactored methods in `CookieNames` to improve naming consistency and simplify usage. Added overloads with default `defaultCookieName` set to `"AuthToken"`. Updated XML documentation to reflect these changes.

Updated `CookieNamesTests` to use the new method names and signatures. Adjusted test cases to align with the new default behavior and ensure compatibility.

These changes enhance code readability, reduce redundancy, and standardize method naming conventions.
This commit is contained in:
tekh
2026-05-29 10:21:27 +02:00
parent f455241af1
commit 98fbbea5c3
2 changed files with 32 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
DigitalData.Auth.Tests/Claims/CookieNamesTests.cs
View File

@@ -28,7 +28,7 @@ public class CookieNamesTests
var cookieName = CookieNames.GetEnvelopeReceiverCookieName(DefaultCookieName, Key);
// Act
var result = CookieNames.GetEnvelopeReceiverKeyOrDefault(cookieName, DefaultCookieName);
var result = CookieNames.GetEnvelopeKeyOrDefault(cookieName, DefaultCookieName);
// Assert
Assert.That(result, Is.EqualTo(Key));
@@ -41,7 +41,7 @@ public class CookieNamesTests
var cookieName = CookieNames.GetEnvelopeReceiverCookieName("OtherCookie", Key);
// Act
var result = CookieNames.GetEnvelopeReceiverKeyOrDefault(cookieName, DefaultCookieName);
var result = CookieNames.GetEnvelopeKeyOrDefault(cookieName, DefaultCookieName);
// Assert
Assert.That(result, Is.Null);
@@ -51,7 +51,7 @@ public class CookieNamesTests
public void GetEnvelopeReceiverKeyOrDefault_ShouldReturnNull_WhenCookieNameIsUnrelated()
{
// Act
var result = CookieNames.GetEnvelopeReceiverKeyOrDefault("SomeOtherCookie", DefaultCookieName);
var result = CookieNames.GetEnvelopeKeyOrDefault("SomeOtherCookie", DefaultCookieName);
// Assert
Assert.That(result, Is.Null);
@@ -64,7 +64,7 @@ public class CookieNamesTests
var cookieName = CookieNames.GetEnvelopeReceiverCookieName(DefaultCookieName, Key);
// Act
var success = CookieNames.TryGetEnvelopeReceiverKey(cookieName, DefaultCookieName, out var key);
var success = CookieNames.TryGetEnvelopeKey(cookieName, DefaultCookieName, out var key);
// Assert
Assert.Multiple(() =>
@@ -81,7 +81,7 @@ public class CookieNamesTests
var cookieName = CookieNames.GetEnvelopeReceiverCookieName("OtherCookie", Key);
// Act
var success = CookieNames.TryGetEnvelopeReceiverKey(cookieName, DefaultCookieName, out var key);
var success = CookieNames.TryGetEnvelopeKey(cookieName, DefaultCookieName, out var key);
// Assert
Assert.Multiple(() =>
@@ -95,7 +95,7 @@ public class CookieNamesTests
public void TryGetEnvelopeReceiverKey_ShouldReturnFalse_WhenCookieNameIsUnrelated()
{
// Act
var success = CookieNames.TryGetEnvelopeReceiverKey("SomeOtherCookie", DefaultCookieName, out var key);
var success = CookieNames.TryGetEnvelopeKey("SomeOtherCookie", DefaultCookieName, out var key);
// Assert
Assert.Multiple(() =>
@@ -112,7 +112,7 @@ public class CookieNamesTests
var cookieName = CookieNames.GetEnvelopeReceiverCookieName(DefaultCookieName, Key);
// Act
var extractedKey = CookieNames.GetEnvelopeReceiverKeyOrDefault(cookieName, DefaultCookieName);
var extractedKey = CookieNames.GetEnvelopeKeyOrDefault(cookieName, DefaultCookieName);
// Assert
Assert.That(extractedKey, Is.EqualTo(Key));