AppStd/DbFirst
8
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor query string construction in GetAllAsync

Browse Source 
Refactored the GetAllAsync method to use a Dictionary and QueryHelpers.AddQueryString for building query strings, replacing manual string concatenation. This improves code clarity and reduces the risk of formatting errors.
This commit is contained in:
OlgunR
2026-05-11 15:59:07 +02:00
parent d4b7f02c5e
commit bf98432e20
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
DbFirst.BlazorWebApp/Services/MassDataApiClient.cs
View File

@@ -1,5 +1,6 @@
using DbFirst.BlazorWebApp.Models; using DbFirst.BlazorWebApp.Models;
using DbFirst.Contracts.MassData; using DbFirst.Contracts.MassData;
using Microsoft.AspNetCore.WebUtilities;
namespace DbFirst.BlazorWebApp.Services; namespace DbFirst.BlazorWebApp.Services;
@@ -21,17 +22,11 @@ public class MassDataApiClient : IMassDataApiClient
public async Task<List<MassDataReadDto>> GetAllAsync(int? skip, int? take, CancellationToken ct = default) public async Task<List<MassDataReadDto>> GetAllAsync(int? skip, int? take, CancellationToken ct = default)
{ {
var query = new List<string>(); var query = new Dictionary<string, string?>();
if (skip.HasValue) if (skip.HasValue) query["skip"] = skip.Value.ToString();
{ if (take.HasValue) query["take"] = take.Value.ToString();
query.Add($"skip={skip.Value}");
}
if (take.HasValue)
{
query.Add($"take={take.Value}");
}
var url = query.Count == 0 ? Endpoint : $"{Endpoint}?{string.Join("&", query)}"; var url = QueryHelpers.AddQueryString(Endpoint, query);
var result = await _httpClient.GetFromJsonAsync<List<MassDataReadDto>>(url, ct); var result = await _httpClient.GetFromJsonAsync<List<MassDataReadDto>>(url, ct);
return result ?? []; return result ?? [];
} }